Title: Keep deque contents and bounds in coherent shared state by youknowdot · Pull Request #9457 · RustPython/RustPython · GitHub
Open Graph Title: Keep deque contents and bounds in coherent shared state by youknowdot · Pull Request #9457 · RustPython/RustPython
X Title: Keep deque contents and bounds in coherent shared state by youknowdot · Pull Request #9457 · RustPython/RustPython
Description: Summary Keep deque contents and maxlen in one synchronized payload, removing the shared maxlen mutation through a cast. Use the existing creator-bound PyOperation for writers and index/copy, preserving reentrant callbacks outside short payload locks. Match CPython's ordering for index-bound conversion, successful/raising comparisons, iterator mutation checks, initialization, extension, and subclass copying. Import the whole test_free_threading/test_collections.py through scripts/update_lib, pinned to CPython d220409a13b77de7a6c30abe16ea90db01528edc. This is independent of #9439. Its existing operation-guard prerequisite from #9449 is already on main. CPython basis _collectionsmodule.c: index lines 1262–1323, extend lines 479–574, copy lines 593–660, initialization lines 1755–1777, and iterator traversal lines 1969–2005 / 2120–2156. Clinic argument conversion: start and stop conversion precedes entering the index operation. Validation The exact two changed files were validated on main b85582d57063c892fdf1839a495e47e5bf8e78be before the execution environment was replaced: Scoped cargo check and strict Clippy passed. A CLI build passed. Eight ordinary canonical test_deque methods passed: copy/copy_method, index regression 24913, maxlen attribute/zero, initialization, altered iterator data, and mutation of an initially empty iterator. Ten bounded serial callback/argument-conversion cases matched pinned CPython 3.15 exactly, including index mutation and subclass-copy behavior. Both changed files are restored byte-for-byte from that validated patch. The later main changes through 698c196b2e188c46772f8a3cf76164227282a645 affect SQLite, regex, Windows overlapped cleanup, and an asyncio snippet; none overlap the deque implementation or operation guard. The binary was lost when the environment was replaced, so these are recorded earlier runs, not fresh execution on the final main base. Hosted CI must validate the published commit. The new whole free-threading module was not run locally. No full workspace/C-API suites, concurrent/GC/destructor/stress tests, or broad thread-safety claim are included. Remaining count/contains/richcompare, integer-width/error-text, GC/finalizer and cross-interpreter behavior is outside this change's scope. AI assistance: OpenAI Codex (model version unavailable). Summary by CodeRabbit Bug Fixes Improved deque handling of maximum lengths during initialization, insertion, and repetition. Corrected index conversion for deque operations, including support for objects implementing __index__ and safe handling of out-of-range values. Improved mutation detection during comparisons and iteration, and ensured iterator errors behave consistently. Fixed deque state handling in copying, concatenation, multiplication, and pickling. Improved error reporting when allocation fails during in-place multiplication.
Open Graph Description: Summary Keep deque contents and maxlen in one synchronized payload, removing the shared maxlen mutation through a cast. Use the existing creator-bound PyOperation for writers and index/copy, prese...
X Description: Summary Keep deque contents and maxlen in one synchronized payload, removing the shared maxlen mutation through a cast. Use the existing creator-bound PyOperation for writers and index/copy, prese...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9457
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fec1899b-7023-a50f-f09b-f7a6b89d56bf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDB6:3E4205:3242874:4325A6D:6B01F930 |
| html-safe-nonce | 447d1c1ff3fb4630838ed0ff626596b895821fb66e2f26469e661bbef44fd212 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREI2OjNFNDIwNTozMjQyODc0OjQzMjVBNkQ6NkIwMUY5MzAiLCJ2aXNpdG9yX2lkIjoiODkyNTY0NzMxMDg3MzAzMzAwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3ec60066f637aab256e2f1dc3571728b1b23863fea8f6abef747f889deeb16cf |
| hovercard-subject-tag | pull_request:5066738030 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9457/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Keep deque contents and maxlen in one synchronized payload, removing the shared maxlen mutation through a cast. Use the existing creator-bound PyOperation for writers and index/copy, prese... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width