René's URL Explorer Experiment


Title: Fix 32-bit random bit counts and hash compatibility by youknowone · Pull Request #9437 · RustPython/RustPython · GitHub

Open Graph Title: Fix 32-bit random bit counts and hash compatibility by youknowone · Pull Request #9437 · RustPython/RustPython

X Title: Fix 32-bit random bit counts and hash compatibility by youknowone · Pull Request #9437 · RustPython/RustPython

Description: Summary Fix three reproducible Windows x86 compatibility failures without modifying Lib/ or existing test assertions: Accept u64 bit counts in random.getrandbits(), matching CPython 3.15. Previously 2**31 was rejected on x86. Check the word allocation size and reserve fallibly before advancing the RNG. Use native-word arithmetic for frozenset hashing so equal sets agree with collections.abc.Set._hash(), which masks using sys.maxsize. Existing 64-bit results are unchanged. Use a fixed 64-bit slice-length prefix for byte/string hashing. This preserves existing x64 digests and fixes the existing fixed-key digest regression on x86; bytes, str, and memoryview remain hash-compatible. Add Rust regression coverage for allocation boundaries and set hashing. Only crates/common/src/hash.rs and crates/stdlib/src/random.rs change. C API, ctypes, PyO3, and CI are untouched. Validation Actual Windows x86 and x64 release runs: all 12 relevant modules pass on each architecture (2,143 tests run, 136 skipped): random, secrets, uuid, statistics, collections, set, dict, tuple, hash, dictviews, bytes, memoryview. x86 common hash unit tests: all 3 pass, including the previously failing fixed-key digest assertion. Full native workspace tests and all-targets Clippy with -D warnings pass, excluding wasm, venvlauncher, and C API. Separate C API Clippy passes. Separate C API tests were attempted but remain blocked by missing pythonXY.lib; no C API workaround is included. Formatting, pre-commit hooks, focused automated review, and CPython comparisons pass. Oversized/negative random requests raise the expected exception without changing RNG state. Investigation, implementation, validation, and focused automated review were assisted by Codex. The automated review is not human review. Summary by CodeRabbit Bug Fixes Improved hash consistency for byte sequences and set values. Improved handling of large getrandbits requests: unrepresentable or excessively large requests now return a memory error instead of proceeding with an invalid allocation. Allocation failures are also handled safely.

Open Graph Description: Summary Fix three reproducible Windows x86 compatibility failures without modifying Lib/ or existing test assertions: Accept u64 bit counts in random.getrandbits(), matching CPython 3.15. Previous...

X Description: Summary Fix three reproducible Windows x86 compatibility failures without modifying Lib/ or existing test assertions: Accept u64 bit counts in random.getrandbits(), matching CPython 3.15. Previous...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9437

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3abaab44-11e2-727f-6912-b108987deea0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA94E:3F8AB1:3EC4838:4FB29B6:6B01FA5F
html-safe-noncecda5c9ff8158df1b78ce088f6cd87fa6b0854662de4166294cb3d0b85895facc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTRFOjNGOEFCMTozRUM0ODM4OjRGQjI5QjY6NkIwMUZBNUYiLCJ2aXNpdG9yX2lkIjoiMjEyNTY4NjIyNjkxMTYyMzc3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac020a170a185da9425e07e463aee6bad26853d301a4227527ed31577562397ae1
hovercard-subject-tagpull_request:5052776350
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9437/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altSummary Fix three reproducible Windows x86 compatibility failures without modifying Lib/ or existing test assertions: Accept u64 bit counts in random.getrandbits(), matching CPython 3.15. Previous...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9437/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9437%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9437%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9437/files
Reloadhttps://github.com/RustPython/RustPython/pull/9437/files
Reloadhttps://github.com/RustPython/RustPython/pull/9437/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:windows-x86-random-bitshttps://github.com/youknowone/RustPython/tree/windows-x86-random-bits
Conversation 2 https://github.com/RustPython/RustPython/pull/9437
Commits 1 https://github.com/RustPython/RustPython/pull/9437/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9437/checks
Files changed https://github.com/RustPython/RustPython/pull/9437/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9437/files
Fix 32-bit random bit counts and hash compatibility https://github.com/RustPython/RustPython/pull/9437/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9437/files
b78f2d3 Fix 32-bit random bit counts and hash compatibility youknowone Oct 28, 2026 https://github.com/RustPython/RustPython/pull/9437/commits/b78f2d33b00c93f49c7b07172ca50bea0c4a2caf
Clear filters https://github.com/RustPython/RustPython/pull/9437/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9437/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9437/files
hash.rs https://github.com/RustPython/RustPython/pull/9437/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
random.rs https://github.com/RustPython/RustPython/pull/9437/files#diff-931bc0f3f2b22d421df86bcc3650d405a9a4db72708d027573f179e01ed8f9ff
crates/common/src/hash.rshttps://github.com/RustPython/RustPython/pull/9437/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
View file https://github.com/youknowone/RustPython/blob/b78f2d33b00c93f49c7b07172ca50bea0c4a2caf/crates/common/src/hash.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9437/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9437/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
https://github.com/RustPython/RustPython/pull/9437/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
https://github.com/RustPython/RustPython/pull/9437/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
https://github.com/RustPython/RustPython/pull/9437/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
https://github.com/RustPython/RustPython/pull/9437/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
https://github.com/RustPython/RustPython/pull/9437/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
crates/stdlib/src/random.rshttps://github.com/RustPython/RustPython/pull/9437/files#diff-931bc0f3f2b22d421df86bcc3650d405a9a4db72708d027573f179e01ed8f9ff
View file https://github.com/youknowone/RustPython/blob/b78f2d33b00c93f49c7b07172ca50bea0c4a2caf/crates/stdlib/src/random.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9437/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9437/files#diff-931bc0f3f2b22d421df86bcc3650d405a9a4db72708d027573f179e01ed8f9ff
https://github.com/RustPython/RustPython/pull/9437/files#diff-931bc0f3f2b22d421df86bcc3650d405a9a4db72708d027573f179e01ed8f9ff
https://github.com/RustPython/RustPython/pull/9437/files#diff-931bc0f3f2b22d421df86bcc3650d405a9a4db72708d027573f179e01ed8f9ff
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9437/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.