René's URL Explorer Experiment


Title: Fix Windows/x86 deallocation and sequence compatibility by youknowone · Pull Request #9427 · RustPython/RustPython · GitHub

Open Graph Title: Fix Windows/x86 deallocation and sequence compatibility by youknowone · Pull Request #9427 · RustPython/RustPython

X Title: Fix Windows/x86 deallocation and sequence compatibility by youknowone · Pull Request #9427 · RustPython/RustPython

Description: Summary Follow up #9412, keeping C API, ctypes, PyO3, and CI changes out of scope. Adopt the merged remainder fix from RustPython/pymath#21 and remove the now-passing Windows testRemainder expected-failure marker. Keep deferred object deallocation inside an active trashcan context. Previously, draining the queue could recursively start another drain and overflow the Windows stack while deleting a 500,000-deep Element tree. Use the declared 64-bit PyHash width for tuple hashing on x86, rather than mixing 32-bit xxHash parameters with a 64-bit accumulator. Raise MemoryError for oversized sequence repetition/allocation, matching CPython. The existing public helper name/signature is retained; this also corrects the shared array.fromfile size check. Preserve long range iterator positions as locked BigInts instead of truncating them to usize. Clamp restored positions and keep exhausted iterators from wrapping back to their start. Five Rust regression tests cover deferred-drain guards, tuple hash vectors, allocation overflow, arbitrary-precision iterator state, and exhausted counter wraparound. Existing Python assertions/data are unchanged, and source skip decorators remain unchanged. Validation Actual Windows x64 and optimized i686-pc-windows-msvc interpreters: all 17 modules below passed on each architecture (reported run=3,001, skipped=149): test_int test_range test_long test_float test_dict test_set test_hash test_sysconfig test_struct test_math test_xml_etree test_xml_etree_c test_gc test_list test_tuple test_deque test_array. The existing 500,000-deep XML deepcopy test passed on x64 and x86 when unskipped only at runtime; native Element deletion was also checked on x64. The existing skipped range state/pickle-compatibility tests likewise passed when invoked at runtime on x86. Additional Windows x64 path, selector, registry, SSL, shutil, tempfile, and console suites passed (9 files; reported run=2,244, skipped=613). cargo test --workspace --exclude rustpython_wasm --exclude rustpython-venvlauncher --exclude rustpython-capi passed, including the new regression tests. Workspace/all-targets Clippy with the same exclusions and -D warnings passed. Only the existing linker-messages warning remains, which is not governed by -D warnings. Formatting, diff checks, all applicable pre-commit hooks, and focused pre-commit reviews passed. Interpreter verification used optimized debug/test builds; a fresh LTO release build was not attempted with less than 2 GB free on the build drive. A separate C API test attempt remains blocked by LNK1181 (pythonXY.lib missing); its link setup is unchanged here. AI assistance Codex assisted with implementation, investigation, validation, focused review, and this PR description. Runtime checks were executed on Windows x64 and x86; no human review is claimed. Summary by CodeRabbit Bug Fixes Improved range iteration for very large ranges, including accurate state and length reporting beyond platform-sized limits. Fixed exhausted range iterators so repeated calls do not advance or wrap their internal position. Repetition counts that exceed the supported size now raise a memory error. Improved cleanup behavior to prevent nested cleanup operations from interrupting deferred work. Made tuple hashing consistent across 32-bit and 64-bit platforms.

Open Graph Description: Summary Follow up #9412, keeping C API, ctypes, PyO3, and CI changes out of scope. Adopt the merged remainder fix from RustPython/pymath#21 and remove the now-passing Windows testRemainder expecte...

X Description: Summary Follow up #9412, keeping C API, ctypes, PyO3, and CI changes out of scope. Adopt the merged remainder fix from RustPython/pymath#21 and remove the now-passing Windows testRemainder expecte...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9427

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8881e888-4b07-ead5-1507-02c1785e5063
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF5E:33444D:337F131:447A9EB:6B01F935
html-safe-nonced5c0cba84ac222ea7938e377e64a445c0edce89db4ec8ec2001e0948e7728290
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjVFOjMzNDQ0RDozMzdGMTMxOjQ0N0E5RUI6NkIwMUY5MzUiLCJ2aXNpdG9yX2lkIjoiNDE1NzA1MjY0MjMzNTUyMTA3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2f47862d23d43b4ca8d1f71de535473dfc9a141b331c0a0209f1a62e6c74d606
hovercard-subject-tagpull_request:5049940047
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9427/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altSummary Follow up #9412, keeping C API, ctypes, PyO3, and CI changes out of scope. Adopt the merged remainder fix from RustPython/pymath#21 and remove the now-passing Windows testRemainder expecte...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9427/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9427%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9427%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9427/files
Reloadhttps://github.com/RustPython/RustPython/pull/9427/files
Reloadhttps://github.com/RustPython/RustPython/pull/9427/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:windows-pymath-followupshttps://github.com/youknowone/RustPython/tree/windows-pymath-followups
Conversation 3 https://github.com/RustPython/RustPython/pull/9427
Commits 3 https://github.com/RustPython/RustPython/pull/9427/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9427/checks
Files changed https://github.com/RustPython/RustPython/pull/9427/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9427/files
Fix Windows/x86 deallocation and sequence compatibility https://github.com/RustPython/RustPython/pull/9427/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9427/files
ae4fcce Adopt pymath remainder fix on Windows youknowone Oct 28, 2026 https://github.com/RustPython/RustPython/pull/9427/commits/ae4fccef01399a0e7aa6c6798f800dcb145b6a4b
f306f4b Keep deferred object deallocation iterative youknowone Oct 28, 2026 https://github.com/RustPython/RustPython/pull/9427/commits/f306f4b6afbe5a6cda6d2425a84d7272c4cd448b
0c7fd74 Fix 32-bit sequence hashes, repetition errors, and range state youknowone Oct 28, 2026 https://github.com/RustPython/RustPython/pull/9427/commits/0c7fd7493cc07818f52a3a93af7f2e32000fe6ef
Clear filters https://github.com/RustPython/RustPython/pull/9427/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9427/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9427/files
Cargo.lock https://github.com/RustPython/RustPython/pull/9427/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
Cargo.toml https://github.com/RustPython/RustPython/pull/9427/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542
test_math.py https://github.com/RustPython/RustPython/pull/9427/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
hash.rs https://github.com/RustPython/RustPython/pull/9427/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
range.rs https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
core.rs https://github.com/RustPython/RustPython/pull/9427/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
vm_ops.rs https://github.com/RustPython/RustPython/pull/9427/files#diff-7f5fecda3e3100247b725e8eba74b99604553656485b9b160cddd0a863e77c1e
Cargo.lockhttps://github.com/RustPython/RustPython/pull/9427/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
View file https://github.com/youknowone/RustPython/blob/0c7fd7493cc07818f52a3a93af7f2e32000fe6ef/Cargo.lock
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9427/files
Cargo.tomlhttps://github.com/RustPython/RustPython/pull/9427/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542
View file https://github.com/youknowone/RustPython/blob/0c7fd7493cc07818f52a3a93af7f2e32000fe6ef/Cargo.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9427/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9427/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542
https://github.com/RustPython/RustPython/pull/9427/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542
Lib/test/test_math.pyhttps://github.com/RustPython/RustPython/pull/9427/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
View file https://github.com/youknowone/RustPython/blob/0c7fd7493cc07818f52a3a93af7f2e32000fe6ef/Lib/test/test_math.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9427/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9427/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
https://github.com/RustPython/RustPython/pull/9427/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
crates/common/src/hash.rshttps://github.com/RustPython/RustPython/pull/9427/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
View file https://github.com/youknowone/RustPython/blob/0c7fd7493cc07818f52a3a93af7f2e32000fe6ef/crates/common/src/hash.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9427/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9427/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
https://github.com/RustPython/RustPython/pull/9427/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
https://github.com/RustPython/RustPython/pull/9427/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
https://github.com/RustPython/RustPython/pull/9427/files#diff-9ddaf584e7e730457c197b1c6d291512c588c427349c61bccf5492443262fb7b
crates/vm/src/builtins/range.rshttps://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
View file https://github.com/youknowone/RustPython/blob/0c7fd7493cc07818f52a3a93af7f2e32000fe6ef/crates/vm/src/builtins/range.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9427/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
https://github.com/RustPython/RustPython/pull/9427/files#diff-e32048b785500abe1eb68be206fc16d74df32a06bd8179e5ea4756a00c7e79f9
crates/vm/src/object/core.rshttps://github.com/RustPython/RustPython/pull/9427/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
View file https://github.com/youknowone/RustPython/blob/0c7fd7493cc07818f52a3a93af7f2e32000fe6ef/crates/vm/src/object/core.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9427/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9427/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9427/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9427/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9427/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.