René's URL Explorer Experiment


Title: Collect cycles through sets, frozensets and set iterators by 1ndahous3 · Pull Request #9343 · RustPython/RustPython · GitHub

Open Graph Title: Collect cycles through sets, frozensets and set iterators by 1ndahous3 · Pull Request #9343 · RustPython/RustPython

X Title: Collect cycles through sets, frozensets and set iterators by 1ndahous3 · Pull Request #9343 · RustPython/RustPython

Description: Found while testing collection adapters for an embedding application: a native object holding a plain PyRef remained allocated when the set contained that object. Summary Break cycles through sets and frozensets by detaching keys before releasing their references; traverse frozenset members and the container owned by a set iterator. Preserve shared internal tables until they have an exclusive owner, avoiding duplicate accounting and clearing another owner's references. Release set tables directly during ordinary destruction, keeping deferred reference release for cyclic GC. Keep exact frozensets with acyclic contents outside GC, including native allocation paths. Subclasses and potentially cyclic contents remain tracked. Performance Three full collections release all 3,000 native/set cycles in the reproduction on both systems; previously none of the native payloads were released. Windows 11 x64 Operation main This patch Temporary set union (24 elements) 821 ns 816 ns Temporary frozenset union (24 elements) 827 ns 863 ns Frozenset union (256 integers) 3.05 µs 3.47 µs Full GC with 30,000 live singleton frozensets 2.50 ms 2.35 ms Debian 13 amd64 Operation main This patch Temporary set union (24 elements) 707 ns 731 ns Temporary frozenset union (24 elements) 720 ns 804 ns Frozenset union (256 integers) 2.84 µs 3.19 µs Full GC with 30,000 live singleton frozensets 2.35 ms 1.89 ms Checking frozenset eligibility adds a linear scan of the result's keys. The union measurements include destruction of the temporary result. AI assistance Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Bug Fixes Improved memory management for sets and frozen sets, including when their underlying data is shared. Updated object cleanup and cycle tracking to better account for values that can participate in reference cycles, helping ensure references are released safely. These changes may also reduce unnecessary garbage-collection tracking in cases where it is not needed.

Open Graph Description: Found while testing collection adapters for an embedding application: a native object holding a plain PyRef<PySet> remained allocated when the set contained that object. Summary Break cycles...

X Description: Found while testing collection adapters for an embedding application: a native object holding a plain PyRef&lt;PySet&gt; remained allocated when the set contained that object. Summary Brea...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9343

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:066d7d9d-4c4e-37dd-b3e5-d1a7814f2271
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD70:2C4BED:3A9C068:4A6E551:6B01FE67
html-safe-nonce629bd17fb42636e4e323547f8d366fd96c0c6dcee0ca53fa6033dde7a1becdc2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDcwOjJDNEJFRDozQTlDMDY4OjRBNkU1NTE6NkIwMUZFNjciLCJ2aXNpdG9yX2lkIjoiMzM2MTc1MTk2NjU2NTAwMzI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1e7efc34f6c382bb946e4927252cfc1ca3826f4ba8bdd542649f747a57e9e9ff
hovercard-subject-tagpull_request:4995276411
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9343/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altFound while testing collection adapters for an embedding application: a native object holding a plain PyRef<PySet> remained allocated when the set contained that object. Summary Break cycles...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9343/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9343%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9343%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9343/files
Reloadhttps://github.com/RustPython/RustPython/pull/9343/files
Reloadhttps://github.com/RustPython/RustPython/pull/9343/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:set_gc_clearhttps://github.com/1ndahous3/RustPython/tree/set_gc_clear
Conversation 6 https://github.com/RustPython/RustPython/pull/9343
Commits 1 https://github.com/RustPython/RustPython/pull/9343/commits
Checks 21 https://github.com/RustPython/RustPython/pull/9343/checks
Files changed https://github.com/RustPython/RustPython/pull/9343/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9343/files
Collect cycles through sets, frozensets and set iterators https://github.com/RustPython/RustPython/pull/9343/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9343/files
cbf92d3 Collect cycles through sets, frozensets and set iterators 1ndahous3 Oct 24, 2026 https://github.com/RustPython/RustPython/pull/9343/commits/cbf92d3163667655709b33772c9fce3b335fe639
Clear filters https://github.com/RustPython/RustPython/pull/9343/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9343/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9343/files
test_set.py https://github.com/RustPython/RustPython/pull/9343/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
set.rs https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
dict_inner.rs https://github.com/RustPython/RustPython/pull/9343/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
core.rs https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
payload.rs https://github.com/RustPython/RustPython/pull/9343/files#diff-810ea11cfb8461075d5d8f586b7bc9fb28d85695bdaf74cde28129c5e1e7e9a3
Lib/test/test_set.pyhttps://github.com/RustPython/RustPython/pull/9343/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
View file https://github.com/1ndahous3/RustPython/blob/cbf92d3163667655709b33772c9fce3b335fe639/Lib/test/test_set.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9343/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9343/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
https://github.com/RustPython/RustPython/pull/9343/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
crates/vm/src/builtins/set.rshttps://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
View file https://github.com/1ndahous3/RustPython/blob/cbf92d3163667655709b33772c9fce3b335fe639/crates/vm/src/builtins/set.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9343/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9343/files
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9343/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
crates/vm/src/dict_inner.rshttps://github.com/RustPython/RustPython/pull/9343/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
View file https://github.com/1ndahous3/RustPython/blob/cbf92d3163667655709b33772c9fce3b335fe639/crates/vm/src/dict_inner.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9343/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9343/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/9343/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
crates/vm/src/object/core.rshttps://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
View file https://github.com/1ndahous3/RustPython/blob/cbf92d3163667655709b33772c9fce3b335fe639/crates/vm/src/object/core.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9343/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9343/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
crates/vm/src/object/payload.rshttps://github.com/RustPython/RustPython/pull/9343/files#diff-810ea11cfb8461075d5d8f586b7bc9fb28d85695bdaf74cde28129c5e1e7e9a3
View file https://github.com/1ndahous3/RustPython/blob/cbf92d3163667655709b33772c9fce3b335fe639/crates/vm/src/object/payload.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9343/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9343/files#diff-810ea11cfb8461075d5d8f586b7bc9fb28d85695bdaf74cde28129c5e1e7e9a3
https://github.com/RustPython/RustPython/pull/9343/files#diff-810ea11cfb8461075d5d8f586b7bc9fb28d85695bdaf74cde28129c5e1e7e9a3
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9343/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.