René's URL Explorer Experiment


Title: Create C API worker VMs without attaching the template by youknowdot · Pull Request #9318 · RustPython/RustPython · GitHub

Open Graph Title: Create C API worker VMs without attaching the template by youknowdot · Pull Request #9318 · RustPython/RustPython

X Title: Create C API worker VMs without attaching the template by youknowdot · Pull Request #9318 · RustPython/RustPython

Description: Summary Create the C API worker VM through Interpreter::new_thread() instead of temporarily entering the template VM while holding MAIN_INTERP. The existing attachment path still attaches the returned worker after the factory returns and releases that mutex. On current main, both calls use the same interpreter receiver and clone implementation, preserving the worker's owned shared state. The old path can park during attachment while retaining MAIN_INTERP, including shutdown parking that can prevent later registration cleanup from acquiring the mutex. This is a source-supported possible interleaving, not a runtime-reproduced shutdown race. This change removes that attachment-under-mutex edge. It does not remove the existing trace/profile locks or establish general callback, admission, retirement, or finalization safety. Regression test and validation Add one native structural test using a fresh OS thread. Merely constructing a worker must leave both the VM stack and current thread slot empty. The parent detaches while joining, then drops the returned clone under its attached interpreter before assertions. No shutdown, stop-the-world, race, or callback probe is performed. On Linux x86_64: The identical test on the original factory failed exactly the final cached-slot assertion: (false, true) instead of (false, false). With this change, the exact test passed: 1 passed, 0 failed, 0 ignored, with 130 other tests filtered out. Built the lib-test using cargo test --locked --offline -j1 -p rustpython-capi --lib --no-run, from crates/capi, and executed only pylifecycle::tests::requesting_thread_vm_does_not_attach from separately preserved baseline/candidate executables. Neither links host libpython. cargo clippy --locked --offline -j1 -p rustpython-capi --lib --tests -- -D warnings passed, also from crates/capi. Normal commit hooks passed. The full C API suite was not run. The tested base is 0231d847d9da0eed90c3fe87010205683d52af56. Main subsequently advanced to f65bf8e52d0c0a387bca897614befa1aa4af9d69 with a Cargo.lock-only dependency update. Source-only merge composition is clean and preserves this exact C API file; that newer-main combination was not executed locally. Upgrade integration This deliberately extracts a current-main prerequisite overlapping #8944, rather than claiming independent ownership. The same caller replacement also appears in the broader GC redesign #8939. #8944 already has the same caller replacement, but its Interpreter::new_thread() enters through enter_raw. This test is an explicit integration gate: that owner branch must preserve the factory's no-attachment boundary even when the textual caller change merges cleanly. This PR does not use its restricted idle-anchor API, change its owner/admission design, or modify #8944. AI assistance was used in source review, implementation, and validation.

Open Graph Description: Summary Create the C API worker VM through Interpreter::new_thread() instead of temporarily entering the template VM while holding MAIN_INTERP. The existing attachment path still attaches the retur...

X Description: Summary Create the C API worker VM through Interpreter::new_thread() instead of temporarily entering the template VM while holding MAIN_INTERP. The existing attachment path still attaches the retur...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9318

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a648b8d4-9c62-968e-6256-3b6219b64215
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C9E:3E418A:147ABE2:1AF0AA4:6B01F3B7
html-safe-nonce0cc9d023deef77253498de6c0f66eb076accc7063e65c1b59be15c0ea8bda1ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzlFOjNFNDE4QToxNDdBQkUyOjFBRjBBQTQ6NkIwMUYzQjciLCJ2aXNpdG9yX2lkIjoiMzk0OTk4MTYyMTc3MTQzMjg4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5044630ae4a3e068717d0a09bd9e3dc96ada61f01cfa75e0c303aeba04559940
hovercard-subject-tagpull_request:4970984370
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9318/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Create the C API worker VM through Interpreter::new_thread() instead of temporarily entering the template VM while holding MAIN_INTERP. The existing attachment path still attaches the retur...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9318/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9318%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9318%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9318/files
Reloadhttps://github.com/RustPython/RustPython/pull/9318/files
Reloadhttps://github.com/RustPython/RustPython/pull/9318/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-capi-worker-factoryhttps://github.com/youknowdot/RustPython/tree/fix-capi-worker-factory
Conversation 2 https://github.com/RustPython/RustPython/pull/9318
Commits 1 https://github.com/RustPython/RustPython/pull/9318/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9318/checks
Files changed https://github.com/RustPython/RustPython/pull/9318/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9318/files
Create C API worker VMs without attaching the template https://github.com/RustPython/RustPython/pull/9318/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9318/files
adecad6 Avoid attaching C API worker templates under the interpreter lock codex Oct 22, 2026 https://github.com/RustPython/RustPython/pull/9318/commits/adecad63e363bdda41bbba2cbd609fdd650124dc
Clear filters https://github.com/RustPython/RustPython/pull/9318/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9318/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9318/files
crates/capi/src/pylifecycle.rshttps://github.com/RustPython/RustPython/pull/9318/files#diff-c498326566a6c12f9e3f63e6dacd72d09baf5335e74b2cd4da2f68324380fcb8
View file https://github.com/youknowdot/RustPython/blob/adecad63e363bdda41bbba2cbd609fdd650124dc/crates/capi/src/pylifecycle.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9318/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9318/files#diff-c498326566a6c12f9e3f63e6dacd72d09baf5335e74b2cd4da2f68324380fcb8
https://github.com/RustPython/RustPython/pull/9318/files#diff-c498326566a6c12f9e3f63e6dacd72d09baf5335e74b2cd4da2f68324380fcb8
https://github.com/RustPython/RustPython/pull/9318/files#diff-c498326566a6c12f9e3f63e6dacd72d09baf5335e74b2cd4da2f68324380fcb8
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9318/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.