Title: Create C API worker VMs without attaching the template by youknowdot · Pull Request #9318 · RustPython/RustPython · GitHub
Open Graph Title: Create C API worker VMs without attaching the template by youknowdot · Pull Request #9318 · RustPython/RustPython
X Title: Create C API worker VMs without attaching the template by youknowdot · Pull Request #9318 · RustPython/RustPython
Description: Summary Create the C API worker VM through Interpreter::new_thread() instead of temporarily entering the template VM while holding MAIN_INTERP. The existing attachment path still attaches the returned worker after the factory returns and releases that mutex. On current main, both calls use the same interpreter receiver and clone implementation, preserving the worker's owned shared state. The old path can park during attachment while retaining MAIN_INTERP, including shutdown parking that can prevent later registration cleanup from acquiring the mutex. This is a source-supported possible interleaving, not a runtime-reproduced shutdown race. This change removes that attachment-under-mutex edge. It does not remove the existing trace/profile locks or establish general callback, admission, retirement, or finalization safety. Regression test and validation Add one native structural test using a fresh OS thread. Merely constructing a worker must leave both the VM stack and current thread slot empty. The parent detaches while joining, then drops the returned clone under its attached interpreter before assertions. No shutdown, stop-the-world, race, or callback probe is performed. On Linux x86_64: The identical test on the original factory failed exactly the final cached-slot assertion: (false, true) instead of (false, false). With this change, the exact test passed: 1 passed, 0 failed, 0 ignored, with 130 other tests filtered out. Built the lib-test using cargo test --locked --offline -j1 -p rustpython-capi --lib --no-run, from crates/capi, and executed only pylifecycle::tests::requesting_thread_vm_does_not_attach from separately preserved baseline/candidate executables. Neither links host libpython. cargo clippy --locked --offline -j1 -p rustpython-capi --lib --tests -- -D warnings passed, also from crates/capi. Normal commit hooks passed. The full C API suite was not run. The tested base is 0231d847d9da0eed90c3fe87010205683d52af56. Main subsequently advanced to f65bf8e52d0c0a387bca897614befa1aa4af9d69 with a Cargo.lock-only dependency update. Source-only merge composition is clean and preserves this exact C API file; that newer-main combination was not executed locally. Upgrade integration This deliberately extracts a current-main prerequisite overlapping #8944, rather than claiming independent ownership. The same caller replacement also appears in the broader GC redesign #8939. #8944 already has the same caller replacement, but its Interpreter::new_thread() enters through enter_raw. This test is an explicit integration gate: that owner branch must preserve the factory's no-attachment boundary even when the textual caller change merges cleanly. This PR does not use its restricted idle-anchor API, change its owner/admission design, or modify #8944. AI assistance was used in source review, implementation, and validation.
Open Graph Description: Summary Create the C API worker VM through Interpreter::new_thread() instead of temporarily entering the template VM while holding MAIN_INTERP. The existing attachment path still attaches the retur...
X Description: Summary Create the C API worker VM through Interpreter::new_thread() instead of temporarily entering the template VM while holding MAIN_INTERP. The existing attachment path still attaches the retur...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9318
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a648b8d4-9c62-968e-6256-3b6219b64215 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C9E:3E418A:147ABE2:1AF0AA4:6B01F3B7 |
| html-safe-nonce | 0cc9d023deef77253498de6c0f66eb076accc7063e65c1b59be15c0ea8bda1ad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzlFOjNFNDE4QToxNDdBQkUyOjFBRjBBQTQ6NkIwMUYzQjciLCJ2aXNpdG9yX2lkIjoiMzk0OTk4MTYyMTc3MTQzMjg4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5044630ae4a3e068717d0a09bd9e3dc96ada61f01cfa75e0c303aeba04559940 |
| hovercard-subject-tag | pull_request:4970984370 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9318/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Create the C API worker VM through Interpreter::new_thread() instead of temporarily entering the template VM while holding MAIN_INTERP. The existing attachment path still attaches the retur... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width