Title: Complete PyTime conversion fixtures and repair existing helpers by youknowdot · Pull Request #9317 · RustPython/RustPython · GitHub
Open Graph Title: Complete PyTime conversion fixtures and repair existing helpers by youknowdot · Pull Request #9317 · RustPython/RustPython
X Title: Complete PyTime conversion fixtures and repair existing helpers by youknowdot · Pull Request #9317 · RustPython/RustPython
Description: Summary Complete the coherent 11-helper PyTime conversion family in _testinternalcapi: Repair the three existing helpers: _PyTime_AsTimeval_clamp, _PyTime_AsTimespec, and _PyTime_AsTimespec_clamp. Honor all four rounding modes, negative values, ties-to-even, carries, native bounds, and CPython wrapper argument validation/precedence. Derive SIZEOF_TIME_T from the host type. Add the eight real conversion fixtures needed by the canonical PyTime tests: _PyTime_FromSeconds, _PyTime_FromSecondsObject, _PyTime_AsTimeval, _PyTime_AsMilliseconds, _PyTime_AsMicroseconds, _PyTime_ObjectToTime_t, _PyTime_ObjectToTimeval, and _PyTime_ObjectToTimespec. Keep the consumed numeric conversions in a private helper module. Windows timeval seconds use C long independently of 64-bit time_t; clamping clears the subsecond field. This intentionally extracts the PyTime fixture/API prerequisite from the broader work in #9143 and #8954. The original three-helper repair and the additional eight fixtures are kept together in this PR rather than publishing a duplicate dependent PR. When #9143 is rebased, preserve or reuse these contracts instead of replacing them with less strict wrappers. No _testcapi namespace, unused shared exports, time.sleep refactor, lifecycle changes, or Lib edits are introduced. These are Python-facing fixture implementations, not a claim of C-ABI coverage. Validation Pinned reference: CPython 3.15.0 final, d220409a13b77de7a6c30abe16ea90db01528edc. Oracle interpreter, libpython and _testinternalcapi extension hashes are bound to the retained build/source provenance. Validated final commit: 29404850a370aad85467a782b65d7b44349a5f62. 2017/2017 fixed builtin-only observations for the eight added fixtures match CPython exactly, including typed results, exception types/messages, all rounding modes, signed ties/carries, integer boundaries, exact float inputs, arity/kwargs, invalid builtin modes/types, and conversion precedence. No unavailable helpers. 287/287 existing-helper regression observations match CPython. The original baseline had 99 differences (70 tuple values, 7 exception types, 22 messages); all remain resolved with no new differences. Normal repository commit hooks pass. CLI build with the root capi feature passes. Strict VM Clippy passes with default features and with threading (-D warnings). VM --no-default-features check passes, with 18 warnings in unchanged code; this is not a warning-free gate. The original baseline binary was main 0b0a3607 plus the AST-Single warning patch from #9303. Its entire _testinternalcapi.rs matched the PR's main 94f92e4a base, and the exec-mode integer matrix does not exercise that warning route. This is not a claim of exact-current-main baseline or fresh-main integration testing. Local runtime validation is Linux 64-bit. Integer 32-bit time_t probes and source-reviewed platform branches do not establish Windows/32-bit execution; float neighbors around ±2**31 are not covered. Custom conversion callbacks and subclasses are not exercised by these finite matrices. Canonical PyTime classes require _testcapi even for the internal helpers. Their guards are unchanged, and skipped classes are not counted as passing coverage. No callback, sleep, subprocess, or lifecycle tests are claimed. AI assistance was used in preparing this change and its validation. Summary by CodeRabbit Bug Fixes Time conversion test helpers now apply the requested rounding mode and report errors for invalid arguments, unsupported rounding values, and out-of-range inputs. Clamped conversions return the nearest supported time bound with a zero fractional component. Compatibility Time-size reporting and conversion limits now reflect platform-specific time types and bounds. Rebase validation (2026-10-24) Rebased onto main 1cd1b5d09f4853b2f13a5f3d5d6f856e901b671e as 4aee9e991297300a664593293d05bdb37316acdb. Both original commits are unchanged in git range-diff, and the full-index patch is byte-identical. No Lib, test, sleep, or lifecycle changes were added. Normal commit hooks, threaded VM cargo check, strict threaded VM Clippy (-D warnings), and the default-feature CLI build passed on the exact rebased tree. The 12 canonical numeric methods were selected with their existing imports and decorators: all 12 skipped; zero test bodies executed. This supplies compile/lint/build coverage, not numeric behavior validation. Earlier runtime observations above apply to the original commit, not a rerun on this rebased head. No full workspace, C-API, release, lifecycle, or cross-platform execution is claimed for this local rebase validation. Correctness CI run 40042903402 completed successfully on this exact rebased head: 25/25 jobs passed.
Open Graph Description: Summary Complete the coherent 11-helper PyTime conversion family in _testinternalcapi: Repair the three existing helpers: _PyTime_AsTimeval_clamp, _PyTime_AsTimespec, and _PyTime_AsTimespec_clamp....
X Description: Summary Complete the coherent 11-helper PyTime conversion family in _testinternalcapi: Repair the three existing helpers: _PyTime_AsTimeval_clamp, _PyTime_AsTimespec, and _PyTime_AsTimespec_clamp....
Opengraph URL: https://github.com/RustPython/RustPython/pull/9317
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7d752df5-e100-0995-5d0d-3431f510706a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AEC6:19B6A2:15D7F1C:1CE18DE:6B01FE87 |
| html-safe-nonce | b55d9cf50dfe0dab600fc3527701fe516ded22ce3451c920d68cf8d3a9b89050 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUM2OjE5QjZBMjoxNUQ3RjFDOjFDRTE4REU6NkIwMUZFODciLCJ2aXNpdG9yX2lkIjoiMzE3NzQ3NTc5ODc1MTkwMzM2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ac81624a61056c66c27a7d7d3e938396e6cc5fbaf57cde189ad86e0919f6320c |
| hovercard-subject-tag | pull_request:4969775462 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9317/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Complete the coherent 11-helper PyTime conversion family in _testinternalcapi: Repair the three existing helpers: _PyTime_AsTimeval_clamp, _PyTime_AsTimespec, and _PyTime_AsTimespec_clamp.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width