René's URL Explorer Experiment


Title: Complete PyTime conversion fixtures and repair existing helpers by youknowdot · Pull Request #9317 · RustPython/RustPython · GitHub

Open Graph Title: Complete PyTime conversion fixtures and repair existing helpers by youknowdot · Pull Request #9317 · RustPython/RustPython

X Title: Complete PyTime conversion fixtures and repair existing helpers by youknowdot · Pull Request #9317 · RustPython/RustPython

Description: Summary Complete the coherent 11-helper PyTime conversion family in _testinternalcapi: Repair the three existing helpers: _PyTime_AsTimeval_clamp, _PyTime_AsTimespec, and _PyTime_AsTimespec_clamp. Honor all four rounding modes, negative values, ties-to-even, carries, native bounds, and CPython wrapper argument validation/precedence. Derive SIZEOF_TIME_T from the host type. Add the eight real conversion fixtures needed by the canonical PyTime tests: _PyTime_FromSeconds, _PyTime_FromSecondsObject, _PyTime_AsTimeval, _PyTime_AsMilliseconds, _PyTime_AsMicroseconds, _PyTime_ObjectToTime_t, _PyTime_ObjectToTimeval, and _PyTime_ObjectToTimespec. Keep the consumed numeric conversions in a private helper module. Windows timeval seconds use C long independently of 64-bit time_t; clamping clears the subsecond field. This intentionally extracts the PyTime fixture/API prerequisite from the broader work in #9143 and #8954. The original three-helper repair and the additional eight fixtures are kept together in this PR rather than publishing a duplicate dependent PR. When #9143 is rebased, preserve or reuse these contracts instead of replacing them with less strict wrappers. No _testcapi namespace, unused shared exports, time.sleep refactor, lifecycle changes, or Lib edits are introduced. These are Python-facing fixture implementations, not a claim of C-ABI coverage. Validation Pinned reference: CPython 3.15.0 final, d220409a13b77de7a6c30abe16ea90db01528edc. Oracle interpreter, libpython and _testinternalcapi extension hashes are bound to the retained build/source provenance. Validated final commit: 29404850a370aad85467a782b65d7b44349a5f62. 2017/2017 fixed builtin-only observations for the eight added fixtures match CPython exactly, including typed results, exception types/messages, all rounding modes, signed ties/carries, integer boundaries, exact float inputs, arity/kwargs, invalid builtin modes/types, and conversion precedence. No unavailable helpers. 287/287 existing-helper regression observations match CPython. The original baseline had 99 differences (70 tuple values, 7 exception types, 22 messages); all remain resolved with no new differences. Normal repository commit hooks pass. CLI build with the root capi feature passes. Strict VM Clippy passes with default features and with threading (-D warnings). VM --no-default-features check passes, with 18 warnings in unchanged code; this is not a warning-free gate. The original baseline binary was main 0b0a3607 plus the AST-Single warning patch from #9303. Its entire _testinternalcapi.rs matched the PR's main 94f92e4a base, and the exec-mode integer matrix does not exercise that warning route. This is not a claim of exact-current-main baseline or fresh-main integration testing. Local runtime validation is Linux 64-bit. Integer 32-bit time_t probes and source-reviewed platform branches do not establish Windows/32-bit execution; float neighbors around ±2**31 are not covered. Custom conversion callbacks and subclasses are not exercised by these finite matrices. Canonical PyTime classes require _testcapi even for the internal helpers. Their guards are unchanged, and skipped classes are not counted as passing coverage. No callback, sleep, subprocess, or lifecycle tests are claimed. AI assistance was used in preparing this change and its validation. Summary by CodeRabbit Bug Fixes Time conversion test helpers now apply the requested rounding mode and report errors for invalid arguments, unsupported rounding values, and out-of-range inputs. Clamped conversions return the nearest supported time bound with a zero fractional component. Compatibility Time-size reporting and conversion limits now reflect platform-specific time types and bounds. Rebase validation (2026-10-24) Rebased onto main 1cd1b5d09f4853b2f13a5f3d5d6f856e901b671e as 4aee9e991297300a664593293d05bdb37316acdb. Both original commits are unchanged in git range-diff, and the full-index patch is byte-identical. No Lib, test, sleep, or lifecycle changes were added. Normal commit hooks, threaded VM cargo check, strict threaded VM Clippy (-D warnings), and the default-feature CLI build passed on the exact rebased tree. The 12 canonical numeric methods were selected with their existing imports and decorators: all 12 skipped; zero test bodies executed. This supplies compile/lint/build coverage, not numeric behavior validation. Earlier runtime observations above apply to the original commit, not a rerun on this rebased head. No full workspace, C-API, release, lifecycle, or cross-platform execution is claimed for this local rebase validation. Correctness CI run 40042903402 completed successfully on this exact rebased head: 25/25 jobs passed.

Open Graph Description: Summary Complete the coherent 11-helper PyTime conversion family in _testinternalcapi: Repair the three existing helpers: _PyTime_AsTimeval_clamp, _PyTime_AsTimespec, and _PyTime_AsTimespec_clamp....

X Description: Summary Complete the coherent 11-helper PyTime conversion family in _testinternalcapi: Repair the three existing helpers: _PyTime_AsTimeval_clamp, _PyTime_AsTimespec, and _PyTime_AsTimespec_clamp....

Opengraph URL: https://github.com/RustPython/RustPython/pull/9317

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7d752df5-e100-0995-5d0d-3431f510706a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEC6:19B6A2:15D7F1C:1CE18DE:6B01FE87
html-safe-nonceb55d9cf50dfe0dab600fc3527701fe516ded22ce3451c920d68cf8d3a9b89050
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUM2OjE5QjZBMjoxNUQ3RjFDOjFDRTE4REU6NkIwMUZFODciLCJ2aXNpdG9yX2lkIjoiMzE3NzQ3NTc5ODc1MTkwMzM2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacac81624a61056c66c27a7d7d3e938396e6cc5fbaf57cde189ad86e0919f6320c
hovercard-subject-tagpull_request:4969775462
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9317/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Complete the coherent 11-helper PyTime conversion family in _testinternalcapi: Repair the three existing helpers: _PyTime_AsTimeval_clamp, _PyTime_AsTimespec, and _PyTime_AsTimespec_clamp....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9317/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9317%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9317%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9317/files
Reloadhttps://github.com/RustPython/RustPython/pull/9317/files
Reloadhttps://github.com/RustPython/RustPython/pull/9317/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-existing-pytime-helpershttps://github.com/youknowdot/RustPython/tree/fix-existing-pytime-helpers
Conversation 3 https://github.com/RustPython/RustPython/pull/9317
Commits 2 https://github.com/RustPython/RustPython/pull/9317/commits
Checks 29 https://github.com/RustPython/RustPython/pull/9317/checks
Files changed https://github.com/RustPython/RustPython/pull/9317/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9317/files
Complete PyTime conversion fixtures and repair existing helpers https://github.com/RustPython/RustPython/pull/9317/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9317/files
9f5620d Fix rounding and bounds in existing PyTime test helpers youknowdot Oct 22, 2026 https://github.com/RustPython/RustPython/pull/9317/commits/9f5620d603ae27ee510ae45a693aa4b3977ce0b9
4aee9e9 Complete PyTime conversion fixtures in _testinternalcapi codex Oct 22, 2026 https://github.com/RustPython/RustPython/pull/9317/commits/4aee9e991297300a664593293d05bdb37316acdb
Clear filters https://github.com/RustPython/RustPython/pull/9317/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9317/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9317/files
_testinternalcapi.rs https://github.com/RustPython/RustPython/pull/9317/files#diff-696e7f5e9d8e7d68b319536976bd29f52b43c3e368850ce083ef75ae0bf9785b
pytime.rs https://github.com/RustPython/RustPython/pull/9317/files#diff-4b6b23ff2b2f51c7a5ab2e86051f5e7535ae5b34c2820e2c46e69c2d8f0dc30c
crates/vm/src/stdlib/_testinternalcapi.rshttps://github.com/RustPython/RustPython/pull/9317/files#diff-696e7f5e9d8e7d68b319536976bd29f52b43c3e368850ce083ef75ae0bf9785b
View file https://github.com/youknowdot/RustPython/blob/4aee9e991297300a664593293d05bdb37316acdb/crates/vm/src/stdlib/_testinternalcapi.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9317/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9317/files#diff-696e7f5e9d8e7d68b319536976bd29f52b43c3e368850ce083ef75ae0bf9785b
https://github.com/RustPython/RustPython/pull/9317/files#diff-696e7f5e9d8e7d68b319536976bd29f52b43c3e368850ce083ef75ae0bf9785b
https://github.com/RustPython/RustPython/pull/9317/files#diff-696e7f5e9d8e7d68b319536976bd29f52b43c3e368850ce083ef75ae0bf9785b
https://github.com/RustPython/RustPython/pull/9317/files#diff-696e7f5e9d8e7d68b319536976bd29f52b43c3e368850ce083ef75ae0bf9785b
https://github.com/RustPython/RustPython/pull/9317/files#diff-696e7f5e9d8e7d68b319536976bd29f52b43c3e368850ce083ef75ae0bf9785b
https://github.com/RustPython/RustPython/pull/9317/files#diff-696e7f5e9d8e7d68b319536976bd29f52b43c3e368850ce083ef75ae0bf9785b
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9317/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9317/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.