René's URL Explorer Experiment


Title: Fix interpolated string warning diagnostic locations by youknowdot · Pull Request #9314 · RustPython/RustPython · GitHub

Open Graph Title: Fix interpolated string warning diagnostic locations by youknowdot · Pull Request #9314 · RustPython/RustPython

X Title: Fix interpolated string warning diagnostic locations by youknowdot · Pull Request #9314 · RustPython/RustPython

Description: Summary Rebased #9314 onto main fd3c3fca644b93d0bec719efb3f864056b5d3b68 and reviewed its implementation against CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc. Reconstruct CPython decoder fragments, including named Unicode boundaries and the different doubled-brace rules for body versus format-spec constants. Keep source offsets for deduplication and Single-input boundaries, with separate END/MIDDLE token anchors for diagnostic locations and parser action ordering. Match the Unicode decoder's protection of non-ASCII characters after backslashes; independently collect tokenizer-owned brace warnings. Preserve parser/tokenizer phase order across nested f/t strings, format specs, numeric events, and warning escalation/recovery. Preserve pending Single and rejected-type-comment errors while allowing the appropriate tokenizer recovery events. TYPE_COMMENTS uses the shared warning collector instead of prematurely emitting format-spec callbacks. Match numeric zero-width error metadata and physical-line text, and ordinary Unicode-token final-line text and universal-newline positions, including exec bare CR. No canonical tests or Python library files were modified, no new RustPython behavior tests were added, and no diagnostic filtering or expected-output special cases were introduced. Validation The exact production source passed: Default-feature VM cargo check --offline --locked -p rustpython-vm --lib. Strict VM cargo clippy --offline --locked -p rustpython-vm --lib -- -D warnings. Default CLI cargo build --offline --locked --bin rustpython. 832 fixed compile-only observations against the pinned CPython oracle, with complete raw warnings and exception objects retained. Returned code objects/ASTs were not executed. Five unchanged canonical methods through normal unittest fixtures/decorators: f-string string-part backslashes, backslash-before-double-bracket, warns-once, raw t-strings, and triple-quoted t-strings. All passed with no skips or expected failures. An independent readonly candidate binary was sealed and its actual native and Python-module origins verified. Every gate checked source/tool/Lib bindings. Candidate source patch SHA256: 2a3f8ba850233eee80a0a2df4972363697d1707ae57e42a40d3cd4a1f958a7df (final follow-up delta against validated v8); binary SHA256: eb75c0a58986a48142d3ae7986823b89c520c6c8224da8ba925841cbb565b9a5. All 832 observations agree on warning lists and exception selection/chaining, including f/t body, format-spec, brace-tokenizer locations and the added numeric/ordinary-text corrections. The final follow-up corrected exactly four ordinary exec bare-CR rows; the other 828 rows were unchanged. Exact results and remaining boundaries Full raw equality is 382/832. A further 382 rows differ only in existing global SyntaxError args/repr construction. The remaining 68 rows retain other diagnostic differences: rejected TYPE_COMMENT validator ranges (40), Single generic-error LF text (18), the explicit malformed-source fallback control (10). These are recorded, not normalized away. General ordinary-string diagnostics outside the reviewed final-line scope are not claimed globally equivalent. Arbitrary custom warning-callback exception conversion, complete malformed-source parser recovery, global SyntaxError argument tuples, and real-file filename lookup are not rewritten or claimed fully equivalent. Full workspace/CAPI suites and entire Python test modules were not run in this bounded validation. AI assistance: OpenAI Codex (model version unavailable); commits contain Assisted-by trailers.

Open Graph Description: Summary Rebased #9314 onto main fd3c3fca644b93d0bec719efb3f864056b5d3b68 and reviewed its implementation against CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc. Reconstruct CPython...

X Description: Summary Rebased #9314 onto main fd3c3fca644b93d0bec719efb3f864056b5d3b68 and reviewed its implementation against CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc. Reconstruct CPython...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9314

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:019a620e-fe4c-77b1-cc9b-8f4c5224c995
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4D6:38EE04:154DD81:1C2E7EC:6B01FA69
html-safe-nonce3d942ff694c6858757783491ab0e02fc7146ebf7f88ba9a079f835ed01e46ad4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEQ2OjM4RUUwNDoxNTRERDgxOjFDMkU3RUM6NkIwMUZBNjkiLCJ2aXNpdG9yX2lkIjoiMTE4NjIyNDczMDA1OTk2Mjk4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd2fa1a0691a89c0ab00989e6e1b00d10c47ad281d254617299d97c23b16a37f2
hovercard-subject-tagpull_request:4968442440
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9314/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Rebased #9314 onto main fd3c3fca644b93d0bec719efb3f864056b5d3b68 and reviewed its implementation against CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc. Reconstruct CPython...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9314/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9314%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9314%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9314/files
Reloadhttps://github.com/RustPython/RustPython/pull/9314/files
Reloadhttps://github.com/RustPython/RustPython/pull/9314/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-interpolated-warning-locations-20261022https://github.com/youknowdot/RustPython/tree/fix-interpolated-warning-locations-20261022
Conversation 2 https://github.com/RustPython/RustPython/pull/9314
Commits 4 https://github.com/RustPython/RustPython/pull/9314/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9314/checks
Files changed https://github.com/RustPython/RustPython/pull/9314/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9314/files
Fix interpolated string warning diagnostic locations https://github.com/RustPython/RustPython/pull/9314/files#top
Show all changes 4 commits https://github.com/RustPython/RustPython/pull/9314/files
b6e12fc Use closing-token locations for interpolated body warnings youknowdot Oct 22, 2026 https://github.com/RustPython/RustPython/pull/9314/commits/b6e12fc7931ed34da23300ad82ddd3ed552fd454
0eaf7e8 Fix lint checks for interpolated warning diagnostics youknowdot Oct 22, 2026 https://github.com/RustPython/RustPython/pull/9314/commits/0eaf7e894b821d9d19951bd8458e1e5879bbdae6
0b79a45 Match CPython interpolated warning phases and fragment diagnostics youknowdot Oct 23, 2026 https://github.com/RustPython/RustPython/pull/9314/commits/0b79a45f2ac4ecfb24dc8c782df5b75fa3a22cea
d02a4f1 Use physical final-line locations for ordinary exec warnings youknowdot Oct 23, 2026 https://github.com/RustPython/RustPython/pull/9314/commits/d02a4f1e518a8eb731b787b5bff19c2867f95c26
Clear filters https://github.com/RustPython/RustPython/pull/9314/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9314/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9314/files
_ast.rs https://github.com/RustPython/RustPython/pull/9314/files#diff-abdef7b5c5b2a09ab3af5a77d683e79ae937bd93b5411799efd4101aacbc7411
string.rs https://github.com/RustPython/RustPython/pull/9314/files#diff-ac334d16ec968460271dd03617accda2cd6d71249e2c6c01ad642ce92bd33f80
compile.rs https://github.com/RustPython/RustPython/pull/9314/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
crates/vm/src/stdlib/_ast.rshttps://github.com/RustPython/RustPython/pull/9314/files#diff-abdef7b5c5b2a09ab3af5a77d683e79ae937bd93b5411799efd4101aacbc7411
View file https://github.com/youknowdot/RustPython/blob/d02a4f1e518a8eb731b787b5bff19c2867f95c26/crates/vm/src/stdlib/_ast.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9314/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9314/files#diff-abdef7b5c5b2a09ab3af5a77d683e79ae937bd93b5411799efd4101aacbc7411
https://github.com/RustPython/RustPython/pull/9314/files#diff-abdef7b5c5b2a09ab3af5a77d683e79ae937bd93b5411799efd4101aacbc7411
https://github.com/RustPython/RustPython/pull/9314/files#diff-abdef7b5c5b2a09ab3af5a77d683e79ae937bd93b5411799efd4101aacbc7411
https://github.com/RustPython/RustPython/pull/9314/files#diff-abdef7b5c5b2a09ab3af5a77d683e79ae937bd93b5411799efd4101aacbc7411
https://github.com/RustPython/RustPython/pull/9314/files#diff-abdef7b5c5b2a09ab3af5a77d683e79ae937bd93b5411799efd4101aacbc7411
crates/vm/src/stdlib/_ast/string.rshttps://github.com/RustPython/RustPython/pull/9314/files#diff-ac334d16ec968460271dd03617accda2cd6d71249e2c6c01ad642ce92bd33f80
View file https://github.com/youknowdot/RustPython/blob/d02a4f1e518a8eb731b787b5bff19c2867f95c26/crates/vm/src/stdlib/_ast/string.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9314/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9314/files#diff-ac334d16ec968460271dd03617accda2cd6d71249e2c6c01ad642ce92bd33f80
https://github.com/RustPython/RustPython/pull/9314/files#diff-ac334d16ec968460271dd03617accda2cd6d71249e2c6c01ad642ce92bd33f80
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9314/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9314/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.