Title: Fix interpolated string warning diagnostic locations by youknowdot · Pull Request #9314 · RustPython/RustPython · GitHub
Open Graph Title: Fix interpolated string warning diagnostic locations by youknowdot · Pull Request #9314 · RustPython/RustPython
X Title: Fix interpolated string warning diagnostic locations by youknowdot · Pull Request #9314 · RustPython/RustPython
Description: Summary Rebased #9314 onto main fd3c3fca644b93d0bec719efb3f864056b5d3b68 and reviewed its implementation against CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc. Reconstruct CPython decoder fragments, including named Unicode boundaries and the different doubled-brace rules for body versus format-spec constants. Keep source offsets for deduplication and Single-input boundaries, with separate END/MIDDLE token anchors for diagnostic locations and parser action ordering. Match the Unicode decoder's protection of non-ASCII characters after backslashes; independently collect tokenizer-owned brace warnings. Preserve parser/tokenizer phase order across nested f/t strings, format specs, numeric events, and warning escalation/recovery. Preserve pending Single and rejected-type-comment errors while allowing the appropriate tokenizer recovery events. TYPE_COMMENTS uses the shared warning collector instead of prematurely emitting format-spec callbacks. Match numeric zero-width error metadata and physical-line text, and ordinary Unicode-token final-line text and universal-newline positions, including exec bare CR. No canonical tests or Python library files were modified, no new RustPython behavior tests were added, and no diagnostic filtering or expected-output special cases were introduced. Validation The exact production source passed: Default-feature VM cargo check --offline --locked -p rustpython-vm --lib. Strict VM cargo clippy --offline --locked -p rustpython-vm --lib -- -D warnings. Default CLI cargo build --offline --locked --bin rustpython. 832 fixed compile-only observations against the pinned CPython oracle, with complete raw warnings and exception objects retained. Returned code objects/ASTs were not executed. Five unchanged canonical methods through normal unittest fixtures/decorators: f-string string-part backslashes, backslash-before-double-bracket, warns-once, raw t-strings, and triple-quoted t-strings. All passed with no skips or expected failures. An independent readonly candidate binary was sealed and its actual native and Python-module origins verified. Every gate checked source/tool/Lib bindings. Candidate source patch SHA256: 2a3f8ba850233eee80a0a2df4972363697d1707ae57e42a40d3cd4a1f958a7df (final follow-up delta against validated v8); binary SHA256: eb75c0a58986a48142d3ae7986823b89c520c6c8224da8ba925841cbb565b9a5. All 832 observations agree on warning lists and exception selection/chaining, including f/t body, format-spec, brace-tokenizer locations and the added numeric/ordinary-text corrections. The final follow-up corrected exactly four ordinary exec bare-CR rows; the other 828 rows were unchanged. Exact results and remaining boundaries Full raw equality is 382/832. A further 382 rows differ only in existing global SyntaxError args/repr construction. The remaining 68 rows retain other diagnostic differences: rejected TYPE_COMMENT validator ranges (40), Single generic-error LF text (18), the explicit malformed-source fallback control (10). These are recorded, not normalized away. General ordinary-string diagnostics outside the reviewed final-line scope are not claimed globally equivalent. Arbitrary custom warning-callback exception conversion, complete malformed-source parser recovery, global SyntaxError argument tuples, and real-file filename lookup are not rewritten or claimed fully equivalent. Full workspace/CAPI suites and entire Python test modules were not run in this bounded validation. AI assistance: OpenAI Codex (model version unavailable); commits contain Assisted-by trailers.
Open Graph Description: Summary Rebased #9314 onto main fd3c3fca644b93d0bec719efb3f864056b5d3b68 and reviewed its implementation against CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc. Reconstruct CPython...
X Description: Summary Rebased #9314 onto main fd3c3fca644b93d0bec719efb3f864056b5d3b68 and reviewed its implementation against CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc. Reconstruct CPython...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9314
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:019a620e-fe4c-77b1-cc9b-8f4c5224c995 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B4D6:38EE04:154DD81:1C2E7EC:6B01FA69 |
| html-safe-nonce | 3d942ff694c6858757783491ab0e02fc7146ebf7f88ba9a079f835ed01e46ad4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEQ2OjM4RUUwNDoxNTRERDgxOjFDMkU3RUM6NkIwMUZBNjkiLCJ2aXNpdG9yX2lkIjoiMTE4NjIyNDczMDA1OTk2Mjk4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d2fa1a0691a89c0ab00989e6e1b00d10c47ad281d254617299d97c23b16a37f2 |
| hovercard-subject-tag | pull_request:4968442440 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9314/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Rebased #9314 onto main fd3c3fca644b93d0bec719efb3f864056b5d3b68 and reviewed its implementation against CPython 3.15.0 source d220409a13b77de7a6c30abe16ea90db01528edc. Reconstruct CPython... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width