René's URL Explorer Experiment


Title: Fix numeric warning error start offsets by youknowdot · Pull Request #9305 · RustPython/RustPython · GitHub

Open Graph Title: Fix numeric warning error start offsets by youknowdot · Pull Request #9305 · RustPython/RustPython

X Title: Fix numeric warning error start offsets by youknowdot · Pull Request #9305 · RustPython/RustPython

Description: Follow-up to #9296, based independently on tested main 0b0a360. Use the existing numeric literal's last-character position when a parser-collected numeric SyntaxWarning becomes SyntaxError in noninteractive compilation. Interactive compilation already uses that position. For example, the offset for compile('0b1and 2', ..., 'exec') with SyntaxWarning configured as an error changes from 1 to 3, matching CPython 3.15.0. The same applies to AST compilation and Unicode character columns. This changes only the collector's offset argument. It does not change warning order or callback arguments, exception conversion/stringification, original-filename handling, or interactive behavior. It is not the broader numeric metadata patch prepared on #9282: end positions, error text/newline policy, lone-CR normalization and SyntaxError args remain outside this PR. The separate #9282 work is not included or superseded. Validation: Built default+capi with locked/offline dependencies and incremental compilation disabled; source-bound independent binary. Compared 18 fixed, compile-only cases with final CPython 3.15.0 (d220409a13b77de7a6c30abe16ea90db01528edc) and a historical #9296 binary whose compile.rs is byte-identical to the main base. That historical binary is not represented as a fresh main build. Cases cover ordinary/AST exec, eval and single modes, Unicode before the numeric literal, and LF/CRLF/lone-CR sources. Start positions now agree in 16/18 cases. Two lone-CR cases retain the pre-existing normalization gap. Every recorded baseline-to-candidate field was compared: only SyntaxError.offset changed in all 18 cases. Full metadata equality with CPython is not claimed; end/text/args differences remain. VM parser-disabled, nonthreading/threading and test-target checks passed; strict all-target threading Clippy passed. The first Clippy attempt was stopped by the disk-reserve guard; after reclaiming disposable build outputs, the unchanged candidate passed the same guarded command. Existing canonical test.test_grammar.TokenTests.test_end_of_numerical_literals passed: 1 test, no skips, expected failures or unexpected successes. This is regression coverage; it does not assert offsets. No Lib changes, expectedFailure removal or bespoke behavior tests. The canonical numeric warning method does not currently assert this offset; the finite observation matrix checks it directly without executing generated code. Full workspace/CAPI test suites were not run. AI assistance was used for implementation and validation.

Open Graph Description: Follow-up to #9296, based independently on tested main 0b0a360. Use the existing numeric literal's last-character position when a parser-collected numeric SyntaxWarning becomes SyntaxError in n...

X Description: Follow-up to #9296, based independently on tested main 0b0a360. Use the existing numeric literal's last-character position when a parser-collected numeric SyntaxWarning becomes SyntaxError ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9305

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aba2eb58-e9dc-f030-b1ad-233e4dc6668e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id851A:1AE20C:3CBE9F0:4CE746A:6B01FF21
html-safe-nonce74c30508c56ba09d2b9cc50169affa60a07b82d95a30112383c77c6291f5c5c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTFBOjFBRTIwQzozQ0JFOUYwOjRDRTc0NkE6NkIwMUZGMjEiLCJ2aXNpdG9yX2lkIjoiNTk0OTI2OTE3MTI3NDY0NTI4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac014ef6328bf318d6ccda1a6cd804e463088f5780641acbd70defa496fb0c4c31
hovercard-subject-tagpull_request:4967936891
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9305/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altFollow-up to #9296, based independently on tested main 0b0a360. Use the existing numeric literal's last-character position when a parser-collected numeric SyntaxWarning becomes SyntaxError in n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9305/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9305%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9305%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9305/files
Reloadhttps://github.com/RustPython/RustPython/pull/9305/files
Reloadhttps://github.com/RustPython/RustPython/pull/9305/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:split/numeric-warning-main-offset-20261022https://github.com/youknowdot/RustPython/tree/split/numeric-warning-main-offset-20261022
Conversation 2 https://github.com/RustPython/RustPython/pull/9305
Commits 1 https://github.com/RustPython/RustPython/pull/9305/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9305/checks
Files changed https://github.com/RustPython/RustPython/pull/9305/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9305/files
Fix numeric warning error start offsets https://github.com/RustPython/RustPython/pull/9305/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9305/files
1ba423d Use final numeric character for warning error offsets youknowdot Oct 22, 2026 https://github.com/RustPython/RustPython/pull/9305/commits/1ba423d0a9a7f095cefc7a40c4c0916fd02751c5
Clear filters https://github.com/RustPython/RustPython/pull/9305/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9305/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9305/files
crates/vm/src/vm/compile.rshttps://github.com/RustPython/RustPython/pull/9305/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
View file https://github.com/youknowdot/RustPython/blob/1ba423d0a9a7f095cefc7a40c4c0916fd02751c5/crates/vm/src/vm/compile.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9305/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9305/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
https://github.com/RustPython/RustPython/pull/9305/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9305/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.