Title: Preserve numeric warning error precedence in AST single mode by youknowdot · Pull Request #9303 · RustPython/RustPython · GitHub
Open Graph Title: Preserve numeric warning error precedence in AST single mode by youknowdot · Pull Request #9303 · RustPython/RustPython
X Title: Preserve numeric warning error precedence in AST single mode by youknowdot · Pull Request #9303 · RustPython/RustPython
Description: Summary Follow up #9296 by allowing numeric-warning recovery in compile(..., 'single', ast.PyCF_ONLY_AST). When a parser-origin escape warning becomes an error, CPython still scans for later numeric tokenizer warnings raised as errors. The ordinary compilation path already preserves that precedence, but the AST path only enabled it for file/eval input. Include Single in that existing allowlist. This also matters when the numeric warning is on a later logical line. The patch does not change normal warning-emission boundaries. In particular, the remaining cases that emit warnings from a second statement are separate work. Prompt-interactive input and FuncType retain their existing paths. Validation Compared against final CPython 3.15.0, pinned at d220409a13b77de7a6c30abe16ea90db01528edc, and the source-bound historical #9296 implementation at eb79fef279d646aedf5fca6598d330b54a401138. Candidate is based on main 0b0a3607648b5b01b3adfc1c06f3bec1d87f8a13; the historical baseline is not presented as current main. 32 fixed Single cases cover ordinary/AST compilation, always/error filters, one expression, semicolon-separated statements, later logical lines, compound suites and controls. Exactly four AST error-selection results change to the expected numeric error. Warning/error-selection agreement improves from 18/32 to 22/32. Full raw metadata equality remains 12/32 because existing numeric diagnostic metadata differences are deliberately retained. 16 parser-invalid/tokenizer-warning regression cases are unchanged from the historical baseline, including its existing CPython differences. The unchanged 24-case mixed warning-order corpus is unchanged from the historical baseline. Every observation only calls compile; returned code and AST objects are never executed. No custom warning callbacks were exercised. Four unchanged canonical test_compile.TestSpecifics methods passed: test_single_statement, test_bad_single_statement, test_compile_ast, and test_compile_warnings. Four tests ran with no skips, expected failures, unexpected successes, errors or failures. Native default+capi build and normal commit hooks passed. Parser-disabled, nonthreading and threading VM checks, test-target compilation, and strict all-target threading Clippy passed. No full Python test modules, Rust test execution, workspace/CAPI suites, Windows/macOS/WASM/Miri execution or performance benchmark was run for this patch. The scoped test-target gate compiles tests; it does not execute them. Limits Parser-invalid collection and tokenizer-origin f-string warning guards remain in place. AST emission does not itself gate on has_valid_syntax, so this is not a claim about every malformed-source case. Pre-parse safety paths were source-reviewed, not exercised with deep/hazardous inputs. Non-SyntaxWarning callback exceptions still return directly. A callback-raised SyntaxWarning or subclass qualifies for the same existing type-based recovery as a filter-escalated warning, so AST Single can now proceed to later numeric-warning handling in that case. Custom-callback parity with CPython is not established by these observations. This does not fix the ten observed statement-boundary cases, numeric offset/text metadata, exception args/repr, or the separate invalid-source recovery gaps. No Lib assertions or expected-failure markers were changed. AI assistance This change was prepared and validated with OpenAI Codex assistance.
Open Graph Description: Summary Follow up #9296 by allowing numeric-warning recovery in compile(..., 'single', ast.PyCF_ONLY_AST). When a parser-origin escape warning becomes an error, CPython still scans for late...
X Description: Summary Follow up #9296 by allowing numeric-warning recovery in compile(..., 'single', ast.PyCF_ONLY_AST). When a parser-origin escape warning becomes an error, CPython still scans ...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9303
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8e3c077f-eed1-85cf-e5dc-efd3e33dc711 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9732:1201C:382FAC3:4A8DB9A:6B020B14 |
| html-safe-nonce | 6e480a877ce82e841792ba31cf3d5b26f32d307d2423ee0e8557269955c4c633 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzMyOjEyMDFDOjM4MkZBQzM6NEE4REI5QTo2QjAyMEIxNCIsInZpc2l0b3JfaWQiOiIxODg3NjIyMTU1NDAzOTIyMTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0ed442fc028b5495bfe60bb4ecf401a37374b91c0580973be727e90caf3e53cc |
| hovercard-subject-tag | pull_request:4967399650 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9303/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Follow up #9296 by allowing numeric-warning recovery in compile(..., 'single', ast.PyCF_ONLY_AST). When a parser-origin escape warning becomes an error, CPython still scans for late... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width