Title: Support signed numeric constants in match pattern ASTs by youknowdot · Pull Request #9279 · RustPython/RustPython · GitHub
Open Graph Title: Support signed numeric constants in match pattern ASTs by youknowdot · Pull Request #9279 · RustPython/RustPython
X Title: Support signed numeric constants in match pattern ASTs by youknowdot · Pull Request #9279 · RustPython/RustPython
Description: Summary Split the signed numeric pattern closure from #8954 onto validated base cf56c1fa09654507939aac5f47be5e5692e1dce0. Validate numeric ast.Constant operands using their existing canonical representation, while retaining parser-produced numeric literal handling. Accept and fold UAdd as well as USub for numeric match values and mapping keys, including signed real parts of complex literals. Keep booleans and nonnumeric values excluded from numeric operands. The representation adaptation matters: Python AST conversion now produces Expr::Constant, while the old signed-number validator accepted only Expr::NumberLiteral. Merely copying the mega's unary-plus hunks still rejects valid manual ASTs, including unary minus. No Lib changes, parser pin changes, new Rust tests of Python behavior, or duplicated snippets. No Ruff #7 or #9074 overlap. Redundant lazy-future and type-alias changes from the mega are deliberately excluded because current main already supplies those behaviors. Validation External bounded differential observations: 24 valid manual-AST patterns (unary plus/minus on integers, floats and complex constants; signed-real complex expressions; match values and mapping keys), each checked for matching/nonmatching behavior. Baseline rejects all24; revised candidate matches CPython for all24. The minimal mega changes alone still reject all24, confirming the representation adaptation is required. Three existing canonical selectors passed independently on baseline, candidate and CPython: two AST folding controls and one lazy-future compatibility control. Nine runs, zero skips. Selected methods match canonical CPython source. Eleven bounded ordinary-source compile/parse observations remain identical to baseline and CPython; these are controls, not new fixes. Fresh source-bound CLI build and strict codegen/VM all-target Clippy passed. Workspace test compilation (--no-run, excluding wasm/venvlauncher/CAPI) and separate CAPI test compilation passed. These are compile-only checks, not full runtime-suite results. Configured pre-commit hooks passed, including the normal commit hook; no bypasses. Reference CPython 3.15.0 source pin d220409a13b77de7a6c30abe16ea90db01528edc: numeric/signed validation and match-pattern folding. AI-assisted implementation and validation with OpenAI Codex; exact model version unavailable. No merge requested. Performance follow-up The exact-head hosted checks completed with 17 successes, three conditional skips and one unresolved CodSpeed failure. CodSpeed actually measured comprehension_list.py: 804.5 → 913.4 µs (−11.93% efficiency), comparing main 2be9389 against tested merge 8c91234; baseline and head environment signatures, runner and kernel versions matched. A separately reviewed, fixed native experiment used that exact source pair and the unchanged benchmark: 12 ABBA blocks, 48 fresh processes, one selector and all observations retained. Candidate time changed −0.087%, with a descriptive 95% block-bootstrap interval of −3.666% to +3.856%. Same-binary variability was substantial. This local native result does not establish equivalence, reproduce CodSpeed simulation or explain its failure; the host and embedded build metadata differ from CI. Static hot-path inspection found equal selected instruction shapes but different layouts, not proof of causation. The quiet intervals were coordinated through explicit heavy-work release, but the process guard was PID-namespace-local and could not verify absence of contention from other executions or the host. The first excluded smoke stopped on a compatibility-URI validation mismatch. A source-reviewed schema correction preceded a new attempt with the unchanged schedule; neither smoke attempt entered the estimate. No hosted benchmark rerun, performance dismissal, simulation setup or security-setting change was performed. The failed CodSpeed check remains visible.
Open Graph Description: Summary Split the signed numeric pattern closure from #8954 onto validated base cf56c1fa09654507939aac5f47be5e5692e1dce0. Validate numeric ast.Constant operands using their existing canonical repr...
X Description: Summary Split the signed numeric pattern closure from #8954 onto validated base cf56c1fa09654507939aac5f47be5e5692e1dce0. Validate numeric ast.Constant operands using their existing canonical repr...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9279
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bba0afa9-214c-b561-3acc-7b6f570b92fd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 90AA:17FB7:2D347CF:39695E1:6B01ECBA |
| html-safe-nonce | 63396e756b9a693b9f792e429131377664ad2ffa6ee9fc061063065a5125662c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEFBOjE3RkI3OjJEMzQ3Q0Y6Mzk2OTVFMTo2QjAxRUNCQSIsInZpc2l0b3JfaWQiOiI0MzgyODEyNDQ4NTgzOTY5OTc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | defaa70ef2f41e05a9fdc689758988a1bb4aea6e4c4160e180fd2e1719fd0855 |
| hovercard-subject-tag | pull_request:4954917787 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9279/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Split the signed numeric pattern closure from #8954 onto validated base cf56c1fa09654507939aac5f47be5e5692e1dce0. Validate numeric ast.Constant operands using their existing canonical repr... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width