Title: Keep the mutex handoff test waiter locked until observation by youknowone · Pull Request #9273 · RustPython/RustPython · GitHub
Open Graph Title: Keep the mutex handoff test waiter locked until observation by youknowone · Pull Request #9273 · RustPython/RustPython
X Title: Keep the mutex handoff test waiter locked until observation by youknowone · Pull Request #9273 · RustPython/RustPython
Description: Summary Keep the existing native unlock_hands_off_to_starved_waiter test's waiter holding its mutex until the parent has sampled the immediate fast-acquire attempt. Previously, the waiter could acquire and unlock before that assertion, allowing a correct handoff to look like failure. The parent still attempts lock_fast immediately after unlock, without waiting for a waiter-acquired acknowledgement. It then releases any accidentally acquired lock, drops the owned release channel, joins the waiter, and asserts the captured result. This preserves the existing observation while avoiding a failure assertion that strands the waiter. This is a separate, main-based CI repair discovered while validating the Python 3.15 AST extraction in #9272. Only the existing Rust test changes. There are no production locking changes, Python-behavior Rust tests, new snippets, library changes, skips, increased sleeps, or weakened assertions. Validation Guarded Linux cargo test --locked --offline -p rustpython-vm --features threading --lib --no-run passed. The exact existing test passed in three separate processes, each with a 30-second external deadline: one passed, none ignored, 0.02 seconds per run. This was a fixed small check, not stress testing or rerun-until-green. Strict affected-package all-target Clippy and applicable configured hooks passed. Builds used one Cargo job, disabled incremental compilation, a six-GiB per-process address-space limit, disabled core dumps, resource reserves, and external timeouts. Existing dependency caches were reused. Limits The inherited test failed at its fast-acquire assertion in #9272's Linux job; its source is unchanged from that PR's base. The source demonstrates the early-unlock ordering flaw, but these checks do not prove that interleaving caused the hosted failure or eliminate all possible flakiness. The existing HAS_PARKED flag precedes parking-lot queue insertion, so the unchanged 20 ms setup delay is still a scheduling assumption. This is not exhaustive fairness proof. Channel drop releases the waiter on parent unwind, but does not provide universal cleanup for panics while a mutex is held or broken mutex implementations. No full native suite or cross-platform local run is claimed. AI assistance Codex assisted with source review, the minimal test repair, bounded validation, and PR preparation for the maintainer-directed Python 3.15 upgrade. The model version was not exposed. No claim of manual human testing is made.
Open Graph Description: Summary Keep the existing native unlock_hands_off_to_starved_waiter test's waiter holding its mutex until the parent has sampled the immediate fast-acquire attempt. Previously, the waiter could...
X Description: Summary Keep the existing native unlock_hands_off_to_starved_waiter test's waiter holding its mutex until the parent has sampled the immediate fast-acquire attempt. Previously, the waiter c...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9273
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:478f18f8-4c4b-1727-0f2c-4e962750158e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CAB2:2E5652:355D7C8:44059C6:6B01E6D1 |
| html-safe-nonce | ba1dfbe5ea0b2b74b1f3936f8b4e89597880b7fff162cf1dae400b2725a35fe3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUIyOjJFNTY1MjozNTVEN0M4OjQ0MDU5QzY6NkIwMUU2RDEiLCJ2aXNpdG9yX2lkIjoiOTExNDc3MzE4OTI3NTI4MTEwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a0ffbb64a78acba1936c4ee3f8d2f935a1370c4da906374263b4b9b2356e1815 |
| hovercard-subject-tag | pull_request:4952232567 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9273/files |
| twitter:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| og:image:alt | Summary Keep the existing native unlock_hands_off_to_starved_waiter test's waiter holding its mutex until the parent has sampled the immediate fast-acquire attempt. Previously, the waiter could... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width