René's URL Explorer Experiment


Title: Fix ctypes assignment conversion and backing-buffer retention by 1ndahous3 · Pull Request #9251 · RustPython/RustPython · GitHub

Open Graph Title: Fix ctypes assignment conversion and backing-buffer retention by 1ndahous3 · Pull Request #9251 · RustPython/RustPython

X Title: Fix ctypes assignment conversion and backing-buffer retention by 1ndahous3 · Pull Request #9251 · RustPython/RustPython

Description: Follow-up to #9229 and its private-holder review. Summary Share typed conversion across array, pointer and field assignments: fix float-pointer writes and integer wrapping, reject incompatible ctypes values, and propagate conversion errors before changing storage. Return writable typed views for scalar-subclass fields and the retained Python object for py_object fields. Flatten and deduplicate private backing-buffer references to prevent nested holder growth on repeated self-copy. Preserve existing string owners when assigning raw addresses. Keep tuple-created temporary objects alive until bytes and owners are installed, so finalizers observe the new value and can safely reenter assignment. Avoid temporary byte-buffer allocation for integer assignments. Keep scalar assignment converters fixed at type initialization so later _type_ changes cannot alter the write width or reinterpret values. Preserve full-width Windows X address and null assignments. Performance Median ns/operation, release builds. Windows 11 x64 Operation Before, ns After, ns Before / after Unchanged string-structure self-copy 2,054 1,007 2.04× Structure assignment to an array 1,624 613 2.65× Integer array write 477 375 1.27× Integer pointer write 639 378 1.69× Integer structure-field write 535 425 1.26× Debian 13 amd64 Operation Before, ns After, ns Before / after Unchanged string-structure self-copy 1,952 900 2.17× Structure assignment to an array 1,539 567 2.71× Integer array write 404 326 1.24× Integer pointer write 554 325 1.70× Integer structure-field write 464 359 1.29× Known limitations Root-wide ownership snapshots still duplicate owner IDs across copied slots; narrowing them by field path would lose raw aliases. Native BSTR string allocation and ownership remain incomplete. AI assistance Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Bug Fixes Improved ctypes assignments for arrays, pointers, structures, scalar values, characters, floating-point values, integers, and Python objects. Added more consistent type conversion, byte-order handling, and validation for incompatible values. Preserved referenced buffers and temporary objects correctly, reducing unexpected invalid or dangling pointer views. Improved handling of null pointers, pointer-backed values, repeated self-copy assignments, and pointer-sized storage. Conversion errors now propagate reliably without corrupting existing record bytes. Tests Added regression coverage for conversions, error handling, object lifetime, pointer buffers, and temporary values.

Open Graph Description: Follow-up to #9229 and its private-holder review. Summary Share typed conversion across array, pointer and field assignments: fix float-pointer writes and integer wrapping, reject incompatible cty...

X Description: Follow-up to #9229 and its private-holder review. Summary Share typed conversion across array, pointer and field assignments: fix float-pointer writes and integer wrapping, reject incompatible cty...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9251

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:00f3670c-2d12-76bc-b3f9-8288f0bed9f5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB79C:3D97C8:3145B33:4197EBF:6B01E95A
html-safe-nonce0905eef022c83137d2f13918b9c8b455c1553963656bcde2556d32ce1fc5ac61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzlDOjNEOTdDODozMTQ1QjMzOjQxOTdFQkY6NkIwMUU5NUEiLCJ2aXNpdG9yX2lkIjoiNDc2NzQ0Mjk0OTA4MjU3MzE0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacab3dfecdfc148a0acd9af4fb302cd6e4f3cb501cfc8ef89d131d8c1010824af1
hovercard-subject-tagpull_request:4937254494
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9251/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altFollow-up to #9229 and its private-holder review. Summary Share typed conversion across array, pointer and field assignments: fix float-pointer writes and integer wrapping, reject incompatible cty...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9251/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9251%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9251%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9251/files
Reloadhttps://github.com/RustPython/RustPython/pull/9251/files
Reloadhttps://github.com/RustPython/RustPython/pull/9251/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:ctypes_value_ownershiphttps://github.com/1ndahous3/RustPython/tree/ctypes_value_ownership
Conversation 21 https://github.com/RustPython/RustPython/pull/9251
Commits 3 https://github.com/RustPython/RustPython/pull/9251/commits
Checks 29 https://github.com/RustPython/RustPython/pull/9251/checks
Files changed https://github.com/RustPython/RustPython/pull/9251/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9251/files
Fix ctypes assignment conversion and backing-buffer retention https://github.com/RustPython/RustPython/pull/9251/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9251/files
eb6ff46 Fix ctypes assignment conversion and backing-buffer retention 1ndahous3 Oct 20, 2026 https://github.com/RustPython/RustPython/pull/9251/commits/eb6ff46dfffba04e62448aceedfb752934c345bc
e9178dd Preserve ctypes assignment metadata and pointer-width writes 1ndahous3 Oct 20, 2026 https://github.com/RustPython/RustPython/pull/9251/commits/e9178dd45657f030cb9f1dc5194a7823bdb7c70e
8850198 Enable passing Windows console tests 1ndahous3 Oct 20, 2026 https://github.com/RustPython/RustPython/pull/9251/commits/885019881985bbda9a9dbc670d8df21d7fc4b10b
Clear filters https://github.com/RustPython/RustPython/pull/9251/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9251/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9251/files
test_windows_console.py https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
ctypes.rs https://github.com/RustPython/RustPython/pull/9251/files#diff-0c472fcbece94f09d8398d170b05bde9f0b147557347c454000d0a7252190fc8
array.rs https://github.com/RustPython/RustPython/pull/9251/files#diff-1e6ef8a4a7706885a4b2f08152c3a0298bf0db75e092d52708b08caa6726d321
base.rs https://github.com/RustPython/RustPython/pull/9251/files#diff-16c64cd355bd8034d61677ad8e407239d548e0e35c48ee05e951e03e93aa1781
pointer.rs https://github.com/RustPython/RustPython/pull/9251/files#diff-31a7efabe21a7be0f4dcee8c644af456ac58989d1c551faf515841b41e652a66
simple.rs https://github.com/RustPython/RustPython/pull/9251/files#diff-640c11bed665f401309f30eaa8f59ef7ca4c930c57bc97dbf036e19030e1e64a
stdlib_ctypes.py https://github.com/RustPython/RustPython/pull/9251/files#diff-7cfa080a4c0c0eac19bf2bd0eea152938488bab4c8a8d1b1d7bbc14bce41a61c
Lib/test/test_pyrepl/test_windows_console.pyhttps://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
View file https://github.com/1ndahous3/RustPython/blob/885019881985bbda9a9dbc670d8df21d7fc4b10b/Lib/test/test_pyrepl/test_windows_console.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9251/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
https://github.com/RustPython/RustPython/pull/9251/files#diff-86926a3f1ab6405b57d06094351c6625a4ebb9260d23ae7b3fb82b5ba0099873
crates/host_env/src/ctypes.rshttps://github.com/RustPython/RustPython/pull/9251/files#diff-0c472fcbece94f09d8398d170b05bde9f0b147557347c454000d0a7252190fc8
View file https://github.com/1ndahous3/RustPython/blob/885019881985bbda9a9dbc670d8df21d7fc4b10b/crates/host_env/src/ctypes.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9251/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9251/files#diff-0c472fcbece94f09d8398d170b05bde9f0b147557347c454000d0a7252190fc8
https://github.com/RustPython/RustPython/pull/9251/files#diff-0c472fcbece94f09d8398d170b05bde9f0b147557347c454000d0a7252190fc8
https://github.com/RustPython/RustPython/pull/9251/files#diff-0c472fcbece94f09d8398d170b05bde9f0b147557347c454000d0a7252190fc8
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9251/files
https://github.com/RustPython/RustPython/pull/9251/files#diff-0c472fcbece94f09d8398d170b05bde9f0b147557347c454000d0a7252190fc8
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9251/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9251/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.