René's URL Explorer Experiment


Title: Reject surplus positional arguments before converting any by jseop-lim · Pull Request #9242 · RustPython/RustPython · GitHub

Open Graph Title: Reject surplus positional arguments before converting any by jseop-lim · Pull Request #9242 · RustPython/RustPython

X Title: Reject surplus positional arguments before converting any by jseop-lim · Pull Request #9242 · RustPython/RustPython

Description: Summary FuncArgs::bind_for rejects leftover positional arguments only after from_args has converted every parameter. A conversion can run user code (__iter__ for PyIter, __index__ for ArgIndex), so a call with too many arguments raises whatever that code raises. CPython checks the count first, in filter_vectorcall and in cfunction_vectorcall_O for hex() and friends. #8957 made the same change for keywords. AS-IS >>> class FailingIter: ... def __iter__(self): raise RuntimeError ... >>> class FailingIndex: ... def __index__(self): raise RuntimeError ... >>> filter(None, FailingIter(), 0) RuntimeError >>> hex(FailingIndex(), 1) RuntimeError TO-BE >>> filter(None, FailingIter(), 0) TypeError: filter expected 2 arguments, got 3 >>> hex(FailingIndex(), 1) TypeError: hex expected 1 argument, got 2 (matching CPython's exception type; the filter message is identical, the hex one keeps RustPython's shared wording) Changes Check the positional count against FromArgs::arity() in bind_for before from_args runs. Make the default arity() unbounded, since a hand-written impl such as ObjectArgs or ReplaceChanges may take any number of positional arguments itself. Give KwArgs, (), DirFd, OpenDirFd and csv's FormatOptions the bound they actually take, so their existing messages keep a finite count. Add each flattened field's upper bound in the derived arity(), and sum tuple bounds with saturating_add. As a side effect, a too-few message for a signature with *args now says expected at least 1 argument instead of expected 1 argument (for example struct.pack() and int.__new__()). Both are still TypeError. Add a case to extra_tests/snippets/vm_argument_errors.py. Test plan Built and run on macOS aarch64 against upstream/main 398dd70, using the CI feature set --no-default-features --features stdlib,importlib,stdio,encodings,sqlite,ssl-rustls-aws-lc,host_env,doc,ucd_3_2_0, plus threading, compared with CPython 3.14.4. A 69-call probe of builtins, itertools, operator, functools, math and constructors with too many, too few and valid arguments: the patch changes exactly 10 results, all from RuntimeError to TypeError (filter twice, enumerate with 3 arguments, hex, oct, bin, chr, itertools.compress, pairwise and takewhile). The other 59 are unchanged. rustpython -m test -j 6 --timeout 600 on the unpatched and patched builds: 45,717 run on both, and the same 3 modules fail on both (test_cmd_line, test_dict, test_frame). pytest -k rustpython in extra_tests: 246 pass on the patched build. On the unpatched build the only failure is the new vm_argument_errors.py case, which also passes under CPython 3.14.4. cargo test -p rustpython-vm -p rustpython-derive-impl --lib: 128 pass. cargo fmt --check clean, cargo clippy -p rustpython-vm -p rustpython-stdlib -p rustpython-derive-impl --all-targets reports nothing, and pre-commit run --files passes on the changed files. I used Claude Code (claude-opus-5-5) to draft the analysis, the patch and this description; I reviewed the change and ran every command above myself. Summary by CodeRabbit Bug Fixes Excess positional arguments are now rejected before argument conversion, providing more consistent errors and preventing unnecessary conversion attempts. Argument counts are reported accurately for flattened and combined arguments, including when counts are very large. Directory-related options continue to support keyword-only arguments while correctly reporting that they accept no positional arguments. Compatibility CSV formatting options now correctly accept zero or one positional argument.

Open Graph Description: Summary FuncArgs::bind_for rejects leftover positional arguments only after from_args has converted every parameter. A conversion can run user code (__iter__ for PyIter, __index__ for ArgIndex), so...

X Description: Summary FuncArgs::bind_for rejects leftover positional arguments only after from_args has converted every parameter. A conversion can run user code (__iter__ for PyIter, __index__ for ArgIndex), so...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9242

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:22d2292e-9898-e7df-46d0-e58472d60fa9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEACE:19AA62:3A3C768:49EB285:6B01FACD
html-safe-nonce692d76c19ff3b899e6865f5e9bbf9ed13d5d19c0bce38c3daa2ce84d2611d395
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUNFOjE5QUE2MjozQTNDNzY4OjQ5RUIyODU6NkIwMUZBQ0QiLCJ2aXNpdG9yX2lkIjoiNzQ1MzE0NDMzMzUxNzE5MTg4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6e2395cbd4345bc9681a15239c2ce8697ec4e497f4eee3b2ee893f9bc11c1980
hovercard-subject-tagpull_request:4932619823
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9242/files
twitter:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
og:image:altSummary FuncArgs::bind_for rejects leftover positional arguments only after from_args has converted every parameter. A conversion can run user code (__iter__ for PyIter, __index__ for ArgIndex), so...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9242/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9242%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9242%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9242/files
Reloadhttps://github.com/RustPython/RustPython/pull/9242/files
Reloadhttps://github.com/RustPython/RustPython/pull/9242/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jseop-lim:positional-arity-firsthttps://github.com/jseop-lim/RustPython/tree/positional-arity-first
Conversation 5 https://github.com/RustPython/RustPython/pull/9242
Commits 2 https://github.com/RustPython/RustPython/pull/9242/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9242/checks
Files changed https://github.com/RustPython/RustPython/pull/9242/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9242/files
Reject surplus positional arguments before converting any https://github.com/RustPython/RustPython/pull/9242/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9242/files
a61c2a9 Count positional arguments before converting any jseop-lim Oct 20, 2026 https://github.com/RustPython/RustPython/pull/9242/commits/a61c2a96f4bb7ffb2c3d042f0f8f6bfee9d7a158
ad79873 Note why arity upper bounds saturate youknowone Oct 22, 2026 https://github.com/RustPython/RustPython/pull/9242/commits/ad79873a2e86051d854118bae7cbfbf9439a7942
Clear filters https://github.com/RustPython/RustPython/pull/9242/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9242/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9242/files
from_args.rs https://github.com/RustPython/RustPython/pull/9242/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
csv.rs https://github.com/RustPython/RustPython/pull/9242/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
argument.rs https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
os.rs https://github.com/RustPython/RustPython/pull/9242/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
vm_argument_errors.py https://github.com/RustPython/RustPython/pull/9242/files#diff-3febfaa9a2cc7b3290172a8395d4c2e7ba34040c336993eb00683537156ac017
crates/derive-impl/src/from_args.rshttps://github.com/RustPython/RustPython/pull/9242/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
View file https://github.com/jseop-lim/RustPython/blob/ad79873a2e86051d854118bae7cbfbf9439a7942/crates/derive-impl/src/from_args.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9242/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9242/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
https://github.com/RustPython/RustPython/pull/9242/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
youknowonehttps://github.com/youknowone
Oct 20, 2026https://github.com/RustPython/RustPython/pull/9242/files#r4324248793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9242/files
jseop-limhttps://github.com/jseop-lim
Oct 20, 2026https://github.com/RustPython/RustPython/pull/9242/files#r4325890143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9242/files
https://github.com/RustPython/RustPython/pull/9242/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
crates/stdlib/src/csv.rshttps://github.com/RustPython/RustPython/pull/9242/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
View file https://github.com/jseop-lim/RustPython/blob/ad79873a2e86051d854118bae7cbfbf9439a7942/crates/stdlib/src/csv.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9242/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9242/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
https://github.com/RustPython/RustPython/pull/9242/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
crates/vm/src/function/argument.rshttps://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
View file https://github.com/jseop-lim/RustPython/blob/ad79873a2e86051d854118bae7cbfbf9439a7942/crates/vm/src/function/argument.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9242/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
https://github.com/RustPython/RustPython/pull/9242/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
crates/vm/src/stdlib/os.rshttps://github.com/RustPython/RustPython/pull/9242/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
View file https://github.com/jseop-lim/RustPython/blob/ad79873a2e86051d854118bae7cbfbf9439a7942/crates/vm/src/stdlib/os.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9242/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9242/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
https://github.com/RustPython/RustPython/pull/9242/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
https://github.com/RustPython/RustPython/pull/9242/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
https://github.com/RustPython/RustPython/pull/9242/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
extra_tests/snippets/vm_argument_errors.pyhttps://github.com/RustPython/RustPython/pull/9242/files#diff-3febfaa9a2cc7b3290172a8395d4c2e7ba34040c336993eb00683537156ac017
View file https://github.com/jseop-lim/RustPython/blob/ad79873a2e86051d854118bae7cbfbf9439a7942/extra_tests/snippets/vm_argument_errors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9242/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9242/files#diff-3febfaa9a2cc7b3290172a8395d4c2e7ba34040c336993eb00683537156ac017
https://github.com/RustPython/RustPython/pull/9242/files#diff-3febfaa9a2cc7b3290172a8395d4c2e7ba34040c336993eb00683537156ac017
https://github.com/RustPython/RustPython/pull/9242/files#diff-3febfaa9a2cc7b3290172a8395d4c2e7ba34040c336993eb00683537156ac017
https://github.com/RustPython/RustPython/pull/9242/files#diff-3febfaa9a2cc7b3290172a8395d4c2e7ba34040c336993eb00683537156ac017
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9242/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.