René's URL Explorer Experiment


Title: Avoid duplicate AST initialization and lazy-import locals allocation by youknowdot · Pull Request #9183 · RustPython/RustPython · GitHub

Open Graph Title: Avoid duplicate AST initialization and lazy-import locals allocation by youknowdot · Pull Request #9183 · RustPython/RustPython

X Title: Avoid duplicate AST initialization and lazy-import locals allocation by youknowdot · Pull Request #9183 · RustPython/RustPython

Description: Summary Follow up on the two review findings in #9179 after its merge. Let PyType::call invoke the AST initializer once. NodeAst::slot_new only allocates, matching CPython's PyType_GenericNew. This also preserves custom subclass initializers that deliberately omit super().__init__() and allocation-only direct __new__ calls. Check existing frame-locals identity without materializing a fresh locals dictionary during ordinary eager imports. Keep the module-level check before the __lazy_modules__ lookup. Only two Rust files change. No library copies, test expectations, or skip markers change. Validation Fresh release binary built from this follow-up on main 9f6f7719. Eight bounded observations exactly match pinned CPython 3.15 d220409: abstract warning count, inherited field writes, custom/delegating initialization, and direct __new__ allocation. Full canonical test_ast: 220 total, 205 pass, 9 skip, 6 existing expected failures. Full canonical test_lazy_import: 161 total, 157 pass, 4 skip. Corresponding pinned-CPython oracle suites pass. Fresh workspace native tests: 1,373 pass across 22 targets. Fresh C-API native tests: 123 pass, 4 existing ignored tests. Strict workspace and C-API Clippy pass with -D warnings. The existing missing-C-API skips and AST expected failures remain visible; these results do not claim complete AST or compiler parity.

Open Graph Description: Summary Follow up on the two review findings in #9179 after its merge. Let PyType::call invoke the AST initializer once. NodeAst::slot_new only allocates, matching CPython's PyType_GenericNew....

X Description: Summary Follow up on the two review findings in #9179 after its merge. Let PyType::call invoke the AST initializer once. NodeAst::slot_new only allocates, matching CPython's PyType_Generic...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9183

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f0a9cabc-8d0e-cc74-5ec5-f9db94360909
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC340:187C1E:15EBB51:1CF49B5:6B01FE3E
html-safe-nonceb9ba6eb4545056dfdaa93649adb3cf5460d067d91c159e375b2a1e644bd5fbcc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzQwOjE4N0MxRToxNUVCQjUxOjFDRjQ5QjU6NkIwMUZFM0UiLCJ2aXNpdG9yX2lkIjoiOTA4MjgxNDYzMzk3ODQ5NDUyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac04e7ee9c5fcf91f9d642bf82361bf70671b683001696a29951195bf825f2ab3a
hovercard-subject-tagpull_request:4907739188
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9183/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Follow up on the two review findings in #9179 after its merge. Let PyType::call invoke the AST initializer once. NodeAst::slot_new only allocates, matching CPython's PyType_GenericNew....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9183/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9183%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9183%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9183/files
Reloadhttps://github.com/RustPython/RustPython/pull/9183/files
Reloadhttps://github.com/RustPython/RustPython/pull/9183/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/ast-initialization-lazy-locals-315https://github.com/youknowdot/RustPython/tree/fix/ast-initialization-lazy-locals-315
Conversation 2 https://github.com/RustPython/RustPython/pull/9183
Commits 1 https://github.com/RustPython/RustPython/pull/9183/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9183/checks
Files changed https://github.com/RustPython/RustPython/pull/9183/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9183/files
Avoid duplicate AST initialization and lazy-import locals allocation https://github.com/RustPython/RustPython/pull/9183/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9183/files
ad543f2 Avoid duplicate AST initialization and eager import locals allocation youknowdot Oct 18, 2026 https://github.com/RustPython/RustPython/pull/9183/commits/ad543f242ef2e300cbda21f0f9b26355c79fd3a2
Clear filters https://github.com/RustPython/RustPython/pull/9183/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9183/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9183/files
lazy_import.rs https://github.com/RustPython/RustPython/pull/9183/files#diff-a3c04a8097c845da2c51b16acf7ef42dc4597bd17e841e5ae9f0ea78444f4b1c
python.rs https://github.com/RustPython/RustPython/pull/9183/files#diff-a8ea4fec104dbdd3b27982fa0ea6853d41f1642422a65ea5b72a36f6006878b4
crates/vm/src/lazy_import.rshttps://github.com/RustPython/RustPython/pull/9183/files#diff-a3c04a8097c845da2c51b16acf7ef42dc4597bd17e841e5ae9f0ea78444f4b1c
View file https://github.com/youknowdot/RustPython/blob/ad543f242ef2e300cbda21f0f9b26355c79fd3a2/crates/vm/src/lazy_import.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9183/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9183/files#diff-a3c04a8097c845da2c51b16acf7ef42dc4597bd17e841e5ae9f0ea78444f4b1c
https://github.com/RustPython/RustPython/pull/9183/files#diff-a3c04a8097c845da2c51b16acf7ef42dc4597bd17e841e5ae9f0ea78444f4b1c
https://github.com/RustPython/RustPython/pull/9183/files#diff-a3c04a8097c845da2c51b16acf7ef42dc4597bd17e841e5ae9f0ea78444f4b1c
https://github.com/RustPython/RustPython/pull/9183/files#diff-a3c04a8097c845da2c51b16acf7ef42dc4597bd17e841e5ae9f0ea78444f4b1c
https://github.com/RustPython/RustPython/pull/9183/files#diff-a3c04a8097c845da2c51b16acf7ef42dc4597bd17e841e5ae9f0ea78444f4b1c
https://github.com/RustPython/RustPython/pull/9183/files#diff-a3c04a8097c845da2c51b16acf7ef42dc4597bd17e841e5ae9f0ea78444f4b1c
crates/vm/src/stdlib/_ast/python.rshttps://github.com/RustPython/RustPython/pull/9183/files#diff-a8ea4fec104dbdd3b27982fa0ea6853d41f1642422a65ea5b72a36f6006878b4
View file https://github.com/youknowdot/RustPython/blob/ad543f242ef2e300cbda21f0f9b26355c79fd3a2/crates/vm/src/stdlib/_ast/python.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9183/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9183/files#diff-a8ea4fec104dbdd3b27982fa0ea6853d41f1642422a65ea5b72a36f6006878b4
https://github.com/RustPython/RustPython/pull/9183/files#diff-a8ea4fec104dbdd3b27982fa0ea6853d41f1642422a65ea5b72a36f6006878b4
https://github.com/RustPython/RustPython/pull/9183/files#diff-a8ea4fec104dbdd3b27982fa0ea6853d41f1642422a65ea5b72a36f6006878b4
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9183/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.