Title: Skip unit-test harnesses when building benchmarks by codspeed[bot] · Pull Request #9158 · RustPython/RustPython · GitHub
Open Graph Title: Skip unit-test harnesses when building benchmarks by codspeed[bot] · Pull Request #9158 · RustPython/RustPython
X Title: Skip unit-test harnesses when building benchmarks by codspeed[bot] · Pull Request #9158 · RustPython/RustPython
Description: Follow-up to #9151, where the CodSpeed job failed in a way unrelated to that PR. Problem The CodSpeed workflow often dies in Build the benchmark targets with The runner has received a shutdown signal (exit 143). Over the last ~200 runs, 18 runs failed this way, mostly main pushes, including #9151 and the two most recent main runs. In each case the build was killed while compiling the final rustpython targets. cargo codspeed build (like cargo bench) selects every target that has bench = true, and both the library and the binary have it by default. As a result, the build makes 4 LTO-linked copies of the interpreter with full debug info, about 350 MB each: artifact needed? execution bench yes microbenchmarks bench yes rustpython binary (Cargo builds it automatically for benches) yes rustpython library unit-test harness (--test) no, never run Each of these LTO compilations takes about 5 GB RSS and several minutes on the 2-core, 16 GB ubuntu-latest runner. Change bench = false on [lib] and [[bin]]. Only the criterion benches and the binary they depend on are built now. cargo test and the measured benchmarks are unchanged. Local measurement cargo-codspeed 5.0.3, -j 2 (same as CI), dependencies cached, rebuilding the rustpython crate's targets: before after cargo codspeed build wall time 9m 57s 6m 58s (−30%) LTO interpreter builds 4 3 peak system memory ~10.0 GB ~11.9 GB The build is now about 3 minutes shorter, so it spends less time near its memory peak. The peak itself did not drop, because the two bench binaries still compile and link at the same time (the difference above is sampling noise). If the shutdowns continue after this change, the next step would be to stop those two links from overlapping, or to move to a larger runner.
Open Graph Description: Follow-up to #9151, where the CodSpeed job failed in a way unrelated to that PR. Problem The CodSpeed workflow often dies in Build the benchmark targets with The runner has received a shutdown sign...
X Description: Follow-up to #9151, where the CodSpeed job failed in a way unrelated to that PR. Problem The CodSpeed workflow often dies in Build the benchmark targets with The runner has received a shutdown sign...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9158
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:afdc06d5-7bfb-c78d-7c5c-408d21bd07fe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84E2:785A9:3AC7DFB:4A9D59D:6B01FE8D |
| html-safe-nonce | 24ff4cc66b40df93c3e2d59ff76b8a887257c506799391cd9eba0aa57910dce3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEUyOjc4NUE5OjNBQzdERkI6NEE5RDU5RDo2QjAxRkU4RCIsInZpc2l0b3JfaWQiOiIyOTQ2OTQ2OTQ1Njk1MDg0OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d0c07624f348146009eec64b0f24c296d2cae694742b2ce97e1d77e7934c5081 |
| hovercard-subject-tag | pull_request:4879095168 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9158/files |
| twitter:image | https://avatars.githubusercontent.com/in/257293?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/in/257293?s=400&v=4 |
| og:image:alt | Follow-up to #9151, where the CodSpeed job failed in a way unrelated to that PR. Problem The CodSpeed workflow often dies in Build the benchmark targets with The runner has received a shutdown sign... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width