René's URL Explorer Experiment


Title: Release SQLite callbacks and expanded trace SQL safely by 1ndahous3 · Pull Request #9151 · RustPython/RustPython · GitHub

Open Graph Title: Release SQLite callbacks and expanded trace SQL safely by 1ndahous3 · Pull Request #9151 · RustPython/RustPython

X Title: Release SQLite callbacks and expanded trace SQL safely by 1ndahous3 · Pull Request #9151 · RustPython/RustPython

Description: This PR follows our AI policy Summary Release replaced and disabled trace, progress, and authorizer callbacks, and clear their registrations when a connection closes or is reinitialized. Keep active callbacks alive through invocation and result conversion, releasing Python references after native and Rust locks. Preserve deferred rollback and reject registrations against an already closed native connection. Dispose of old callbacks before publishing a replacement connection, including databases installed by reentrant finalizers. Drain deferred cleanup after BLOB operations and native handle disposal. Keep each BLOB attached to its original database across connection reinitialization. Free the SQL text allocated by SQLite for each trace callback, also addressed in the larger draft #8944. Memory usage Windows 11 x64 Workload Before After Private-memory growth over 20,000 traced queries with a 1 KiB parameter, after warmup 21.8 MiB 64 KiB Retained callback payload after 256 registrations and close, 64 KiB per callback 16 MiB 0 Known limitations When __init__() is called from an active native callback, Python finalizers remain deferred until the enclosing native operation returns. This avoids running destructors under SQLite locks, but their timing can differ from CPython and they may observe the replacement connection. AI assistance Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Bug Fixes Improved SQLite callback reliability when callbacks are replaced, cleared, or the connection is closed. Fixed cleanup when callbacks unregister themselves or interact with the connection during release. Improved connection reinitialization and cleanup during overlapping operations, including restoring default row and text handling. Fixed cases where closing a BLOB could interfere with cursor activity, and improved BLOB operations during connection closure. Tests Added regression coverage for callback lifetimes, concurrent cleanup, BLOB closure during cursor activity, and connection usability after reinitialization.

Open Graph Description: This PR follows our AI policy Summary Release replaced and disabled trace, progress, and authorizer callbacks, and clear their registrations when a connection closes or is reinitialized. Keep act...

X Description: This PR follows our AI policy Summary Release replaced and disabled trace, progress, and authorizer callbacks, and clear their registrations when a connection closes or is reinitialized. Keep act...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9151

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:78d47878-12ae-08b6-7368-9d6a752294e8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE004:6365:31B7BE5:425D1B8:6B01F376
html-safe-nonce86defc1319d651e39f6fe2884c9895c493b4c958c6db1ca2efae386a44ab8ed4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDA0OjYzNjU6MzFCN0JFNTo0MjVEMUI4OjZCMDFGMzc2IiwidmlzaXRvcl9pZCI6IjQzNTg3ODU2NTQyMDU4MzgxOTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccd1f353f1d2be9e874f7d5a4ad2afbe2a4c876f44f167dba9800e514d59ef3b4
hovercard-subject-tagpull_request:4872580418
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9151/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altThis PR follows our AI policy Summary Release replaced and disabled trace, progress, and authorizer callbacks, and clear their registrations when a connection closes or is reinitialized. Keep act...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9151/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9151%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9151%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9151/files
Reloadhttps://github.com/RustPython/RustPython/pull/9151/files
Reloadhttps://github.com/RustPython/RustPython/pull/9151/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:sqlite_callback_lifetimeshttps://github.com/1ndahous3/RustPython/tree/sqlite_callback_lifetimes
Conversation 28 https://github.com/RustPython/RustPython/pull/9151
Commits 6 https://github.com/RustPython/RustPython/pull/9151/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9151/checks
Files changed https://github.com/RustPython/RustPython/pull/9151/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9151/files
Release SQLite callbacks and expanded trace SQL safely https://github.com/RustPython/RustPython/pull/9151/files#top
Show all changes 6 commits https://github.com/RustPython/RustPython/pull/9151/files
c999c60 Release SQLite callbacks and expanded trace SQL safely 1ndahous3 Oct 15, 2026 https://github.com/RustPython/RustPython/pull/9151/commits/c999c6003eb4b59ac72561934b17679faabd093b
cfdf827 Drain SQLite callback cleanup before reinitialization and after blob … 1ndahous3 Oct 15, 2026 https://github.com/RustPython/RustPython/pull/9151/commits/cfdf827fcdc7b57e56a671773a3fc2d19b54e968
36418c4 Drain SQLite cleanup after statement reset 1ndahous3 Oct 15, 2026 https://github.com/RustPython/RustPython/pull/9151/commits/36418c4a83aba23683d995bbaae5053f4f17b17b
1bee2b2 Fix concurrent SQLite connection reinitialization 1ndahous3 Oct 15, 2026 https://github.com/RustPython/RustPython/pull/9151/commits/1bee2b2a751a5fe570a4d4583c010d27f41782ac
a9c7a56 Restore SQLite factory defaults after callback cleanup 1ndahous3 Oct 15, 2026 https://github.com/RustPython/RustPython/pull/9151/commits/a9c7a56bf92854e62441a36a944295a4a215e8de
d8b647e Merge main into SQLite callback lifetime fixes 1ndahous3 Oct 17, 2026 https://github.com/RustPython/RustPython/pull/9151/commits/d8b647e5db52ffe698c62add6d1f11ecf73ed3a4
Clear filters https://github.com/RustPython/RustPython/pull/9151/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9151/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9151/files
_sqlite3.rs https://github.com/RustPython/RustPython/pull/9151/files#diff-5a5ea8fc8d5bfc6b5da126f9574990e39802662762f23a2a6a9143beca021e15
stdlib_sqlite.py https://github.com/RustPython/RustPython/pull/9151/files#diff-af714534f7f9037baf4a054f88622295acbbf331b8266316cbc5efd1476304e9
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9151/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9151/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.