René's URL Explorer Experiment


Title: Fix update_lib marker preservation for inline classes by youknowdot · Pull Request #9131 · RustPython/RustPython · GitHub

Open Graph Title: Fix update_lib marker preservation for inline classes by youknowdot · Pull Request #9131 · RustPython/RustPython

X Title: Fix update_lib marker preservation for inline classes by youknowdot · Pull Request #9131 · RustPython/RustPython

Description: Summary Fix scripts/update_lib preserving an inherited test marker when CPython defines the destination class with an inline suite, such as class TestCDecode(TestDecode, CTest): pass. The previous output appended an indented method after that complete statement and produced invalid Python. Expand the existing inline suite before inserting retained inherited overrides, preserving original statements and comments. Parse the generated source before returning it. Cover simple/commented suites, semicolon statements, multiline headers, conditional classes, and UTF-8 class names while asserting preservation of the original class-body AST. Adjust the existing CI change detection and update_lib step conditions. Tool-only changes run 39 focused CPython tests in the existing Linux job; Rust changes retain the existing full RustPython discovery command. No new workflow or job is added, and the Rust build gates remain unchanged. No Lib/ files are changed. The affected canonical JSON migration stays with the separate Python 3.15 integration work. Validation 39 focused tests passed: PYTHONPATH=scripts python3 -m unittest update_lib.tests.test_patch_spec update_lib.tests.test_migrate -v. Normal commit hooks passed. Existing ci.yaml offline zizmor comparison: no new findings relative to main (all 15 existing diagnostic signatures unchanged). Independent source review of the tool repair and separate workflow review completed. The existing Linux job uses .python-version for the focused tool-only path; that path does not claim coverage of unrelated update_lib commands. Because this PR itself changes ci.yaml, its existing workflow-change filter naturally runs the Rust matrix once. Future tool-only edits do not enable Rust builds. No local Rust build was needed for this Python-tool repair. AI assistance: OpenAI Codex (model version unavailable); reviewed by the contributing maintainer's assistant.

Open Graph Description: Summary Fix scripts/update_lib preserving an inherited test marker when CPython defines the destination class with an inline suite, such as class TestCDecode(TestDecode, CTest): pass. The previous ...

X Description: Summary Fix scripts/update_lib preserving an inherited test marker when CPython defines the destination class with an inline suite, such as class TestCDecode(TestDecode, CTest): pass. The previous ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9131

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:63c09de7-1a40-005f-375b-9885d325d647
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6CC:DB09F:36DBEC8:460D031:6B01F7A8
html-safe-nonceb432aaf6bdc87c8f8008d0a9935dee757c9a88a6c5bf9ff882821ee84a3601b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkNDOkRCMDlGOjM2REJFQzg6NDYwRDAzMTo2QjAxRjdBOCIsInZpc2l0b3JfaWQiOiI0OTQ0OTc4NjUyMDc4MTQzNDAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdebdcf6eebd79c9ea7fe8f86c63c6bbca7efbf8ff53908ae4d01d0fcc2b8f10a
hovercard-subject-tagpull_request:4867531677
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9131/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Fix scripts/update_lib preserving an inherited test marker when CPython defines the destination class with an inline suite, such as class TestCDecode(TestDecode, CTest): pass. The previous ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9131/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9131%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9131%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9131/files
Reloadhttps://github.com/RustPython/RustPython/pull/9131/files
Reloadhttps://github.com/RustPython/RustPython/pull/9131/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/update-lib-inline-classhttps://github.com/youknowdot/RustPython/tree/fix/update-lib-inline-class
Conversation 3 https://github.com/RustPython/RustPython/pull/9131
Commits 2 https://github.com/RustPython/RustPython/pull/9131/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9131/checks
Files changed https://github.com/RustPython/RustPython/pull/9131/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9131/files
Fix update_lib marker preservation for inline classes https://github.com/RustPython/RustPython/pull/9131/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9131/files
609172c Preserve inherited test markers in inline class migrations youknowdot Oct 15, 2026 https://github.com/RustPython/RustPython/pull/9131/commits/609172c0a42f46f7150fc52b3728bd0cbc303cb8
ad6ed9b Run migration tool tests through existing CI conditions youknowdot Oct 15, 2026 https://github.com/RustPython/RustPython/pull/9131/commits/ad6ed9b2e80634ce04fb411e29f497ef7a8a741b
Clear filters https://github.com/RustPython/RustPython/pull/9131/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9131/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9131/files
ci.yaml https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
patch_spec.py https://github.com/RustPython/RustPython/pull/9131/files#diff-4d0294a6b416790357eaaa0b2efe1249572e1455d6e2b6f959b2054cd3686e4c
test_patch_spec.py https://github.com/RustPython/RustPython/pull/9131/files#diff-733fbd290f7cd0ca818993d2312eeb887a8f9898773462ea1202a1a78078aa57
.github/workflows/ci.yamlhttps://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
View file https://github.com/youknowdot/RustPython/blob/ad6ed9b2e80634ce04fb411e29f497ef7a8a741b/.github/workflows/ci.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9131/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/RustPython/RustPython/pull/9131/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
scripts/update_lib/patch_spec.pyhttps://github.com/RustPython/RustPython/pull/9131/files#diff-4d0294a6b416790357eaaa0b2efe1249572e1455d6e2b6f959b2054cd3686e4c
View file https://github.com/youknowdot/RustPython/blob/ad6ed9b2e80634ce04fb411e29f497ef7a8a741b/scripts/update_lib/patch_spec.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9131/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9131/files#diff-4d0294a6b416790357eaaa0b2efe1249572e1455d6e2b6f959b2054cd3686e4c
https://github.com/RustPython/RustPython/pull/9131/files#diff-4d0294a6b416790357eaaa0b2efe1249572e1455d6e2b6f959b2054cd3686e4c
https://github.com/RustPython/RustPython/pull/9131/files#diff-4d0294a6b416790357eaaa0b2efe1249572e1455d6e2b6f959b2054cd3686e4c
scripts/update_lib/tests/test_patch_spec.pyhttps://github.com/RustPython/RustPython/pull/9131/files#diff-733fbd290f7cd0ca818993d2312eeb887a8f9898773462ea1202a1a78078aa57
View file https://github.com/youknowdot/RustPython/blob/ad6ed9b2e80634ce04fb411e29f497ef7a8a741b/scripts/update_lib/tests/test_patch_spec.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9131/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9131/files#diff-733fbd290f7cd0ca818993d2312eeb887a8f9898773462ea1202a1a78078aa57
https://github.com/RustPython/RustPython/pull/9131/files#diff-733fbd290f7cd0ca818993d2312eeb887a8f9898773462ea1202a1a78078aa57
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9131/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.