Title: Convert native base references without consulting the Python class by youknowone · Pull Request #9090 · RustPython/RustPython · GitHub
Open Graph Title: Convert native base references without consulting the Python class by youknowone · Pull Request #9090 · RustPython/RustPython
X Title: Convert native base references without consulting the Python class by youknowone · Pull Request #9090 · RustPython/RustPython
Description: Extracted from #8963 by @1ndahous3 (the commit keeps their authorship). PyRef::into_base went through a class-based downcast and hit unreachable_unchecked on failure. A downcast consults the object's MRO, while the physical base prefix is fixed at allocation, so an object whose class has a custom mro() that omits the native base turned this into undefined behavior. Py::to_base had the same assumption as a debug assertion. Both now cast the pointer directly. The unsafe impl PySubclass contract from #9012 is what guarantees the prefix, so no runtime check is needed, and into_base loses the downcast it used to perform. Not included from #8963: the native layout id, the supports_native_layout vtable entry, and the runtime assertion in upcast / upcast_ref. Testing native_base_conversions_ignore_python_mro builds an OSError subclass, replaces its MRO with [cls, object], and converts through two base levels by reference and by value. cargo test -p rustpython-vm --features threading --lib and cargo clippy -p rustpython-vm --features threading --all-targets -- -D warnings pass on macOS. AI assistance This PR follows our AI policy. Original change written with Codex (gpt-6); extraction and test trimmed with Claude (claude-opus-5-5). 🤖 Generated with Claude Code Summary by CodeRabbit Bug Fixes Typed conversions to a base class now continue to access the original object when Python’s method resolution order omits native base classes. This prevents valid conversions from failing due to differences between Python’s class hierarchy and the object’s native layout.
Open Graph Description: Extracted from #8963 by @1ndahous3 (the commit keeps their authorship). PyRef::into_base went through a class-based downcast and hit unreachable_unchecked on failure. A downcast consults the object...
X Description: Extracted from #8963 by @1ndahous3 (the commit keeps their authorship). PyRef::into_base went through a class-based downcast and hit unreachable_unchecked on failure. A downcast consults the object...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9090
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:be7dfdc3-96c7-9bca-ba62-3a85e21d5725 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF1C:1050BD:156FDDC:1C5AF5C:6B01FE8C |
| html-safe-nonce | 4e00036dcdce7ae2f1db4863d063b7ba8c28716d0824d4da263007e15f6c4681 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjFDOjEwNTBCRDoxNTZGRERDOjFDNUFGNUM6NkIwMUZFOEMiLCJ2aXNpdG9yX2lkIjoiNDEyNjM5MzE3NzIwNjgxNjM5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 38266642c59e96550fda2ef4da79465d8e3e73eddb9fec4af2ac30e134349922 |
| hovercard-subject-tag | pull_request:4837656054 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9090/files |
| twitter:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| og:image:alt | Extracted from #8963 by @1ndahous3 (the commit keeps their authorship). PyRef::into_base went through a class-based downcast and hit unreachable_unchecked on failure. A downcast consults the object... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width