René's URL Explorer Experiment


Title: Convert native base references without consulting the Python class by youknowone · Pull Request #9090 · RustPython/RustPython · GitHub

Open Graph Title: Convert native base references without consulting the Python class by youknowone · Pull Request #9090 · RustPython/RustPython

X Title: Convert native base references without consulting the Python class by youknowone · Pull Request #9090 · RustPython/RustPython

Description: Extracted from #8963 by @1ndahous3 (the commit keeps their authorship). PyRef::into_base went through a class-based downcast and hit unreachable_unchecked on failure. A downcast consults the object's MRO, while the physical base prefix is fixed at allocation, so an object whose class has a custom mro() that omits the native base turned this into undefined behavior. Py::to_base had the same assumption as a debug assertion. Both now cast the pointer directly. The unsafe impl PySubclass contract from #9012 is what guarantees the prefix, so no runtime check is needed, and into_base loses the downcast it used to perform. Not included from #8963: the native layout id, the supports_native_layout vtable entry, and the runtime assertion in upcast / upcast_ref. Testing native_base_conversions_ignore_python_mro builds an OSError subclass, replaces its MRO with [cls, object], and converts through two base levels by reference and by value. cargo test -p rustpython-vm --features threading --lib and cargo clippy -p rustpython-vm --features threading --all-targets -- -D warnings pass on macOS. AI assistance This PR follows our AI policy. Original change written with Codex (gpt-6); extraction and test trimmed with Claude (claude-opus-5-5). 🤖 Generated with Claude Code Summary by CodeRabbit Bug Fixes Typed conversions to a base class now continue to access the original object when Python’s method resolution order omits native base classes. This prevents valid conversions from failing due to differences between Python’s class hierarchy and the object’s native layout.

Open Graph Description: Extracted from #8963 by @1ndahous3 (the commit keeps their authorship). PyRef::into_base went through a class-based downcast and hit unreachable_unchecked on failure. A downcast consults the object...

X Description: Extracted from #8963 by @1ndahous3 (the commit keeps their authorship). PyRef::into_base went through a class-based downcast and hit unreachable_unchecked on failure. A downcast consults the object...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9090

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:be7dfdc3-96c7-9bca-ba62-3a85e21d5725
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF1C:1050BD:156FDDC:1C5AF5C:6B01FE8C
html-safe-nonce4e00036dcdce7ae2f1db4863d063b7ba8c28716d0824d4da263007e15f6c4681
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjFDOjEwNTBCRDoxNTZGRERDOjFDNUFGNUM6NkIwMUZFOEMiLCJ2aXNpdG9yX2lkIjoiNDEyNjM5MzE3NzIwNjgxNjM5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac38266642c59e96550fda2ef4da79465d8e3e73eddb9fec4af2ac30e134349922
hovercard-subject-tagpull_request:4837656054
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9090/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altExtracted from #8963 by @1ndahous3 (the commit keeps their authorship). PyRef::into_base went through a class-based downcast and hit unreachable_unchecked on failure. A downcast consults the object...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9090/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9090%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9090%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9090/files
Reloadhttps://github.com/RustPython/RustPython/pull/9090/files
Reloadhttps://github.com/RustPython/RustPython/pull/9090/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:native-base-casthttps://github.com/youknowone/RustPython/tree/native-base-cast
Conversation 2 https://github.com/RustPython/RustPython/pull/9090
Commits 1 https://github.com/RustPython/RustPython/pull/9090/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9090/checks
Files changed https://github.com/RustPython/RustPython/pull/9090/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9090/files
Convert native base references without consulting the Python class https://github.com/RustPython/RustPython/pull/9090/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9090/files
2b3b68b Convert native base references without consulting the Python class 1ndahous3 Oct 13, 2026 https://github.com/RustPython/RustPython/pull/9090/commits/2b3b68be4a980a02c9fee6c7fbb5847876636b91
Clear filters https://github.com/RustPython/RustPython/pull/9090/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9090/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9090/files
crates/vm/src/object/core.rshttps://github.com/RustPython/RustPython/pull/9090/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
View file https://github.com/youknowone/RustPython/blob/2b3b68be4a980a02c9fee6c7fbb5847876636b91/crates/vm/src/object/core.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9090/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9090/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9090/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9090/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9090/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/9090/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9090/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.