Title: Keep REPL history-save errors from replacing exit status by youknowdot · Pull Request #9081 · RustPython/RustPython · GitHub
Open Graph Title: Keep REPL history-save errors from replacing exit status by youknowdot · Pull Request #9081 · RustPython/RustPython
X Title: Keep REPL history-save errors from replacing exit status by youknowdot · Pull Request #9081 · RustPython/RustPython
Description: Summary Restore #9078 onto main. That PR was accidentally merged into stack/python-3.15-8950; this follow-up contains only its two-line src/shell.rs fix in one commit based directly on current main. Treat saving REPL history as best effort on EOF and SystemExit, preserving normal exit status when the history path cannot be written. Validation The complete changed src/shell.rs blob is identical to the reviewed #9078 fix; no other files or staging-branch changes are included. Pre-commit checks passed, including rustfmt and cspell; git diff --check passed. Earlier identical-patch testing passed eight isolated Linux REPL/reference cases: writable and ENOTDIR history paths, each with EOF and SystemExit(7). Those runtime results belong to the earlier build, not this new main-based commit. Fresh hosted CI is enabled for this commit and will be checked before merging. No CI-skip marker is present. AI assistance: OpenAI Codex prepared this restoration and checked its scope and prior evidence. Summary by CodeRabbit Bug Fixes The REPL no longer crashes if saving command history fails when exiting.
Open Graph Description: Summary Restore #9078 onto main. That PR was accidentally merged into stack/python-3.15-8950; this follow-up contains only its two-line src/shell.rs fix in one commit based directly on current main...
X Description: Summary Restore #9078 onto main. That PR was accidentally merged into stack/python-3.15-8950; this follow-up contains only its two-line src/shell.rs fix in one commit based directly on current main...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9081
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4d18261b-c4e7-220f-f7ee-3c65297dfdc5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C04C:1D86C4:3E089FA:4ECB436:6B020FF0 |
| html-safe-nonce | df1956b60ceb594094d38d4b455a856a6ccc6052b95f4b8be0e854fa766aef58 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDRDOjFEODZDNDozRTA4OUZBOjRFQ0I0MzY6NkIwMjBGRjAiLCJ2aXNpdG9yX2lkIjoiODcyMTgwNjI5ODk4OTA3MjM2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 22fabd7f4776188de10f51585ca6530b2fb68ee26e9e63633e2801f78495d2df |
| hovercard-subject-tag | pull_request:4816502602 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9081/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Restore #9078 onto main. That PR was accidentally merged into stack/python-3.15-8950; this follow-up contains only its two-line src/shell.rs fix in one commit based directly on current main... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width