Title: Match Element.remove argument type diagnostics by youknowdot · Pull Request #9068 · RustPython/RustPython · GitHub
Open Graph Title: Match Element.remove argument type diagnostics by youknowdot · Pull Request #9068 · RustPython/RustPython
X Title: Match Element.remove argument type diagnostics by youknowdot · Pull Request #9068 · RustPython/RustPython
Description: Current revision Targets main after #8950, with one logical commit: 39feb175a4f6d541055cad830ebfa8ab5e9aa8fd (parent d88c9350fb5de38b8c3be74ba8b53c8dd68a9b8f). The unique patch is byte-identical to the prior reviewed head and now includes main's merged #9082 shared CI fix; original author attribution and assistance trailers are retained. No files under Lib/ are changed. Normal hooks, whitespace checks, and independent tree/history review passed. The temporary [skip ci] marker is removed and normal CI is enabled for this final head. No new local build or runtime test is claimed. Validation recorded below belongs to earlier revisions unless explicitly stated otherwise. Rebased once after #9082 merged to repair the shared Python 3.15 IO reference failure. Normal commit hooks and exact range-diff/patch-equivalence checks pass. Exact-head hosted CI is running; no additional local runtime validation is claimed. Summary Extract the independent Element.remove argument diagnostic from #8954, adapted to the exact CPython 3.14 contract: Report None specially and use the native type name for other invalid arguments. Match the 50-byte type-name limit without splitting a UTF-8 character. Preserve accepted Element subclasses, the identity/equality/reentrant removal loop, and the existing missing-child ValueError. This does not include the adjacent 3.15 missing-child message change or any XML parser changes. Sources: CPython 3.14.8 clinic wrapper, _PyArg_BadArgument, and UTF-8 precision handling. The relevant 3.14.7 contract is identical. Validation Independent source and final-diff review; normal commit hooks. Focused six-case Python snippet passes CPython 3.14.7 and 3.14.8 and fails on the prior native baseline. Native build and the six diagnostic cases passed; reference/native snippet harness: 2 pytest cases. Four unchanged canonical accelerator removal/reentrancy tests passed. The direct unittest CLI hit the existing import-depth limit while loading asyncio through unittest.mock; preloading those dependencies allowed the same tests to run without changing the recursion limit or any assertion. Stdlib and separate C-API Clippy checks with warnings denied. No XML parser was constructed or executed by these focused tests. Full workspace suites and non-Linux runtime tests were not run locally. hosted CI is temporarily skipped.
Open Graph Description: Current revision Targets main after #8950, with one logical commit: 39feb175a4f6d541055cad830ebfa8ab5e9aa8fd (parent d88c9350fb5de38b8c3be74ba8b53c8dd68a9b8f). The unique patch is byte-identical to...
X Description: Current revision Targets main after #8950, with one logical commit: 39feb175a4f6d541055cad830ebfa8ab5e9aa8fd (parent d88c9350fb5de38b8c3be74ba8b53c8dd68a9b8f). The unique patch is byte-identical to...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9068
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b37f0213-6ea7-fdeb-3595-64a951c160aa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C1C:3DCD28:1593A54:1C9A6DD:6B01FE72 |
| html-safe-nonce | 1fcc8303eb3f73963201e6b8166f1d6fffc3eb45114039311249b894423505ef |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzFDOjNEQ0QyODoxNTkzQTU0OjFDOUE2REQ6NkIwMUZFNzIiLCJ2aXNpdG9yX2lkIjoiMzgzMDY3MTE3NTUwMDAzNzc0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e560959a9a4524d0594be975a00b14542a8caf446b596e7a0fac1d2bcd4eb6b1 |
| hovercard-subject-tag | pull_request:4811474238 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9068/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Current revision Targets main after #8950, with one logical commit: 39feb175a4f6d541055cad830ebfa8ab5e9aa8fd (parent d88c9350fb5de38b8c3be74ba8b53c8dd68a9b8f). The unique patch is byte-identical to... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width