René's URL Explorer Experiment


Title: Accept dict subclasses as warning module globals by youknowdot · Pull Request #9062 · RustPython/RustPython · GitHub

Open Graph Title: Accept dict subclasses as warning module globals by youknowdot · Pull Request #9062 · RustPython/RustPython

X Title: Accept dict subclasses as warning module globals by youknowdot · Pull Request #9062 · RustPython/RustPython

Description: Current revision Targets main after #8950, with one logical commit: f9e7dd2f13900012883b8f3a2c583fcaf60f84cf (parent 06007c81fa99e813cbf4583dab326764ba0ef017). The consolidated commit has exactly the same source tree as the prior reviewed head; original author attribution and assistance trailers are retained. No files under Lib/ are changed. Normal hooks, whitespace checks, and independent tree/history review passed. The temporary [skip ci] marker is removed and normal CI is enabled for this final head. No new local build or runtime test is claimed. Validation recorded below belongs to earlier revisions unless explicitly stated otherwise. Summary Extract Python 3.14-compatible dict-subclass support for warn_explicit(module_globals=...) from #8954. Accept actual dict subclasses, while retaining the current diagnostics for other objects. Read __name__ from stored dictionary data rather than invoking subclass __getitem__ or __missing__. The loader helper still intentionally calls overridable .get for __loader__ and __spec__. The second change is a necessary correction to the mega implementation: widening the gate alone would expose the wrong lookup behavior. No frozendict dependency, 3.15 error wording, category changes, or warning-state redesign is included. Reference sources: CPython 3.14.7 warning gate and source lookup, loader blessing helper. Provenance and overlap Source mega #8954 at 43065e79ddc46eafeca58cb39398ac007b5d25f7. Based on main 02917b6d9ca73257d081ca9e2af4ecf88d185e7e, preserving merged #9034 category behavior. Current open-PR filename/source audit found no duplicate. #8951 only overlaps unrelated warning context setup; #8944/#8939 change warning-state ownership/import access, not this gate or name lookup. Validation Independent source review and normal commit hooks passed. Native baseline rejects the new dict-subclass regression; the candidate passes. Exact CPython 3.14.7 and native RustPython pass the complete updated warnings snippet. The existing initial warning output is unchanged. Twelve unchanged canonical cases pass: CFilterTests.test_module_globals and all eleven CWarnTests.test_gh86298_* loader cases. The appended regression covers loader access order and present/absent stored names with raising item/missing overrides, using an in-memory loader. Four snippet pytest entries passed (warnings and warning-keywords, both interpreters). VM and CAPI Clippy with -D warnings passed. The full workspace suite was not run locally; no existing assertions or markers were weakened.

Open Graph Description: Current revision Targets main after #8950, with one logical commit: f9e7dd2f13900012883b8f3a2c583fcaf60f84cf (parent 06007c81fa99e813cbf4583dab326764ba0ef017). The consolidated commit has exactly t...

X Description: Current revision Targets main after #8950, with one logical commit: f9e7dd2f13900012883b8f3a2c583fcaf60f84cf (parent 06007c81fa99e813cbf4583dab326764ba0ef017). The consolidated commit has exactly t...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9062

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9725ba92-59bc-4f3d-83a7-4236823f6fa0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95F0:38C5CF:3EC7A62:4F9862B:6B01F3AD
html-safe-nonce29bb491c51dc32767bc5a884887fbcc74f386c2ecfc9953c77aff2a73889f905
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUYwOjM4QzVDRjozRUM3QTYyOjRGOTg2MkI6NkIwMUYzQUQiLCJ2aXNpdG9yX2lkIjoiMjQyNjE4NzE2NTcxNDIxNTg1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1621366771b2a26da74713b84c060d6f1c729352a36912c504d0b80f466fdef5
hovercard-subject-tagpull_request:4811017227
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9062/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altCurrent revision Targets main after #8950, with one logical commit: f9e7dd2f13900012883b8f3a2c583fcaf60f84cf (parent 06007c81fa99e813cbf4583dab326764ba0ef017). The consolidated commit has exactly t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9062/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9062%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9062%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9062/files
Reloadhttps://github.com/RustPython/RustPython/pull/9062/files
Reloadhttps://github.com/RustPython/RustPython/pull/9062/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-warning-globals-dict-subclasseshttps://github.com/youknowdot/RustPython/tree/fix-warning-globals-dict-subclasses
Conversation 4 https://github.com/RustPython/RustPython/pull/9062
Commits 1 https://github.com/RustPython/RustPython/pull/9062/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9062/checks
Files changed https://github.com/RustPython/RustPython/pull/9062/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9062/files
Accept dict subclasses as warning module globals https://github.com/RustPython/RustPython/pull/9062/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9062/files
a9dcb1b Accept dict subclasses as warning module globals youknowdot Oct 10, 2026 https://github.com/RustPython/RustPython/pull/9062/commits/a9dcb1b60dd670d56bd7dc9997b8ca8ee7bd4455
Clear filters https://github.com/RustPython/RustPython/pull/9062/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9062/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9062/files
_warnings.rs https://github.com/RustPython/RustPython/pull/9062/files#diff-ca4b7e7255f8b210ca0a92f03945f1c654183f2ce09eec71b661a50f81169b6d
warn.rs https://github.com/RustPython/RustPython/pull/9062/files#diff-22d3978eb88444056684ad4261511b3050298958668e928e161d751479c21dd1
stdlib_warnings.py https://github.com/RustPython/RustPython/pull/9062/files#diff-fb6b5c510200293360ec4069861461d1d1ecfe331fcbfa1214571c4ea708125d
crates/vm/src/stdlib/_warnings.rshttps://github.com/RustPython/RustPython/pull/9062/files#diff-ca4b7e7255f8b210ca0a92f03945f1c654183f2ce09eec71b661a50f81169b6d
View file https://github.com/youknowdot/RustPython/blob/a9dcb1b60dd670d56bd7dc9997b8ca8ee7bd4455/crates/vm/src/stdlib/_warnings.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9062/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9062/files#diff-ca4b7e7255f8b210ca0a92f03945f1c654183f2ce09eec71b661a50f81169b6d
https://github.com/RustPython/RustPython/pull/9062/files#diff-ca4b7e7255f8b210ca0a92f03945f1c654183f2ce09eec71b661a50f81169b6d
https://github.com/RustPython/RustPython/pull/9062/files#diff-ca4b7e7255f8b210ca0a92f03945f1c654183f2ce09eec71b661a50f81169b6d
youknowonehttps://github.com/youknowone
Oct 10, 2026https://github.com/RustPython/RustPython/pull/9062/files#r4237681834
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9062/files
https://github.com/RustPython/RustPython/pull/9062/files#diff-ca4b7e7255f8b210ca0a92f03945f1c654183f2ce09eec71b661a50f81169b6d
crates/vm/src/warn.rshttps://github.com/RustPython/RustPython/pull/9062/files#diff-22d3978eb88444056684ad4261511b3050298958668e928e161d751479c21dd1
View file https://github.com/youknowdot/RustPython/blob/a9dcb1b60dd670d56bd7dc9997b8ca8ee7bd4455/crates/vm/src/warn.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9062/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9062/files#diff-22d3978eb88444056684ad4261511b3050298958668e928e161d751479c21dd1
https://github.com/RustPython/RustPython/pull/9062/files#diff-22d3978eb88444056684ad4261511b3050298958668e928e161d751479c21dd1
extra_tests/snippets/stdlib_warnings.pyhttps://github.com/RustPython/RustPython/pull/9062/files#diff-fb6b5c510200293360ec4069861461d1d1ecfe331fcbfa1214571c4ea708125d
View file https://github.com/youknowdot/RustPython/blob/a9dcb1b60dd670d56bd7dc9997b8ca8ee7bd4455/extra_tests/snippets/stdlib_warnings.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9062/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9062/files#diff-fb6b5c510200293360ec4069861461d1d1ecfe331fcbfa1214571c4ea708125d
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9062/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.