René's URL Explorer Experiment


Title: Use active builtins consistently in descriptor and method reductions by youknowdot · Pull Request #9057 · RustPython/RustPython · GitHub

Open Graph Title: Use active builtins consistently in descriptor and method reductions by youknowdot · Pull Request #9057 · RustPython/RustPython

X Title: Use active builtins consistently in descriptor and method reductions by youknowdot · Pull Request #9057 · RustPython/RustPython

Description: Current revision Targets Python 3.15 main at f39da82d9d38cd5bdceb9e645205e830f65126fb with one logical commit, bf4bbf65869e47949ffb5abe5d9aeb4798e57098. The unique patch is unchanged from the prior reviewed PR head (range-diff =); current main fixes, original author attribution, and assistance trailers are preserved. No files under Lib/ are changed. Normal commit hooks, changed-range hooks, whitespace checks, and source-equivalence review passed. Normal hosted CI is enabled for this exact head. Current-revision local validation is source and hooks only; earlier runtime results below remain attributed to their original revisions. Summary Follow up on merged #9037 and its original review, expanded after the same-pattern audit request. Reduction must return the active frame's exact getattr value without calling it, and raise AttributeError('getattr') when absent. Reading the interpreter-global builtins instead changes both the reconstruction callable and the failure behavior. Use frame-aware lookup for wrapper, method, and member descriptors, method wrappers, bound native methods, and Python bound methods. Retain a method descriptor's actual defining type, including types such as io.BytesIO that are not attributes of builtins. Resolve a Python bound method's __name__ before looking up getattr, preserving exception order. Restrict the builtin helper's dictionary fast path to exact dictionaries. A subclass uses one generic lookup, without retrying __missing__ after its overridden __getitem__ raises KeyError. Existing iterator reducers share this correction. Expand the existing Python regression table while retaining its original wrapper cases and assertion semantics. Module-bound native functions still reduce to their names. Classmethod/getset descriptors and pickle's separately cached getattr have different contracts and are unchanged. The same behavior is established by CPython 3.14.7 and 3.14.8. Sources: descriptor reducers, native method reducer, Python method order, and optional mapping lookup. Earlier validation before stacking on #8950 Independent source/ownership review and normal repository hooks passed. Native debug build passed. Exact CPython 3.14.7 and 3.14.8 and the native candidate pass the complete pickle snippet. Bounded Python matrices match the references for eight reducer targets, custom/missing builtins, defining-type identity, non-callable reconstruction values, module-bound functions, lookup exceptions, name-before-builtin exception order, and exact mapping callback counts. Inherited __missing__ still works; custom __getitem__ is not followed by a second __missing__ call. Negative classmethod/getset controls retain their errors. Both dedicated snippet pytest entries pass with the repository's 3.14.7 reference. Four unchanged canonical method/iterator pickle tests pass. Both canonical C-method pickle tests retain their pre-existing expected-failure outcomes; no assertion or marker was changed. VM and separately configured CAPI Clippy pass with -D warnings. All new behavior assertions are Python tests.

Open Graph Description: Current revision Targets Python 3.15 main at f39da82d9d38cd5bdceb9e645205e830f65126fb with one logical commit, bf4bbf65869e47949ffb5abe5d9aeb4798e57098. The unique patch is unchanged from the prior...

X Description: Current revision Targets Python 3.15 main at f39da82d9d38cd5bdceb9e645205e830f65126fb with one logical commit, bf4bbf65869e47949ffb5abe5d9aeb4798e57098. The unique patch is unchanged from the prior...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9057

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7a3eb28b-774a-9cde-fd4f-d1d9eac40b7e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2FA:2AF0D8:348A70:418434:6B01F923
html-safe-noncefebfa073772e4397b408e243c85f5d07c696bc71c7fe700890c0f7a1676ba041
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkZBOjJBRjBEODozNDhBNzA6NDE4NDM0OjZCMDFGOTIzIiwidmlzaXRvcl9pZCI6IjcxMTczMzcxMzE0NTM5MDUxODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf89bbc7c684b286dea83d71c99dacad0b31bef92f670439f842af57c44342912
hovercard-subject-tagpull_request:4810765946
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9057/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altCurrent revision Targets Python 3.15 main at f39da82d9d38cd5bdceb9e645205e830f65126fb with one logical commit, bf4bbf65869e47949ffb5abe5d9aeb4798e57098. The unique patch is unchanged from the prior...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9057/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9057%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9057%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9057/files
Reloadhttps://github.com/RustPython/RustPython/pull/9057/files
Reloadhttps://github.com/RustPython/RustPython/pull/9057/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-wrapper-reduce-active-builtinshttps://github.com/youknowdot/RustPython/tree/fix-wrapper-reduce-active-builtins
Conversation 9 https://github.com/RustPython/RustPython/pull/9057
Commits 1 https://github.com/RustPython/RustPython/pull/9057/commits
Checks 29 https://github.com/RustPython/RustPython/pull/9057/checks
Files changed https://github.com/RustPython/RustPython/pull/9057/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9057/files
Use active builtins consistently in descriptor and method reductions https://github.com/RustPython/RustPython/pull/9057/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9057/files
bf4bbf6 Use active builtins in descriptor and method reductions youknowdot Oct 10, 2026 https://github.com/RustPython/RustPython/pull/9057/commits/bf4bbf65869e47949ffb5abe5d9aeb4798e57098
Clear filters https://github.com/RustPython/RustPython/pull/9057/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9057/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9057/files
builtin_func.rs https://github.com/RustPython/RustPython/pull/9057/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
descriptor.rs https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
function.rs https://github.com/RustPython/RustPython/pull/9057/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
mod.rs https://github.com/RustPython/RustPython/pull/9057/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74
stdlib_pickle.py https://github.com/RustPython/RustPython/pull/9057/files#diff-74a7e756035bd389effb04dac1897417c899188b1561841be4938e09903c6a3a
crates/vm/src/builtins/builtin_func.rshttps://github.com/RustPython/RustPython/pull/9057/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
View file https://github.com/youknowdot/RustPython/blob/bf4bbf65869e47949ffb5abe5d9aeb4798e57098/crates/vm/src/builtins/builtin_func.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9057/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9057/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
https://github.com/RustPython/RustPython/pull/9057/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
crates/vm/src/builtins/descriptor.rshttps://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
View file https://github.com/youknowdot/RustPython/blob/bf4bbf65869e47949ffb5abe5d9aeb4798e57098/crates/vm/src/builtins/descriptor.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9057/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
youknowonehttps://github.com/youknowone
Oct 10, 2026https://github.com/RustPython/RustPython/pull/9057/files#r4237528749
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9057/files
youknowdothttps://github.com/youknowdot
Oct 10, 2026https://github.com/RustPython/RustPython/pull/9057/files#r4237566745
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9057/files
youknowdothttps://github.com/youknowdot
Oct 10, 2026https://github.com/RustPython/RustPython/pull/9057/files#r4237584288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
4944d19https://github.com/RustPython/RustPython/commit/4944d199fb989260f5609354d08d6628cbe38af4
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9057/files
https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
https://github.com/RustPython/RustPython/pull/9057/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
crates/vm/src/builtins/function.rshttps://github.com/RustPython/RustPython/pull/9057/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
View file https://github.com/youknowdot/RustPython/blob/bf4bbf65869e47949ffb5abe5d9aeb4798e57098/crates/vm/src/builtins/function.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9057/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9057/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
https://github.com/RustPython/RustPython/pull/9057/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
crates/vm/src/vm/mod.rshttps://github.com/RustPython/RustPython/pull/9057/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74
View file https://github.com/youknowdot/RustPython/blob/bf4bbf65869e47949ffb5abe5d9aeb4798e57098/crates/vm/src/vm/mod.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9057/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9057/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74
https://github.com/RustPython/RustPython/pull/9057/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74
extra_tests/snippets/stdlib_pickle.pyhttps://github.com/RustPython/RustPython/pull/9057/files#diff-74a7e756035bd389effb04dac1897417c899188b1561841be4938e09903c6a3a
View file https://github.com/youknowdot/RustPython/blob/bf4bbf65869e47949ffb5abe5d9aeb4798e57098/extra_tests/snippets/stdlib_pickle.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9057/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9057/files#diff-74a7e756035bd389effb04dac1897417c899188b1561841be4938e09903c6a3a
https://github.com/RustPython/RustPython/pull/9057/files#diff-74a7e756035bd389effb04dac1897417c899188b1561841be4938e09903c6a3a
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 12, 2026https://github.com/RustPython/RustPython/pull/9057/files#r4245025049
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L275-L279https://github.com/RustPython/RustPython/blob/bf4bbf65869e47949ffb5abe5d9aeb4798e57098/AGENTS.md#L275-L279
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9057/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9057/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.