René's URL Explorer Experiment


Title: Implement mkfifo with directory descriptor support by youknowdot · Pull Request #9056 · RustPython/RustPython · GitHub

Open Graph Title: Implement mkfifo with directory descriptor support by youknowdot · Pull Request #9056 · RustPython/RustPython

X Title: Implement mkfifo with directory descriptor support by youknowdot · Pull Request #9056 · RustPython/RustPython

Description: Current revision Targets Python 3.15 main with one logical commit: 5b251a5fecda927d37fcc238887362328c5c40b5, based on f39da82d9d38cd5bdceb9e645205e830f65126fb. Rebased once to include the merged shared I/O CI fix and intervening main changes. The unique patch has identical added/deleted lines and an unchanged range-diff; original author and assistance trailer are preserved. No Lib/ changes. Main's TextIOWrapper setter fix and this PR's FileIO open/EINTR changes are both preserved. Normal commit hooks, explicit changed-range hooks, and whitespace/source checks passed. No new local build or runtime test is claimed. Normal hosted CI on this exact head is pending; earlier validation below remains historical. Summary Extract the independent POSIX os.mkfifo implementation from #8954 (43065e79ddc46eafeca58cb39398ac007b5d25f7) for the Python 3.15 target. Create FIFOs through the host layer, release interpreter execution during the syscall, and retry interrupted calls after checking signals. Support dir_fd with truthful capability reporting. Keep descriptors as raw C integers so absolute paths can correctly ignore negative descriptors without manufacturing an invalid borrowed descriptor. Resolve Apple's newer mkfifoat symbol at runtime, preserving ordinary mkfifo on older systems. Adapt the mega hunk with local path/mode converters and precise descriptor overflow messages. Retry EINTR in direct-path FileIO and os.open calls, honoring signal-handler exceptions. Enabling mkfifo exposes the previously skipped canonical FIFO-open cases. os.open carries directory descriptors as raw integers through a narrow host openat wrapper, without creating a Rust descriptor borrow across callbacks. Generic DirFd conversion and custom FileIO openers are unchanged. Duplicate review found no separate mkfifo implementation. #9054 changes chmod in the same files but owns different behavior. No changes from that open PR are required. References: CPython 3.14.7 implementation and argument parser. Initial mkfifo validation (96df674) Normal repository hooks passed. VM/host-layer Clippy and separately configured CAPI Clippy passed with -D warnings. Native build passed. The focused new function in the existing stdlib_os.py snippet passed; the baseline fails with missing os.mkfifo before any filesystem operation. All 27 bounded reference/native cases match CPython 3.14.7, including path/mode/descriptor conversion order, huge-integer bounds, absolute negative descriptors, errors without filenames, and warnings-as-errors before creation. Unchanged canonical PosixTester.test_mkfifo and TestPosixDirFd.test_mkfifo_dir_fd both passed in a private temporary working directory. All behavior checks are Python-side. Tests only create, stat and unlink FIFOs in owned temporary directories; they never open a FIFO, change umask, create devices, or target user/system paths. EINTR follow-up validation The initial hosted run failed both newly enabled canonical FIFO-open tests. The same failures reproduced locally in 0.26 seconds; they are not flaky-test skips. The fix follows CPython 3.14 FileIO retry handling and os.open retry handling, with a raw directory-descriptor boundary instead of mega's borrowed-descriptor lifetime across signal callbacks. Validated follow-up commit cadfd738f5e5ef6d38cf3e63b9a4573f41eaea6e: Independent raw-descriptor lifetime/ownership review and normal hooks passed. Native build, VM/host Clippy, and separately configured CAPI Clippy passed with -D warnings. Both previously failing canonical FIFO-open tests pass unchanged in 1.27 seconds, in a private temporary directory with an external hard timeout and subprocess cleanup. These tests intentionally open only their own FIFOs. Five additional unchanged canonical tests pass: mkfifo, mkfifo dir_fd, open dir_fd, FileIO seek/tell, and FileIO attributes. Native checks match exact CPython 3.14.7/3.14.8 for raising signal handlers in FileIO/open/openat, non-EINTR filename errors, single invocation of a failing custom opener, the public signature, valid index conversion order, str/bytes paths, and the None directory-descriptor default. No invalid/closed-descriptor probes or canonical test edits are part of this follow-up. Fresh hosted CI is required; the original-head EINTR failure is superseded only after the new head is validated. Scope and remaining limitations Android retains ordinary mkfifo but no dir_fd because the pinned libc crate has no Android mkfifoat binding. Redox remains excluded; Windows/WASI modules are unchanged. Apple ABI and availability were source-reviewed, but non-Linux runtime execution was not performed. The existing shared path converter still differs from CPython in the prefix of the error for an invalid __fspath__ return; its behavior was not duplicated or broadly rewritten here. Full stdlib_os.py, full workspace tests, and the complete canonical OS suite were not run locally; they include unrelated operations outside this bounded validation. Hosted CI remains required. No canonical assertions or skips were weakened, and no Rust behavior tests were added. Summary by CodeRabbit New Features Added os.mkfifo for creating named pipes, with support for paths, permissions, and directory descriptors where available. Added directory-descriptor support to os.open on supported platforms. Updated Python compatibility to 3.15. Bug Fixes File-opening operations now retry when interrupted, while still checking for pending signals. Improved handling of negative timestamps on Windows and integer-like values in logarithm and sleep operations. Corrected behavior for memory-mapped searches, struct format errors, and AST constructor validation.

Open Graph Description: Current revision Targets Python 3.15 main with one logical commit: 5b251a5fecda927d37fcc238887362328c5c40b5, based on f39da82d9d38cd5bdceb9e645205e830f65126fb. Rebased once to include the merged sh...

X Description: Current revision Targets Python 3.15 main with one logical commit: 5b251a5fecda927d37fcc238887362328c5c40b5, based on f39da82d9d38cd5bdceb9e645205e830f65126fb. Rebased once to include the merged sh...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9056

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:db08c70d-d57c-ff08-2e10-f633366e78be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECD4:16E4ED:4611C0:5848BB:6B01FE9C
html-safe-nonce12baba1c3fbae2bbd5507ed9bfeeac9cc85970f1976f5224ec6ff35fd7a9caa5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0Q0OjE2RTRFRDo0NjExQzA6NTg0OEJCOjZCMDFGRTlDIiwidmlzaXRvcl9pZCI6Ijc3NjY3NTc1MjcyNzkzNjY2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0c52ac6f50b10e92a266fef2ff781934195a016c03b3c6f881b43eba0f257303
hovercard-subject-tagpull_request:4810629238
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9056/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altCurrent revision Targets Python 3.15 main with one logical commit: 5b251a5fecda927d37fcc238887362328c5c40b5, based on f39da82d9d38cd5bdceb9e645205e830f65126fb. Rebased once to include the merged sh...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9056/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9056%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9056%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9056/files
Reloadhttps://github.com/RustPython/RustPython/pull/9056/files
Reloadhttps://github.com/RustPython/RustPython/pull/9056/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-mkfifo-directory-descriptorshttps://github.com/youknowdot/RustPython/tree/fix-mkfifo-directory-descriptors
Conversation 8 https://github.com/RustPython/RustPython/pull/9056
Commits 1 https://github.com/RustPython/RustPython/pull/9056/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9056/checks
Files changed https://github.com/RustPython/RustPython/pull/9056/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9056/files
Implement mkfifo with directory descriptor support https://github.com/RustPython/RustPython/pull/9056/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9056/files
5b251a5 Implement mkfifo with directory descriptor support youknowdot Oct 10, 2026 https://github.com/RustPython/RustPython/pull/9056/commits/5b251a5fecda927d37fcc238887362328c5c40b5
Clear filters https://github.com/RustPython/RustPython/pull/9056/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9056/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9056/files
crt_fd.rs https://github.com/RustPython/RustPython/pull/9056/files#diff-ff82b67fc4d8cf44a1248a541dbf04dca2c5554aaaaf76d169327f8930f004c4
posix.rs https://github.com/RustPython/RustPython/pull/9056/files#diff-c4d8d17cd194261af90a2541465d39d6a285b66572131399a8690bd4c7bd599a
_io.rs https://github.com/RustPython/RustPython/pull/9056/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
os.rs https://github.com/RustPython/RustPython/pull/9056/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
posix.rs https://github.com/RustPython/RustPython/pull/9056/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
stdlib_os.py https://github.com/RustPython/RustPython/pull/9056/files#diff-4c445fa6cef3356957ef3018698f8e697672ec3e3b68eb58f431f19af2c9923a
crates/host_env/src/crt_fd.rshttps://github.com/RustPython/RustPython/pull/9056/files#diff-ff82b67fc4d8cf44a1248a541dbf04dca2c5554aaaaf76d169327f8930f004c4
View file https://github.com/youknowdot/RustPython/blob/5b251a5fecda927d37fcc238887362328c5c40b5/crates/host_env/src/crt_fd.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9056/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9056/files#diff-ff82b67fc4d8cf44a1248a541dbf04dca2c5554aaaaf76d169327f8930f004c4
https://github.com/RustPython/RustPython/pull/9056/files#diff-ff82b67fc4d8cf44a1248a541dbf04dca2c5554aaaaf76d169327f8930f004c4
crates/host_env/src/posix.rshttps://github.com/RustPython/RustPython/pull/9056/files#diff-c4d8d17cd194261af90a2541465d39d6a285b66572131399a8690bd4c7bd599a
View file https://github.com/youknowdot/RustPython/blob/5b251a5fecda927d37fcc238887362328c5c40b5/crates/host_env/src/posix.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9056/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9056/files#diff-c4d8d17cd194261af90a2541465d39d6a285b66572131399a8690bd4c7bd599a
https://github.com/RustPython/RustPython/pull/9056/files#diff-c4d8d17cd194261af90a2541465d39d6a285b66572131399a8690bd4c7bd599a
crates/vm/src/stdlib/_io.rshttps://github.com/RustPython/RustPython/pull/9056/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
View file https://github.com/youknowdot/RustPython/blob/5b251a5fecda927d37fcc238887362328c5c40b5/crates/vm/src/stdlib/_io.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9056/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9056/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
https://github.com/RustPython/RustPython/pull/9056/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
https://github.com/RustPython/RustPython/pull/9056/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
https://github.com/RustPython/RustPython/pull/9056/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
crates/vm/src/stdlib/os.rshttps://github.com/RustPython/RustPython/pull/9056/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
View file https://github.com/youknowdot/RustPython/blob/5b251a5fecda927d37fcc238887362328c5c40b5/crates/vm/src/stdlib/os.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9056/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9056/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
https://github.com/RustPython/RustPython/pull/9056/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
https://github.com/RustPython/RustPython/pull/9056/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
https://github.com/RustPython/RustPython/pull/9056/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
https://github.com/RustPython/RustPython/pull/9056/files#diff-3a1b2246dc47369778bf6889ee62be670eee468a599dee319ca981ead50d686a
crates/vm/src/stdlib/posix.rshttps://github.com/RustPython/RustPython/pull/9056/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
View file https://github.com/youknowdot/RustPython/blob/5b251a5fecda927d37fcc238887362328c5c40b5/crates/vm/src/stdlib/posix.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9056/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9056/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
https://github.com/RustPython/RustPython/pull/9056/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
https://github.com/RustPython/RustPython/pull/9056/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
https://github.com/RustPython/RustPython/pull/9056/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9056/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9056/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.