René's URL Explorer Experiment


Title: Reuse stored dict hashes when merging call keywords by youknowdot · Pull Request #9053 · RustPython/RustPython · GitHub

Open Graph Title: Reuse stored dict hashes when merging call keywords by youknowdot · Pull Request #9053 · RustPython/RustPython

X Title: Reuse stored dict hashes when merging call keywords by youknowdot · Pull Request #9053 · RustPython/RustPython

Description: Summary Extract the exact-dict keyword-merge cached-hash path from #8954 (43065e79ddc46eafeca58cb39398ac007b5d25f7) onto Python 3.14 main (3af5f8a15314446d2b28a90e429c938dc7b8beeb). Snapshot each key, value and stored hash under one read lock, then use the existing fallible known-hash containment/insertion helpers after unlocking. Expanding an exact dictionary into a call must not invoke its keys' __hash__ again during this merge. Equality errors such as RuntimeError also reach Python instead of the old containment unwrap. The exact-dict guard, mapping fallback, snapshot order and duplicate detection stay in place. Only crate-private snapshot accessors are added. References: CPython 3.14.7 DICT_MERGE and stored-hash dictionary merge. Merged #8858 covers other dictionary hash-reuse paths, not frame.rs. Merged #8957 covers native keyword dispatch. Both remain intact, and open #8951 does not contain this extraction. Validation Exact CPython 3.14.7 and this native head pass the complete updated syntax_function_args.py snippet; its native pytest entry passes. A harmless baseline counter records two extra keyword hashes on unchanged main, versus zero on CPython and this head. Raising callbacks were deliberately not run against the old unwrap path. Four focused existing-snippet scenarios cover one-shot string-key hashing, duplicate detection, non-string validation, and equality exception identity. Existing canonical test_extcall doctest passes unchanged. Independent source audit checked key/hash identity, owned snapshots, lock release and private API scope. Normal repository hooks, VM Clippy and separate C-API Clippy pass. The pre-existing snippet's AST is unchanged; only the reviewed function and invocation were appended. This is stored-hash reuse, not a rewrite of every kwargs error or mutation rule. Existing snapshot-versus-live-source differences remain. CPython specially formats equality-raised AttributeError and single-argument KeyError; this narrow path propagates them directly instead of the previous panic, and complete formatter parity remains separate work. No canonical tests, README wording, implementation-name guards or Rust behavioral tests changed. Local validation is bounded Linux validation, not a complete workspace or cross-platform claim. Full hosted CI is pending; this remains a draft for review. AI-assisted implementation and validation with OpenAI Codex; model identifier unavailable. No human review is implied. Summary by CodeRabbit Bug Fixes Improved keyword-argument dictionary expansion: duplicate keywords and non-string keys continue to raise TypeError, while errors raised during key comparison are preserved. Avoided unnecessarily rehashing string-subclass keys during expansion.

Open Graph Description: Summary Extract the exact-dict keyword-merge cached-hash path from #8954 (43065e79ddc46eafeca58cb39398ac007b5d25f7) onto Python 3.14 main (3af5f8a15314446d2b28a90e429c938dc7b8beeb). Snapshot each k...

X Description: Summary Extract the exact-dict keyword-merge cached-hash path from #8954 (43065e79ddc46eafeca58cb39398ac007b5d25f7) onto Python 3.14 main (3af5f8a15314446d2b28a90e429c938dc7b8beeb). Snapshot each k...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9053

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:169619d4-5c6f-4698-7adc-9e6f038d8c59
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD82:25F5AB:F9465:13EA0F:6B01FE69
html-safe-noncec796d60bc7d5ca087e32972d3d3e7dbd92c95b876acf9c8c537c5757f4a4db82
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDgyOjI1RjVBQjpGOTQ2NToxM0VBMEY6NkIwMUZFNjkiLCJ2aXNpdG9yX2lkIjoiNzUxNzkyMzY4MDI3MDI4NjQ0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac007be06241f1fa05ae581723975bea3d9333ee13caca683cf5f68af568b77fcc
hovercard-subject-tagpull_request:4810518278
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9053/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Extract the exact-dict keyword-merge cached-hash path from #8954 (43065e79ddc46eafeca58cb39398ac007b5d25f7) onto Python 3.14 main (3af5f8a15314446d2b28a90e429c938dc7b8beeb). Snapshot each k...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9053/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9053%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9053%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9053/files
Reloadhttps://github.com/RustPython/RustPython/pull/9053/files
Reloadhttps://github.com/RustPython/RustPython/pull/9053/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-keyword-dict-cached-hasheshttps://github.com/youknowdot/RustPython/tree/fix-keyword-dict-cached-hashes
Conversation 4 https://github.com/RustPython/RustPython/pull/9053
Commits 1 https://github.com/RustPython/RustPython/pull/9053/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9053/checks
Files changed https://github.com/RustPython/RustPython/pull/9053/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9053/files
Reuse stored dict hashes when merging call keywords https://github.com/RustPython/RustPython/pull/9053/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9053/files
749e4ca Reuse exact dictionary hashes when merging call keywords youknowdot Oct 10, 2026 https://github.com/RustPython/RustPython/pull/9053/commits/749e4ca2447cc1bac90cfba60499efe0415bc3bb
Clear filters https://github.com/RustPython/RustPython/pull/9053/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9053/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9053/files
dict.rs https://github.com/RustPython/RustPython/pull/9053/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
dict_inner.rs https://github.com/RustPython/RustPython/pull/9053/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
frame.rs https://github.com/RustPython/RustPython/pull/9053/files#diff-03f2741d7d424014f3d2f0c82226be52fa58134aab34bf0780714ee67a248deb
syntax_function_args.py https://github.com/RustPython/RustPython/pull/9053/files#diff-afa7b393d69f941ddea93f27530d5f65ac9458916522d009eee896acc3a6083a
crates/vm/src/builtins/dict.rshttps://github.com/RustPython/RustPython/pull/9053/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
View file https://github.com/youknowdot/RustPython/blob/749e4ca2447cc1bac90cfba60499efe0415bc3bb/crates/vm/src/builtins/dict.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9053/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9053/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9053/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
crates/vm/src/dict_inner.rshttps://github.com/RustPython/RustPython/pull/9053/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
View file https://github.com/youknowdot/RustPython/blob/749e4ca2447cc1bac90cfba60499efe0415bc3bb/crates/vm/src/dict_inner.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9053/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9053/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/9053/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/9053/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/9053/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
crates/vm/src/frame.rshttps://github.com/RustPython/RustPython/pull/9053/files#diff-03f2741d7d424014f3d2f0c82226be52fa58134aab34bf0780714ee67a248deb
View file https://github.com/youknowdot/RustPython/blob/749e4ca2447cc1bac90cfba60499efe0415bc3bb/crates/vm/src/frame.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9053/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9053/files#diff-03f2741d7d424014f3d2f0c82226be52fa58134aab34bf0780714ee67a248deb
https://github.com/RustPython/RustPython/pull/9053/files#diff-03f2741d7d424014f3d2f0c82226be52fa58134aab34bf0780714ee67a248deb
extra_tests/snippets/syntax_function_args.pyhttps://github.com/RustPython/RustPython/pull/9053/files#diff-afa7b393d69f941ddea93f27530d5f65ac9458916522d009eee896acc3a6083a
View file https://github.com/youknowdot/RustPython/blob/749e4ca2447cc1bac90cfba60499efe0415bc3bb/extra_tests/snippets/syntax_function_args.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9053/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9053/files#diff-afa7b393d69f941ddea93f27530d5f65ac9458916522d009eee896acc3a6083a
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 10, 2026https://github.com/RustPython/RustPython/pull/9053/files#r4237423139
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L273-L279https://github.com/RustPython/RustPython/blob/749e4ca2447cc1bac90cfba60499efe0415bc3bb/AGENTS.md#L273-L279
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9053/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9053/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.