Title: Raise IndexError for oversized SQLite blob indices by youknowdot · Pull Request #9048 · RustPython/RustPython · GitHub
Open Graph Title: Raise IndexError for oversized SQLite blob indices by youknowdot · Pull Request #9048 · RustPython/RustPython
X Title: Raise IndexError for oversized SQLite blob indices by youknowdot · Pull Request #9048 · RustPython/RustPython
Description: Current revision Targets main after #8950, with one logical commit: f61c70f881f8f1821e7bb43501f3d56b3f09189b (parent a10744303f6fb113a6082dde133958ad882d25a4). The unique implementation and regression lines are unchanged after rebasing onto current main; original author attribution and assistance trailers are retained. No files under Lib/ are changed. Normal hooks, whitespace checks, and independent tree/history review passed. The temporary [skip ci] marker is removed and normal CI is enabled for this final head. No new local build or runtime test is claimed. Validation recorded below belongs to earlier revisions unless explicitly stated otherwise. Resolved the append conflict with #9014 by retaining all current-main aggregate lifetime tests and appending the original blob-index regression block unchanged. Independent source review and normal hooks pass. Main's #9082 shared IO correction is included. Exact-head hosted CI is pending; no fresh local runtime validation is claimed. Summary Extract the independent SQLite Blob index-conversion fix from #8954 (43065e79ddc46eafeca58cb39398ac007b5d25f7) onto Python 3.14 main (3af5f8a15314446d2b28a90e429c938dc7b8beeb). Convert blob subscripts using pointer-sized signed bounds and raise IndexError for oversized indices. Preserve the original index object's type in overflow diagnostics and propagate errors raised by __index__ unchanged. Narrow to SQLite's c_int only after the blob bounds check succeeds. Add bounded read/write regressions to the existing Python snippet; preserve canonical tests and the snippet's pre-existing guard unchanged. This matches CPython 3.14.7 blob index conversion and PyNumber_AsSsize_t. It excludes the mega PR's separate callback/lifetime change and all Python 3.15 migration work. Related merged #7981 covers assigned values, and #8855 covers Row indices; both are already in main. Open #9014 concerns callback lifetime cleanup, not this conversion, although its appended snippet may need conflict resolution when integrated. Validation Exact CPython 3.14.7: complete updated SQLite snippet and existing BlobTests pass (44 tests, 2 existing missing-_testcapi skips). SQLite-enabled native build: unchanged main fails the new regression with OverflowError; this head passes the complete snippet, its pytest entry, and all 44 existing BlobTests (2 existing skips). Broader native test_sqlite3: both unchanged main and this head run 398 tests with the same 2 debug-build import RecursionErrors, 11 skips, and 16 expected failures. No assertions or expected-failure markers were changed to hide these results. SQLite-enabled stdlib Clippy with warnings denied, separate C-API Clippy, and normal repository commit hooks. Local checks are bounded Linux checks, not a claim of a complete workspace test run or cross-platform validation. Full hosted CI is temporarily skipped. This remains a draft for review. AI-assisted implementation and validation with OpenAI Codex; model identifier unavailable. No human review is implied. Summary by CodeRabbit Bug Fixes Improved SQLite Blob indexing for large and custom index values, with clearer errors when indices exceed supported limits. Reads and writes now handle boundary cases more consistently. Review follow-up The overflow diagnostic now uses the stored C type-name equivalent and caps it at 200 UTF-8 bytes without splitting a character, matching CPython 3.14.7. The existing Python regression adds ASCII and multibyte read/write cases. Exact-reference and native full snippets, all 44 existing BlobTests (two existing skips), the focused multibyte oracle, and both snippet pytest entries passed. Normal hooks and SQLite-enabled Clippy passed; CAPI Clippy also passed.
Open Graph Description: Current revision Targets main after #8950, with one logical commit: f61c70f881f8f1821e7bb43501f3d56b3f09189b (parent a10744303f6fb113a6082dde133958ad882d25a4). The unique implementation and regress...
X Description: Current revision Targets main after #8950, with one logical commit: f61c70f881f8f1821e7bb43501f3d56b3f09189b (parent a10744303f6fb113a6082dde133958ad882d25a4). The unique implementation and regress...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9048
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cb58e9d9-acef-73c6-558c-3a5c635a9884 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4C2:21BD98:30A010A:3DAEBD4:6B01FE74 |
| html-safe-nonce | 83f91b7ca6f000039a19d14d8e645285f752d3ea947aafad907d7d9c525a957b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEMyOjIxQkQ5ODozMEEwMTBBOjNEQUVCRDQ6NkIwMUZFNzQiLCJ2aXNpdG9yX2lkIjoiNjI2MTMyMjM4MjM5NzUzNzkwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 210b1b57e4729ea6d71ec5b0155e2d168b6a38353fd45ea5f6193ac203a887a7 |
| hovercard-subject-tag | pull_request:4810332774 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9048/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Current revision Targets main after #8950, with one logical commit: f61c70f881f8f1821e7bb43501f3d56b3f09189b (parent a10744303f6fb113a6082dde133958ad882d25a4). The unique implementation and regress... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width