René's URL Explorer Experiment


Title: csv: preserve dialect conversion errors and ordering by youknowdot · Pull Request #9020 · RustPython/RustPython · GitHub

Open Graph Title: csv: preserve dialect conversion errors and ordering by youknowdot · Pull Request #9020 · RustPython/RustPython

X Title: csv: preserve dialect conversion errors and ordering by youknowdot · Pull Request #9020 · RustPython/RustPython

Description: Summary Make CSV dialect construction collect raw attributes and keyword overrides before converting fields, using Python 3.14's lookup/conversion order. Preserve exceptions from strict, doublequote, and skipinitialspace truth conversion for instances, classes, native _csv.Dialect, and dialect registration. Read dialect classes directly rather than instantiating them, and skip overridden attributes before lookup or conversion. Continue treating failed attribute lookup as an absent attribute and applying defaults, including the default-quoting interaction with quotechar=None. Use the same ordered conversion path for keyword options and native dialect construction, retaining original exception objects. This is a coherent replacement of the existing duplicated dialect-conversion paths. A one-line strict propagation change is insufficient: the old parser also replaces exceptions, instantiates class inputs, and converts overridden attributes before applying keyword options. The shared path removes the duplicated conversion code. The strict-conversion issue was identified while auditing #8954. That PR's attribute-lookup propagation was intentionally not copied because CPython 3.14 ignores attribute lookup failures here. Validation Base: bd8fdb7e5ca3e4e9f78f4f34b122a84c9dd2e2d0. Head: 62a324e740cf0f19a219e358304bce24bd0212de. Reference: CPython 3.14.7, Linux x86_64. The new regression in the existing extra_tests/snippets/stdlib_csv.py fails the separately built, immutable current-main executable because a strict.__bool__ exception is suppressed. The complete CSV snippet passes patched RustPython and CPython 3.14.7 through the actual pytest snippet runner. Unmodified canonical -m test test_csv passes on baseline and patched RustPython: 134 tests, 6 skips. Existing expected-failure marking is unchanged. Observation tests match CPython's field lookup/conversion order, lookup failures, class handling, keyword override behavior, and exception precedence. Independent 432-case constructor review covers _csv.Dialect, reader, and writer, with 8 fields and 18 values per field. Baseline differs on 242 cases; patched semantic outcomes match all 432. The remaining 21 text-only differences are 18 preexisting validation-error wordings and 3 generic Rust integer-overflow messages versus CPython's C-int wording. Unknown keyword and excess reader/writer positional arguments fail before truth conversion. This does not change the preexisting non-ASCII delimiter limitation, native-dialect identity behavior, or unrelated CSV parsing/writing paths. Broad Rust runtime suites were not executed; only focused CSV runtime checks and compile-only aggregates are used. Additional checks passed: cargo clippy --locked --release -p rustpython-stdlib --all-targets -- -D warnings cargo test --locked --release --workspace --exclude rustpython_wasm --exclude rustpython-venvlauncher --exclude rustpython-capi --no-run From crates/capi: cargo test --locked --release --no-run Normal commit hooks passed without changing the tested source or regression file. AI assistance OpenAI Codex assisted with the audit, implementation, regression tests, and validation. The runtime checks above were actually executed in the Linux environment; no untested platform behavior is claimed.

Open Graph Description: Summary Make CSV dialect construction collect raw attributes and keyword overrides before converting fields, using Python 3.14's lookup/conversion order. Preserve exceptions from strict, doubl...

X Description: Summary Make CSV dialect construction collect raw attributes and keyword overrides before converting fields, using Python 3.14's lookup/conversion order. Preserve exceptions from strict, d...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9020

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23d92543-4200-f13a-0b67-9952acf4d88c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C58:2E5652:355A8E2:4401E0A:6B01E6C4
html-safe-nonce476b0277f7824194b1e79252ed425646e1408ea6110873dac29fa036a167ecc2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzU4OjJFNTY1MjozNTVBOEUyOjQ0MDFFMEE6NkIwMUU2QzQiLCJ2aXNpdG9yX2lkIjoiNDA2OTkyNzA0NDU5NzgwMjY5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ff49071a39c216d1693dec22e369ac7bc254533a3cac14e74e554a3449c0139
hovercard-subject-tagpull_request:4800357738
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9020/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Make CSV dialect construction collect raw attributes and keyword overrides before converting fields, using Python 3.14's lookup/conversion order. Preserve exceptions from strict, doubl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9020/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9020%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9020%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9020/files
Reloadhttps://github.com/RustPython/RustPython/pull/9020/files
Reloadhttps://github.com/RustPython/RustPython/pull/9020/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-csv-dialect-conversionhttps://github.com/youknowdot/RustPython/tree/fix-csv-dialect-conversion
Conversation 3 https://github.com/RustPython/RustPython/pull/9020
Commits 1 https://github.com/RustPython/RustPython/pull/9020/commits
Checks 21 https://github.com/RustPython/RustPython/pull/9020/checks
Files changed https://github.com/RustPython/RustPython/pull/9020/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9020/files
csv: preserve dialect conversion errors and ordering https://github.com/RustPython/RustPython/pull/9020/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9020/files
62a324e Preserve CSV dialect conversion errors and ordering youknowdot Oct 9, 2026 https://github.com/RustPython/RustPython/pull/9020/commits/62a324e740cf0f19a219e358304bce24bd0212de
Clear filters https://github.com/RustPython/RustPython/pull/9020/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9020/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9020/files
csv.rs https://github.com/RustPython/RustPython/pull/9020/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
stdlib_csv.py https://github.com/RustPython/RustPython/pull/9020/files#diff-3d834bd9b008124d1d115c12c5a34a5b18603e108f9ea2ea03f9d506bd9161bd
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9020/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9020/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.