Title: csv: preserve dialect conversion errors and ordering by youknowdot · Pull Request #9020 · RustPython/RustPython · GitHub
Open Graph Title: csv: preserve dialect conversion errors and ordering by youknowdot · Pull Request #9020 · RustPython/RustPython
X Title: csv: preserve dialect conversion errors and ordering by youknowdot · Pull Request #9020 · RustPython/RustPython
Description: Summary Make CSV dialect construction collect raw attributes and keyword overrides before converting fields, using Python 3.14's lookup/conversion order. Preserve exceptions from strict, doublequote, and skipinitialspace truth conversion for instances, classes, native _csv.Dialect, and dialect registration. Read dialect classes directly rather than instantiating them, and skip overridden attributes before lookup or conversion. Continue treating failed attribute lookup as an absent attribute and applying defaults, including the default-quoting interaction with quotechar=None. Use the same ordered conversion path for keyword options and native dialect construction, retaining original exception objects. This is a coherent replacement of the existing duplicated dialect-conversion paths. A one-line strict propagation change is insufficient: the old parser also replaces exceptions, instantiates class inputs, and converts overridden attributes before applying keyword options. The shared path removes the duplicated conversion code. The strict-conversion issue was identified while auditing #8954. That PR's attribute-lookup propagation was intentionally not copied because CPython 3.14 ignores attribute lookup failures here. Validation Base: bd8fdb7e5ca3e4e9f78f4f34b122a84c9dd2e2d0. Head: 62a324e740cf0f19a219e358304bce24bd0212de. Reference: CPython 3.14.7, Linux x86_64. The new regression in the existing extra_tests/snippets/stdlib_csv.py fails the separately built, immutable current-main executable because a strict.__bool__ exception is suppressed. The complete CSV snippet passes patched RustPython and CPython 3.14.7 through the actual pytest snippet runner. Unmodified canonical -m test test_csv passes on baseline and patched RustPython: 134 tests, 6 skips. Existing expected-failure marking is unchanged. Observation tests match CPython's field lookup/conversion order, lookup failures, class handling, keyword override behavior, and exception precedence. Independent 432-case constructor review covers _csv.Dialect, reader, and writer, with 8 fields and 18 values per field. Baseline differs on 242 cases; patched semantic outcomes match all 432. The remaining 21 text-only differences are 18 preexisting validation-error wordings and 3 generic Rust integer-overflow messages versus CPython's C-int wording. Unknown keyword and excess reader/writer positional arguments fail before truth conversion. This does not change the preexisting non-ASCII delimiter limitation, native-dialect identity behavior, or unrelated CSV parsing/writing paths. Broad Rust runtime suites were not executed; only focused CSV runtime checks and compile-only aggregates are used. Additional checks passed: cargo clippy --locked --release -p rustpython-stdlib --all-targets -- -D warnings cargo test --locked --release --workspace --exclude rustpython_wasm --exclude rustpython-venvlauncher --exclude rustpython-capi --no-run From crates/capi: cargo test --locked --release --no-run Normal commit hooks passed without changing the tested source or regression file. AI assistance OpenAI Codex assisted with the audit, implementation, regression tests, and validation. The runtime checks above were actually executed in the Linux environment; no untested platform behavior is claimed.
Open Graph Description: Summary Make CSV dialect construction collect raw attributes and keyword overrides before converting fields, using Python 3.14's lookup/conversion order. Preserve exceptions from strict, doubl...
X Description: Summary Make CSV dialect construction collect raw attributes and keyword overrides before converting fields, using Python 3.14's lookup/conversion order. Preserve exceptions from strict, d...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9020
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:23d92543-4200-f13a-0b67-9952acf4d88c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C58:2E5652:355A8E2:4401E0A:6B01E6C4 |
| html-safe-nonce | 476b0277f7824194b1e79252ed425646e1408ea6110873dac29fa036a167ecc2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzU4OjJFNTY1MjozNTVBOEUyOjQ0MDFFMEE6NkIwMUU2QzQiLCJ2aXNpdG9yX2lkIjoiNDA2OTkyNzA0NDU5NzgwMjY5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7ff49071a39c216d1693dec22e369ac7bc254533a3cac14e74e554a3449c0139 |
| hovercard-subject-tag | pull_request:4800357738 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9020/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Make CSV dialect construction collect raw attributes and keyword overrides before converting fields, using Python 3.14's lookup/conversion order. Preserve exceptions from strict, doubl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width