René's URL Explorer Experiment


Title: _json: skip items() for empty dict subclasses by youknowdot · Pull Request #9018 · RustPython/RustPython · GitHub

Open Graph Title: _json: skip items() for empty dict subclasses by youknowdot · Pull Request #9018 · RustPython/RustPython

X Title: _json: skip items() for empty dict subclasses by youknowdot · Pull Request #9018 · RustPython/RustPython

Description: Summary Split the Python 3.14-compatible empty-dictionary encoder fix from #8954. Check the native dictionary size before calling a subclass's items() method. Empty dictionary subclasses should encode as {} without invoking that method, matching CPython 3.14. Nonempty subclasses keep their custom items() behavior. Extend the existing JSON snippet with empty-subclass cases at the root and inside a list, both sorting modes, and a nonempty-subclass control. No standard-library assertions change. Validation Reproduced the failure on main d0dfcb54 through the snippet runner: items() was called on an empty dictionary subclass. The same snippet passes with this patch and on CPython 3.14.7. All 14 selected canonical TestCDump, TestCDefault, and TestCIndent tests pass unchanged. Release workspace test targets compile with --no-run, excluding WASM, venvlauncher, and C API; the separate C-API test target also compiles with --no-run. Affected-crate Clippy and repository hooks pass. Local runtime validation is limited to the focused snippet and canonical tests above. Broad Rust test targets were compile-checked, not executed. Reference: CPython 3.14 dictionary encoder. AI assistance This PR follows the project's AI policy. OpenAI Codex assisted with auditing the split, implementation, regression coverage, and validation. The runtime does not expose an exact model identifier.

Open Graph Description: Summary Split the Python 3.14-compatible empty-dictionary encoder fix from #8954. Check the native dictionary size before calling a subclass's items() method. Empty dictionary subclasses should...

X Description: Summary Split the Python 3.14-compatible empty-dictionary encoder fix from #8954. Check the native dictionary size before calling a subclass's items() method. Empty dictionary subclasses sh...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9018

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7c279408-3880-8c0f-5b20-b3d733e7b44b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F62:842EC:2FE3339:3FDE5C5:6B01E6B2
html-safe-noncebdbabf180b28b7a43dc070d3fe3de7c16262aa0c773de5eec91f96f1adb8a1e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjYyOjg0MkVDOjJGRTMzMzk6M0ZERTVDNTo2QjAxRTZCMiIsInZpc2l0b3JfaWQiOiI5MDkwNjkzNzY0MzY3OTAyMzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6b276280f5ec2b8fa0193886c91140e357e1ecf15ed10acbd30363c3d6986ee6
hovercard-subject-tagpull_request:4799344953
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9018/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Split the Python 3.14-compatible empty-dictionary encoder fix from #8954. Check the native dictionary size before calling a subclass's items() method. Empty dictionary subclasses should...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9018/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9018%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9018%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9018/files
Reloadhttps://github.com/RustPython/RustPython/pull/9018/files
Reloadhttps://github.com/RustPython/RustPython/pull/9018/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-json-empty-dict-subclasseshttps://github.com/youknowdot/RustPython/tree/fix-json-empty-dict-subclasses
Conversation 6 https://github.com/RustPython/RustPython/pull/9018
Commits 1 https://github.com/RustPython/RustPython/pull/9018/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9018/checks
Files changed https://github.com/RustPython/RustPython/pull/9018/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9018/files
_json: skip items() for empty dict subclasses https://github.com/RustPython/RustPython/pull/9018/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9018/files
05e06d0 Skip overridden items for empty dictionaries in JSON encoding youknowdot Oct 9, 2026 https://github.com/RustPython/RustPython/pull/9018/commits/05e06d0e3aa17d2d5cc3d155e914bd41d6bcc09c
Clear filters https://github.com/RustPython/RustPython/pull/9018/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9018/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9018/files
json.rs https://github.com/RustPython/RustPython/pull/9018/files#diff-178128486470adaa06dc096deddc4f7da63b1af9c0555e93fed81ae66c6e5f5e
stdlib_json.py https://github.com/RustPython/RustPython/pull/9018/files#diff-b1966af22d77553be8111256ab2fed6717a1129f05221bf5cb038a568313b6b7
crates/stdlib/src/json.rshttps://github.com/RustPython/RustPython/pull/9018/files#diff-178128486470adaa06dc096deddc4f7da63b1af9c0555e93fed81ae66c6e5f5e
View file https://github.com/youknowdot/RustPython/blob/05e06d0e3aa17d2d5cc3d155e914bd41d6bcc09c/crates/stdlib/src/json.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9018/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9018/files#diff-178128486470adaa06dc096deddc4f7da63b1af9c0555e93fed81ae66c6e5f5e
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 9, 2026https://github.com/RustPython/RustPython/pull/9018/files#r4229861949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L23-L23https://github.com/RustPython/RustPython/blob/05e06d0e3aa17d2d5cc3d155e914bd41d6bcc09c/AGENTS.md#L23-L23
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9018/files
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 9, 2026https://github.com/RustPython/RustPython/pull/9018/files#r4229861964
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L35-L35https://github.com/RustPython/RustPython/blob/05e06d0e3aa17d2d5cc3d155e914bd41d6bcc09c/AGENTS.md#L35-L35
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9018/files
https://github.com/RustPython/RustPython/pull/9018/files#diff-178128486470adaa06dc096deddc4f7da63b1af9c0555e93fed81ae66c6e5f5e
extra_tests/snippets/stdlib_json.pyhttps://github.com/RustPython/RustPython/pull/9018/files#diff-b1966af22d77553be8111256ab2fed6717a1129f05221bf5cb038a568313b6b7
View file https://github.com/youknowdot/RustPython/blob/05e06d0e3aa17d2d5cc3d155e914bd41d6bcc09c/extra_tests/snippets/stdlib_json.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9018/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9018/files#diff-b1966af22d77553be8111256ab2fed6717a1129f05221bf5cb038a568313b6b7
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 9, 2026https://github.com/RustPython/RustPython/pull/9018/files#r4229861973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L277-L279https://github.com/RustPython/RustPython/blob/05e06d0e3aa17d2d5cc3d155e914bd41d6bcc09c/AGENTS.md#L277-L279
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9018/files
https://github.com/RustPython/RustPython/pull/9018/files#diff-b1966af22d77553be8111256ab2fed6717a1129f05221bf5cb038a568313b6b7
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9018/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.