René's URL Explorer Experiment


Title: Make the PySubclass layout contract unsafe by 1ndahous3 · Pull Request #9012 · RustPython/RustPython · GitHub

Open Graph Title: Make the PySubclass layout contract unsafe by 1ndahous3 · Pull Request #9012 · RustPython/RustPython

X Title: Make the PySubclass layout contract unsafe by 1ndahous3 · Pull Request #9012 · RustPython/RustPython

Description: Summary Make PySubclass an unsafe trait: manual implementations must guarantee a valid base prefix, matching payload offsets, and compatible object alignment for safe base conversions. Preserve automatic implementations for macro-generated subclasses and document the layout guarantees of native exception implementations. Extracted from #8963 as requested in #8963 (comment). The allocation-based cast checks remain in #8963. API changes Manual implementations now require unsafe impl PySubclass. Callers of base conversions and users of generated implementations need no additional unsafe blocks. AI assistance This PR follows our AI policy. Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Safety Subclass relationships now require an explicit unsafe implementation, making the layout and lifetime guarantees required for safe conversions explicit. Built-in class, exception, and struct-sequence subclass implementations have been updated to satisfy the new requirement. Compatibility Custom implementations of the subclassing trait must now be declared unsafe; ordinary implementations will no longer compile.

Open Graph Description: Summary Make PySubclass an unsafe trait: manual implementations must guarantee a valid base prefix, matching payload offsets, and compatible object alignment for safe base conversions. Preserve au...

X Description: Summary Make PySubclass an unsafe trait: manual implementations must guarantee a valid base prefix, matching payload offsets, and compatible object alignment for safe base conversions. Preserve au...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9012

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:904c4d93-7c59-c83a-ed03-184ea7f89c70
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9326:1DC4CC:13B6EAB:1A44CB6:6B01F757
html-safe-nonce88cd0145c4a099502933a212f45967a3dbd377e50473efa8fbae42f030c0fa9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzI2OjFEQzRDQzoxM0I2RUFCOjFBNDRDQjY6NkIwMUY3NTciLCJ2aXNpdG9yX2lkIjoiNjY2OTMwMTIxODQ3MDM5MzY4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0a4a120646e63ce946603060ada9dc9e0cb98404b229b29472fa41efe861146f
hovercard-subject-tagpull_request:4791388873
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9012/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altSummary Make PySubclass an unsafe trait: manual implementations must guarantee a valid base prefix, matching payload offsets, and compatible object alignment for safe base conversions. Preserve au...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9012/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9012%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9012%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9012/files
Reloadhttps://github.com/RustPython/RustPython/pull/9012/files
Reloadhttps://github.com/RustPython/RustPython/pull/9012/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:pysubclass_unsafe_contracthttps://github.com/1ndahous3/RustPython/tree/pysubclass_unsafe_contract
Conversation 2 https://github.com/RustPython/RustPython/pull/9012
Commits 1 https://github.com/RustPython/RustPython/pull/9012/commits
Checks 29 https://github.com/RustPython/RustPython/pull/9012/checks
Files changed https://github.com/RustPython/RustPython/pull/9012/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9012/files
Make the PySubclass layout contract unsafe https://github.com/RustPython/RustPython/pull/9012/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9012/files
988e088 Make the PySubclass layout contract unsafe 1ndahous3 Oct 8, 2026 https://github.com/RustPython/RustPython/pull/9012/commits/988e088acdd0983e5c465d4d54567771b2095403
Clear filters https://github.com/RustPython/RustPython/pull/9012/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9012/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9012/files
pyclass.rs https://github.com/RustPython/RustPython/pull/9012/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
pystructseq.rs https://github.com/RustPython/RustPython/pull/9012/files#diff-cb433ba78f7ed441ec5f2a73f22ab228551a4e378143d42fcb60a2078a26dedd
class.rs https://github.com/RustPython/RustPython/pull/9012/files#diff-ea8866550ea2830f83d804b5bc2a03456c7eaa2308b786b0aa71a984ca25b8fe
exception_group.rs https://github.com/RustPython/RustPython/pull/9012/files#diff-e741d4f5b04ffb507b177ea8becb9bcd88e4ee30e6de17eab3c44878d13c0c81
exceptions.rs https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
crates/derive-impl/src/pyclass.rshttps://github.com/RustPython/RustPython/pull/9012/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
View file https://github.com/1ndahous3/RustPython/blob/988e088acdd0983e5c465d4d54567771b2095403/crates/derive-impl/src/pyclass.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9012/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9012/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9012/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
crates/derive-impl/src/pystructseq.rshttps://github.com/RustPython/RustPython/pull/9012/files#diff-cb433ba78f7ed441ec5f2a73f22ab228551a4e378143d42fcb60a2078a26dedd
View file https://github.com/1ndahous3/RustPython/blob/988e088acdd0983e5c465d4d54567771b2095403/crates/derive-impl/src/pystructseq.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9012/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9012/files#diff-cb433ba78f7ed441ec5f2a73f22ab228551a4e378143d42fcb60a2078a26dedd
https://github.com/RustPython/RustPython/pull/9012/files#diff-cb433ba78f7ed441ec5f2a73f22ab228551a4e378143d42fcb60a2078a26dedd
crates/vm/src/class.rshttps://github.com/RustPython/RustPython/pull/9012/files#diff-ea8866550ea2830f83d804b5bc2a03456c7eaa2308b786b0aa71a984ca25b8fe
View file https://github.com/1ndahous3/RustPython/blob/988e088acdd0983e5c465d4d54567771b2095403/crates/vm/src/class.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9012/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9012/files#diff-ea8866550ea2830f83d804b5bc2a03456c7eaa2308b786b0aa71a984ca25b8fe
https://github.com/RustPython/RustPython/pull/9012/files#diff-ea8866550ea2830f83d804b5bc2a03456c7eaa2308b786b0aa71a984ca25b8fe
crates/vm/src/exception_group.rshttps://github.com/RustPython/RustPython/pull/9012/files#diff-e741d4f5b04ffb507b177ea8becb9bcd88e4ee30e6de17eab3c44878d13c0c81
View file https://github.com/1ndahous3/RustPython/blob/988e088acdd0983e5c465d4d54567771b2095403/crates/vm/src/exception_group.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9012/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9012/files#diff-e741d4f5b04ffb507b177ea8becb9bcd88e4ee30e6de17eab3c44878d13c0c81
https://github.com/RustPython/RustPython/pull/9012/files#diff-e741d4f5b04ffb507b177ea8becb9bcd88e4ee30e6de17eab3c44878d13c0c81
crates/vm/src/exceptions.rshttps://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
View file https://github.com/1ndahous3/RustPython/blob/988e088acdd0983e5c465d4d54567771b2095403/crates/vm/src/exceptions.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9012/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
https://github.com/RustPython/RustPython/pull/9012/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9012/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.