René's URL Explorer Experiment


Title: Infer native calling convention flags from argument metadata by youknowone · Pull Request #9005 · RustPython/RustPython · GitHub

Open Graph Title: Infer native calling convention flags from argument metadata by youknowone · Pull Request #9005 · RustPython/RustPython

X Title: Infer native calling convention flags from argument metadata by youknowone · Pull Request #9005 · RustPython/RustPython

Description: This PR follows our AI policy Summary Native functions now get their calling convention flags (NOARGS, O, FASTCALL, FASTCALL | KEYWORDS) from the FromArgs::PARAMS metadata of each argument. The PyMethodDef constructors compute them. Before this change, the derive macros guessed the flags from Rust type names. This is split out of #8957. That PR rejects unsupported keywords before argument binding, which only works if KEYWORDS is accurate on every PyMethodDef. On main it is not: list.sort(&self, options: SortOptions) is flagged O. sorted is flagged FASTCALL without KEYWORDS. Definitions built without the macros (the __new__ wrapper, vm.new_function, AST.__replace__) have no calling convention at all. Details IntoPyNativeFn::ARGS exposes the binding metadata of each argument. A &self / &Py receiver appears as the $self marker. PyMethodFlags::with_call_convention adds the inferred calling convention unless the flags already contain one. Flags that already have one, such as C-API ml_flags, are kept as they are. With METHOD or CLASS, the first argument is the bound receiver and is not counted. PyMethodDef::new_const, PyMethodDef::new_raw_const and Context::new_method_def apply it. Raw functions get FASTCALL | KEYWORDS. The derive macros pass only binding flags. The string-based infer_native_call_flags is removed. Behavior Nothing visible from Python changes. On main, these flags are read only to pick a CALL specialization in frame.rs, and specialized calls still bind arguments through vectorcall. What changes is which specialization gets picked: Definitions built without the macros now carry flags, so they can be specialized. derive(FromArgs) struct arguments get accurate flags instead of being counted as one positional argument. API: PyMethodDef::new_const takes a generic F: IntoPyNativeFn instead of impl IntoPyNativeFn. IntoPyNativeFn gains an associated ARGS const with a default. Testing cargo test --workspace --exclude rustpython_wasm --exclude rustpython-venvlauncher --exclude rustpython-capi cargo test from crates/capi Workspace and C-API clippy, cargo fmt --all --check Snippets: syntax_function_args.py, builtin_type.py Release -m test: test_extcall test_call test_builtin test_list test_ast test_descr test_int test_inspect test_datetime test_csv test_enum test_types test_functools test_dataclasses test_typing test_copy test_dict test_str test_os test_io (20 modules, all passed) 🤖 Generated with Claude Code Summary by CodeRabbit Bug Fixes Native methods and module functions now use calling conventions based on their argument signatures, improving compatibility for functions with positional, keyword, optional, and variadic arguments. Bound methods and class methods now account for their receiver when determining how calls are handled.

Open Graph Description: This PR follows our AI policy Summary Native functions now get their calling convention flags (NOARGS, O, FASTCALL, FASTCALL | KEYWORDS) from the FromArgs::PARAMS metadata of each argument. The Py...

X Description: This PR follows our AI policy Summary Native functions now get their calling convention flags (NOARGS, O, FASTCALL, FASTCALL | KEYWORDS) from the FromArgs::PARAMS metadata of each argument. The Py...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9005

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aa783078-86d5-c03c-cb92-ed36df4ac3cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC652:3B07B3:3681E2:44AB6B:6B01FA64
html-safe-nonce43012ef8f84d209506cab3f334843b44fb729c63870ab35bc494dcf85389c9f0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjUyOjNCMDdCMzozNjgxRTI6NDRBQjZCOjZCMDFGQTY0IiwidmlzaXRvcl9pZCI6IjczMDA0MzY2NDY3NTM4NjAxOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac775f45ca34f9e789a838a9f1bf79c8afd02d2ba4144e59f44af877c5c12be8c0
hovercard-subject-tagpull_request:4782233825
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9005/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altThis PR follows our AI policy Summary Native functions now get their calling convention flags (NOARGS, O, FASTCALL, FASTCALL | KEYWORDS) from the FromArgs::PARAMS metadata of each argument. The Py...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9005/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9005%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9005%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9005/files
Reloadhttps://github.com/RustPython/RustPython/pull/9005/files
Reloadhttps://github.com/RustPython/RustPython/pull/9005/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:native-call-conventionhttps://github.com/youknowone/RustPython/tree/native-call-convention
Conversation 2 https://github.com/RustPython/RustPython/pull/9005
Commits 1 https://github.com/RustPython/RustPython/pull/9005/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9005/checks
Files changed https://github.com/RustPython/RustPython/pull/9005/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9005/files
Infer native calling convention flags from argument metadata https://github.com/RustPython/RustPython/pull/9005/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9005/files
823ca0c Infer native calling convention flags from argument metadata youknowone Oct 8, 2026 https://github.com/RustPython/RustPython/pull/9005/commits/823ca0cbec00ad191e0b5b89faa013bb3f2703d6
Clear filters https://github.com/RustPython/RustPython/pull/9005/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9005/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9005/files
pyclass.rs https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
pymodule.rs https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
util.rs https://github.com/RustPython/RustPython/pull/9005/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
builtin.rs https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
method.rs https://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
signature.rs https://github.com/RustPython/RustPython/pull/9005/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
context.rs https://github.com/RustPython/RustPython/pull/9005/files#diff-266ab6550d81a4d367e5ef4973281aecf61c7abb46760195fc4ad6064bca0791
crates/derive-impl/src/pyclass.rshttps://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
View file https://github.com/youknowone/RustPython/blob/823ca0cbec00ad191e0b5b89faa013bb3f2703d6/crates/derive-impl/src/pyclass.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9005/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/9005/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
crates/derive-impl/src/pymodule.rshttps://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
View file https://github.com/youknowone/RustPython/blob/823ca0cbec00ad191e0b5b89faa013bb3f2703d6/crates/derive-impl/src/pymodule.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9005/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
https://github.com/RustPython/RustPython/pull/9005/files#diff-bd1b19a26ea802742bdb1006a08982fb26404140e1dd0b5162271a6646258d39
crates/derive-impl/src/util.rshttps://github.com/RustPython/RustPython/pull/9005/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
View file https://github.com/youknowone/RustPython/blob/823ca0cbec00ad191e0b5b89faa013bb3f2703d6/crates/derive-impl/src/util.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9005/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9005/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
crates/vm/src/function/builtin.rshttps://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
View file https://github.com/youknowone/RustPython/blob/823ca0cbec00ad191e0b5b89faa013bb3f2703d6/crates/vm/src/function/builtin.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9005/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
https://github.com/RustPython/RustPython/pull/9005/files#diff-6c24b946ac8e941c9ff035e11a371d071bb4e3cfccaab95095060bd841880f9b
crates/vm/src/function/method.rshttps://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
View file https://github.com/youknowone/RustPython/blob/823ca0cbec00ad191e0b5b89faa013bb3f2703d6/crates/vm/src/function/method.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9005/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
https://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
https://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
https://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
https://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
https://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
https://github.com/RustPython/RustPython/pull/9005/files#diff-31faea07586d31264db50391d88bd13f1e0b25cd5ff8acde46dc44f1d70e42fa
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9005/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9005/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.