René's URL Explorer Experiment


Title: Give os.chmod a valid `__text_signature__` and keyword arguments by leehanjeong · Pull Request #8968 · RustPython/RustPython · GitHub

Open Graph Title: Give os.chmod a valid `__text_signature__` and keyword arguments by leehanjeong · Pull Request #8968 · RustPython/RustPython

X Title: Give os.chmod a valid `__text_signature__` and keyword arguments by leehanjeong · Pull Request #8968 · RustPython/RustPython

Description: Closes #8383 One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary os.chmod was the last native function whose __text_signature__ was not valid Python. It also rejected keyword arguments that CPython accepts. before ($module, path, *, dir_fd=None, mode, /, follow_symlinks=True) after ($module, /, path, mode, *, dir_fd=None, follow_symlinks=(os.name != 'nt')) The Rust arguments put the keyword-only dir_fd between path and mode. Since #8807 renders each argument's kind, * came out before mode and / after it. The same order made path and mode positional-only, so os.chmod(path="f", mode=0o644) raised TypeError. Changes posix.chmod takes a ChmodArgs struct in CPython's order, as nt.chmod already does. path and mode are positional-or-keyword. The signature writer asserts that / is not emitted after *, *args or **kwargs. Signatures are composed in a const context, so a wrong argument order fails the build. builtin_signature.py checks os.chmod. Notes whats_left.py --signature does not change. CPython's own os.chmod signature is unparsable (its default is an expression), so both sides record the same ValueError text. inspect.signature(os.chmod) still raises, as in CPython. Assisted-by: Claude Code:claude-opus-5 Summary by CodeRabbit Bug Fixes os.chmod now uses the platform-appropriate default for follow_symlinks, improving consistency across operating systems. On platforms that support it, os.chmod correctly applies the requested symlink-following behavior.

Open Graph Description: Closes #8383 One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary os.chmod was the last native function whose __text_s...

X Description: Closes #8383 One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary os.chmod was the last native function whose __text_s...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8968

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:16ec45fc-4303-570a-08c5-290091f8dce5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA47C:1F2F:1975956:21D104A:6B020251
html-safe-nonce1dd9b3f52562558a89262e9e2c3094f8947e99fe91185af76da53bf80ccf7774
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDdDOjFGMkY6MTk3NTk1NjoyMUQxMDRBOjZCMDIwMjUxIiwidmlzaXRvcl9pZCI6IjUyOTQxMTM5ODgwNjQ0NDUwMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2ba1a1ea2bc91485d675533aa96865aadb18bdc465cd1afb9206d9cc420013e4
hovercard-subject-tagpull_request:4744808908
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8968/files
twitter:imagehttps://avatars.githubusercontent.com/u/54920378?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/54920378?s=400&v=4
og:image:altCloses #8383 One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary os.chmod was the last native function whose __text_s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8968/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8968%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8968%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8968/files
Reloadhttps://github.com/RustPython/RustPython/pull/8968/files
Reloadhttps://github.com/RustPython/RustPython/pull/8968/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
leehanjeong:8383-chmod-signaturehttps://github.com/leehanjeong/RustPython/tree/8383-chmod-signature
Conversation 8 https://github.com/RustPython/RustPython/pull/8968
Commits 2 https://github.com/RustPython/RustPython/pull/8968/commits
Checks 30 https://github.com/RustPython/RustPython/pull/8968/checks
Files changed https://github.com/RustPython/RustPython/pull/8968/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8968/files
Give os.chmod a valid __text_signature__ and keyword arguments https://github.com/RustPython/RustPython/pull/8968/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/8968/files
1bf3c17 Order chmod's arguments the way CPython declares them leehanjeong Oct 5, 2026 https://github.com/RustPython/RustPython/pull/8968/commits/1bf3c17b13d589eea6b59cfc6843f893b9df7af6
465e8dc Reject a text signature that puts `/` after `*` or `**` leehanjeong Oct 5, 2026 https://github.com/RustPython/RustPython/pull/8968/commits/465e8dc0fc2b93f01d933f8eb3dd51a83ff7b955
Clear filters https://github.com/RustPython/RustPython/pull/8968/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8968/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8968/files
signature.rs https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
posix.rs https://github.com/RustPython/RustPython/pull/8968/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
builtin_signature.py https://github.com/RustPython/RustPython/pull/8968/files#diff-10345555e7703ee171a268bc4c9e034fe6c4065467dd03018f308e7cdc29361b
crates/vm/src/function/signature.rshttps://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
View file https://github.com/leehanjeong/RustPython/blob/465e8dc0fc2b93f01d933f8eb3dd51a83ff7b955/crates/vm/src/function/signature.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8968/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
https://github.com/RustPython/RustPython/pull/8968/files#diff-d8d33ac439d83ede8760de2d14f5bc298f336c809ffeeaece6be77fe6fd5865c
crates/vm/src/stdlib/posix.rshttps://github.com/RustPython/RustPython/pull/8968/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
View file https://github.com/leehanjeong/RustPython/blob/465e8dc0fc2b93f01d933f8eb3dd51a83ff7b955/crates/vm/src/stdlib/posix.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8968/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8968/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
https://github.com/RustPython/RustPython/pull/8968/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
https://github.com/RustPython/RustPython/pull/8968/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
https://github.com/RustPython/RustPython/pull/8968/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
https://github.com/RustPython/RustPython/pull/8968/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
youknowonehttps://github.com/youknowone
Oct 5, 2026https://github.com/RustPython/RustPython/pull/8968/files#r4183962725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8968/files
leehanjeonghttps://github.com/leehanjeong
Oct 5, 2026https://github.com/RustPython/RustPython/pull/8968/files#r4184343837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8968/files
youknowonehttps://github.com/youknowone
Oct 5, 2026https://github.com/RustPython/RustPython/pull/8968/files#r4185586647
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8968/files
https://github.com/RustPython/RustPython/pull/8968/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
extra_tests/snippets/builtin_signature.pyhttps://github.com/RustPython/RustPython/pull/8968/files#diff-10345555e7703ee171a268bc4c9e034fe6c4065467dd03018f308e7cdc29361b
View file https://github.com/leehanjeong/RustPython/blob/465e8dc0fc2b93f01d933f8eb3dd51a83ff7b955/extra_tests/snippets/builtin_signature.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8968/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8968/files#diff-10345555e7703ee171a268bc4c9e034fe6c4065467dd03018f308e7cdc29361b
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8968/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.