René's URL Explorer Experiment


Title: zlib: return output inflate still holds after the last input byte by JMLX42 · Pull Request #8909 · RustPython/RustPython · GitHub

Open Graph Title: zlib: return output inflate still holds after the last input byte by JMLX42 · Pull Request #8909 · RustPython/RustPython

X Title: zlib: return output inflate still holds after the last input byte by JMLX42 · Pull Request #8909 · RustPython/RustPython

Description: Fixes #8907. decompress_chunks (crates/common/src/compression/zlib.rs) returned before it called inflate when the input was empty, and returned once the input was consumed even when the output buffer was full. Raw deflate has no trailer, so inflate can consume the last input byte and still hold output. Decompress.decompress(b"", n) and Decompress.flush() then returned nothing, and zlib.decompress(raw, -15, bufsize) with a small bufsize raised "incomplete or truncated stream". This mirrors CPython's zlibmodule.c: inflate runs for empty input, and runs again while it fills the output buffer. A stream with no pending output answers Z_BUF_ERROR, so an empty input or a flush() before any compressed data still leaves eof false (empty_input_does_not_finish_a_stream still passes; empty_flush_does_not_finish_a_stream is new). After a stream error, decompress(b"") now raises again, as CPython does. Tests New unit tests empty_input_returns_pending_output, flush_returns_pending_output, small_bufsize_returns_pending_output, empty_flush_does_not_finish_a_stream (the first three fail before the change). New cases in extra_tests/snippets/stdlib_zlib.py with the reproducer from #8907; they pass on RustPython and on CPython 3.13.5. rustpython-common: 135 passed; workspace: 1337 passed, 0 failed. test_zlib + test_gzip: 151 run, 4 skipped, 0 failed, before and after. test_tarfile + test_zipfile + test_shutil: 1360 run, 197 skipped, before and after. cargo fmt --check and clippy on rustpython-common are clean. #8908 (#8906) edits the same file and also appends tests at the end of mod tests; whichever merges second needs a trivial rebase. AI assistance This change was written with Claude Code (commit trailer Assisted-by: Claude Code:claude-opus-5-5). It is opened as a draft until a human has verified it, per the AI policy. 🤖 Written by Claude Code (2.1.283) using model claude-opus-5-5 Summary by CodeRabbit Bug Fixes Fixed decompression with small output buffers so remaining data can be retrieved by calling decompress again with empty input or by using flush(). Corrected stream completion reporting: pending output is no longer treated as complete, and empty input does not prematurely finish an incomplete stream. Fixed one-shot raw decompression with small buffer sizes, ensuring the full decompressed result is returned even when output is produced in small portions.

Open Graph Description: Fixes #8907. decompress_chunks (crates/common/src/compression/zlib.rs) returned before it called inflate when the input was empty, and returned once the input was consumed even when the output buff...

X Description: Fixes #8907. decompress_chunks (crates/common/src/compression/zlib.rs) returned before it called inflate when the input was empty, and returned once the input was consumed even when the output buff...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8909

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:faf9becc-ca28-10ab-0918-f06d99a1128b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAE4:269AD9:34DEDD2:4690E09:6B020171
html-safe-nonce2ece86247ebbf3cf8d319355373e698be4404fb2c75820430ed0bc7c50ec587d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUU0OjI2OUFEOTozNERFREQyOjQ2OTBFMDk6NkIwMjAxNzEiLCJ2aXNpdG9yX2lkIjoiMTYzNzQ3NzI2MDAxNTU2NzIxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0517dbec72192fcd930102e84a50eac38b3fd96aad88ab5e901ae51bab504f3c
hovercard-subject-tagpull_request:4679657052
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8909/files
twitter:imagehttps://avatars.githubusercontent.com/u/998703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/998703?s=400&v=4
og:image:altFixes #8907. decompress_chunks (crates/common/src/compression/zlib.rs) returned before it called inflate when the input was empty, and returned once the input was consumed even when the output buff...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8909/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8909%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8909%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8909/files
Reloadhttps://github.com/RustPython/RustPython/pull/8909/files
Reloadhttps://github.com/RustPython/RustPython/pull/8909/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
JMLX42:fix-zlib-empty-input-drainhttps://github.com/JMLX42/RustPython/tree/fix-zlib-empty-input-drain
Conversation 14 https://github.com/RustPython/RustPython/pull/8909
Commits 4 https://github.com/RustPython/RustPython/pull/8909/commits
Checks 27 https://github.com/RustPython/RustPython/pull/8909/checks
Files changed https://github.com/RustPython/RustPython/pull/8909/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8909/files
zlib: return output inflate still holds after the last input byte https://github.com/RustPython/RustPython/pull/8909/files#top
Show all changes 4 commits https://github.com/RustPython/RustPython/pull/8909/files
8dbcb31 zlib: return output inflate still holds after the last input byte JMLX42 Sep 29, 2026 https://github.com/RustPython/RustPython/pull/8909/commits/8dbcb31e19ca429283dd24dc81a83a07afca803c
bb02418 zlib: fold the full-buffer case into the loop's exit condition JMLX42 Sep 29, 2026 https://github.com/RustPython/RustPython/pull/8909/commits/bb02418fd5a5efa02783f2f0c152c8e70c6ae817
5f763df zlib: drop the comment that stood in for the removed early return JMLX42 Sep 29, 2026 https://github.com/RustPython/RustPython/pull/8909/commits/5f763df9caadb222cc339f9f57b0d8e5ca9923ff
46e78fe Merge branch 'RustPython:main' into fix-zlib-empty-input-drain JMLX42 Nov 6, 2026 https://github.com/RustPython/RustPython/pull/8909/commits/46e78fe95d93f96595ae2f3d42287a0e6e460222
Clear filters https://github.com/RustPython/RustPython/pull/8909/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8909/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8909/files
zlib.rs https://github.com/RustPython/RustPython/pull/8909/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
stdlib_zlib.py https://github.com/RustPython/RustPython/pull/8909/files#diff-8ccf22376edabeed26e705fb7e86caabb967d5019cb284e0b76bbda06e02e5ed
crates/common/src/compression/zlib.rshttps://github.com/RustPython/RustPython/pull/8909/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
View file https://github.com/JMLX42/RustPython/blob/46e78fe95d93f96595ae2f3d42287a0e6e460222/crates/common/src/compression/zlib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8909/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8909/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
https://github.com/RustPython/RustPython/pull/8909/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
https://github.com/RustPython/RustPython/pull/8909/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
https://github.com/RustPython/RustPython/pull/8909/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
extra_tests/snippets/stdlib_zlib.pyhttps://github.com/RustPython/RustPython/pull/8909/files#diff-8ccf22376edabeed26e705fb7e86caabb967d5019cb284e0b76bbda06e02e5ed
View file https://github.com/JMLX42/RustPython/blob/46e78fe95d93f96595ae2f3d42287a0e6e460222/extra_tests/snippets/stdlib_zlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8909/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8909/files#diff-8ccf22376edabeed26e705fb7e86caabb967d5019cb284e0b76bbda06e02e5ed
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8909/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.