René's URL Explorer Experiment


Title: zlib: clear unconsumed_tail when a bounded decompress reaches stream end by JMLX42 · Pull Request #8908 · RustPython/RustPython · GitHub

Open Graph Title: zlib: clear unconsumed_tail when a bounded decompress reaches stream end by JMLX42 · Pull Request #8908 · RustPython/RustPython

X Title: zlib: clear unconsumed_tail when a bounded decompress reaches stream end by JMLX42 · Pull Request #8908 · RustPython/RustPython

Description: Fixes #8906. When a max_length-bounded Decompress.decompress() call reaches the end of the stream, unconsumed_tail kept the previous call's tail, including input the call had already consumed, and a later flush() moved those stale bytes into unused_data. Decompressor::decompress_inner (crates/common/src/compression/zlib.rs) now empties unconsumed_tail at end of stream and puts the bytes after the stream in unused_data, as CPython's save_unconsumed_input() does since gh-158169 (python/cpython commit 8122ff4818). CPython releases before that change report the bytes after the stream in unconsumed_tail, so the new snippet case accepts either value when it runs under CPython. Tests New unit test stream_end_clears_unconsumed_tail (fails before the change: the tail held 29 stale bytes ending in NEXT). New case in extra_tests/snippets/stdlib_zlib.py with the reproducer from #8906. cargo test -p rustpython-common --features zlib: 16 passed. test_zlib under RustPython: 76 run, 4 skipped, 0 failed, before and after; no expectedFailure marker changed. cargo fmt --check, clippy on rustpython-common with -Dwarnings, ruff and cspell: clean. AI assistance This change was written with Claude Code (commit trailer Assisted-by: Claude Code:claude-opus-5-5). It is opened as a draft until a human has verified it, per the AI policy. 🤖 Written by Claude Code (2.1.283) using model claude-opus-5-5 Summary by CodeRabbit Bug Fixes Fixed zlib decompression when a stream ends with trailing data. Trailing bytes are now reported as unused data, and the unconsumed input is cleared at stream end. Calling flush() preserves the reported trailing data and input state, keeping decompression results consistent after bounded reads.

Open Graph Description: Fixes #8906. When a max_length-bounded Decompress.decompress() call reaches the end of the stream, unconsumed_tail kept the previous call's tail, including input the call had already consumed, ...

X Description: Fixes #8906. When a max_length-bounded Decompress.decompress() call reaches the end of the stream, unconsumed_tail kept the previous call's tail, including input the call had already consum...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8908

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7c220a84-8ac8-ae03-714f-f5ad69b27121
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0EE:2A98A:2A819F:35A019:6B020736
html-safe-nonce155c4347232b0f5ca2b3d4e74e591fd3bd29807f1176b92367d8613c55ed7135
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEVFOjJBOThBOjJBODE5RjozNUEwMTk6NkIwMjA3MzYiLCJ2aXNpdG9yX2lkIjoiNDkyODYzODQxMzYxODU2MzEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf79bacbe37eec5163f89deba54129345b855fb491c8415e18241ed7777a3b76b
hovercard-subject-tagpull_request:4679635419
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8908/files
twitter:imagehttps://avatars.githubusercontent.com/u/998703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/998703?s=400&v=4
og:image:altFixes #8906. When a max_length-bounded Decompress.decompress() call reaches the end of the stream, unconsumed_tail kept the previous call's tail, including input the call had already consumed, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8908/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8908%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8908%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8908/files
Reloadhttps://github.com/RustPython/RustPython/pull/8908/files
Reloadhttps://github.com/RustPython/RustPython/pull/8908/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
JMLX42:fix-zlib-stale-unconsumed-tailhttps://github.com/JMLX42/RustPython/tree/fix-zlib-stale-unconsumed-tail
Conversation 6 https://github.com/RustPython/RustPython/pull/8908
Commits 3 https://github.com/RustPython/RustPython/pull/8908/commits
Checks 28 https://github.com/RustPython/RustPython/pull/8908/checks
Files changed https://github.com/RustPython/RustPython/pull/8908/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8908/files
zlib: clear unconsumed_tail when a bounded decompress reaches stream end https://github.com/RustPython/RustPython/pull/8908/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/8908/files
b05099f zlib: clear unconsumed_tail when a bounded decompress reaches stream end JMLX42 Sep 29, 2026 https://github.com/RustPython/RustPython/pull/8908/commits/b05099f1a19fd2f8d26150089dbf386a71d017e8
99c0071 zlib: bind the unconsumed input with an if expression JMLX42 Sep 29, 2026 https://github.com/RustPython/RustPython/pull/8908/commits/99c0071c66947416626bf32bd0d1528e90fcfbc6
6408380 zlib: accept both valid tails in the snippet on every implementation JMLX42 Sep 29, 2026 https://github.com/RustPython/RustPython/pull/8908/commits/640838050a296ee1d2f72ddb28055f9e1a0b870c
Clear filters https://github.com/RustPython/RustPython/pull/8908/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8908/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8908/files
zlib.rs https://github.com/RustPython/RustPython/pull/8908/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
stdlib_zlib.py https://github.com/RustPython/RustPython/pull/8908/files#diff-8ccf22376edabeed26e705fb7e86caabb967d5019cb284e0b76bbda06e02e5ed
crates/common/src/compression/zlib.rshttps://github.com/RustPython/RustPython/pull/8908/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
View file https://github.com/JMLX42/RustPython/blob/640838050a296ee1d2f72ddb28055f9e1a0b870c/crates/common/src/compression/zlib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8908/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8908/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
https://github.com/RustPython/RustPython/pull/8908/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
https://github.com/RustPython/RustPython/pull/8908/files#diff-5e4c07ee6dfbb37b2ec32a74d3404f6974cce0ac99fee9978c773c323bc12df4
extra_tests/snippets/stdlib_zlib.pyhttps://github.com/RustPython/RustPython/pull/8908/files#diff-8ccf22376edabeed26e705fb7e86caabb967d5019cb284e0b76bbda06e02e5ed
View file https://github.com/JMLX42/RustPython/blob/640838050a296ee1d2f72ddb28055f9e1a0b870c/extra_tests/snippets/stdlib_zlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8908/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8908/files#diff-8ccf22376edabeed26e705fb7e86caabb967d5019cb284e0b76bbda06e02e5ed
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8908/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.