René's URL Explorer Experiment


Title: Validate native subclass object layouts by 1ndahous3 · Pull Request #8905 · RustPython/RustPython · GitHub

Open Graph Title: Validate native subclass object layouts by 1ndahous3 · Pull Request #8905 · RustPython/RustPython

X Title: Validate native subclass object layouts by 1ndahous3 · Pull Request #8905 · RustPython/RustPython

Description: Summary Extend #7663's checks for #[pyclass(base = ...)] to reject incompatible payload offsets and insufficient object alignment at compile time. Reject enums with a native base. Align dict and the I/O base payloads to eight bytes so their native subclasses satisfy the checks on wasm32, including the OrderedDict.get() failure reported in #8896, without boxing their storage. Include alignment padding before the payload in native type BASICSIZE. AI assistance Written with Codex (GPT-6), reviewed by a human before submission. This PR follows our AI policy. Summary by CodeRabbit Bug Fixes Corrected native subclass layout and alignment checks, improving compatibility with base classes and preventing invalid subclass declarations. Updated object size calculations to account for payload layout and alignment, including on 32-bit targets. Documentation Clarified layout requirements for native subclasses and how they are checked. Tests Added coverage for aligned payload sizes and inherited and subclass-specific getters.

Open Graph Description: Summary Extend #7663's checks for #[pyclass(base = ...)] to reject incompatible payload offsets and insufficient object alignment at compile time. Reject enums with a native base. Align dict a...

X Description: Summary Extend #7663's checks for #[pyclass(base = ...)] to reject incompatible payload offsets and insufficient object alignment at compile time. Reject enums with a native base. Align di...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8905

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:edb914e6-a1bc-c4ab-e852-2280c51f6db7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC72:213839:3C43296:4CF1921:6B01FE24
html-safe-nonce789dd6e7e21a5134226cfd5db70cd1377b40da5e15a0b0559349a05d814733d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzcyOjIxMzgzOTozQzQzMjk2OjRDRjE5MjE6NkIwMUZFMjQiLCJ2aXNpdG9yX2lkIjoiNzE2MDIzNTUxMzkxNDQ1NzYzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac75db5543eb67b5677841d80f4a26916bd892c5bc999a239220c7d6096e2596fa
hovercard-subject-tagpull_request:4679114169
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8905/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altSummary Extend #7663's checks for #[pyclass(base = ...)] to reject incompatible payload offsets and insufficient object alignment at compile time. Reject enums with a native base. Align dict a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8905/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8905%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8905%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8905/files
Reloadhttps://github.com/RustPython/RustPython/pull/8905/files
Reloadhttps://github.com/RustPython/RustPython/pull/8905/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:pyclass_payload_layouthttps://github.com/1ndahous3/RustPython/tree/pyclass_payload_layout
Conversation 4 https://github.com/RustPython/RustPython/pull/8905
Commits 1 https://github.com/RustPython/RustPython/pull/8905/commits
Checks 30 https://github.com/RustPython/RustPython/pull/8905/checks
Files changed https://github.com/RustPython/RustPython/pull/8905/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8905/files
Validate native subclass object layouts https://github.com/RustPython/RustPython/pull/8905/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8905/files
09fbaad Validate native subclass object layouts 1ndahous3 Sep 29, 2026 https://github.com/RustPython/RustPython/pull/8905/commits/09fbaadccc291d5d576eb0441de41a83a3ceb41d
Clear filters https://github.com/RustPython/RustPython/pull/8905/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8905/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8905/files
pyclass.rs https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
lib.rs https://github.com/RustPython/RustPython/pull/8905/files#diff-20d9586a7e5e7a1ffb491abaefbd0c7a0c23bbea9524c66d06c8cc65c00ad539
dict.rs https://github.com/RustPython/RustPython/pull/8905/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
core.rs https://github.com/RustPython/RustPython/pull/8905/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
payload.rs https://github.com/RustPython/RustPython/pull/8905/files#diff-810ea11cfb8461075d5d8f586b7bc9fb28d85695bdaf74cde28129c5e1e7e9a3
_io.rs https://github.com/RustPython/RustPython/pull/8905/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
crates/derive-impl/src/pyclass.rshttps://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
View file https://github.com/1ndahous3/RustPython/blob/09fbaadccc291d5d576eb0441de41a83a3ceb41d/crates/derive-impl/src/pyclass.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8905/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8905/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
crates/derive/src/lib.rshttps://github.com/RustPython/RustPython/pull/8905/files#diff-20d9586a7e5e7a1ffb491abaefbd0c7a0c23bbea9524c66d06c8cc65c00ad539
View file https://github.com/1ndahous3/RustPython/blob/09fbaadccc291d5d576eb0441de41a83a3ceb41d/crates/derive/src/lib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8905/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8905/files#diff-20d9586a7e5e7a1ffb491abaefbd0c7a0c23bbea9524c66d06c8cc65c00ad539
https://github.com/RustPython/RustPython/pull/8905/files#diff-20d9586a7e5e7a1ffb491abaefbd0c7a0c23bbea9524c66d06c8cc65c00ad539
crates/vm/src/builtins/dict.rshttps://github.com/RustPython/RustPython/pull/8905/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
View file https://github.com/1ndahous3/RustPython/blob/09fbaadccc291d5d576eb0441de41a83a3ceb41d/crates/vm/src/builtins/dict.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8905/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8905/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/8905/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
crates/vm/src/object/core.rshttps://github.com/RustPython/RustPython/pull/8905/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
View file https://github.com/1ndahous3/RustPython/blob/09fbaadccc291d5d576eb0441de41a83a3ceb41d/crates/vm/src/object/core.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8905/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8905/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/8905/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
crates/vm/src/object/payload.rshttps://github.com/RustPython/RustPython/pull/8905/files#diff-810ea11cfb8461075d5d8f586b7bc9fb28d85695bdaf74cde28129c5e1e7e9a3
View file https://github.com/1ndahous3/RustPython/blob/09fbaadccc291d5d576eb0441de41a83a3ceb41d/crates/vm/src/object/payload.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8905/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8905/files#diff-810ea11cfb8461075d5d8f586b7bc9fb28d85695bdaf74cde28129c5e1e7e9a3
https://github.com/RustPython/RustPython/pull/8905/files#diff-810ea11cfb8461075d5d8f586b7bc9fb28d85695bdaf74cde28129c5e1e7e9a3
crates/vm/src/stdlib/_io.rshttps://github.com/RustPython/RustPython/pull/8905/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
View file https://github.com/1ndahous3/RustPython/blob/09fbaadccc291d5d576eb0441de41a83a3ceb41d/crates/vm/src/stdlib/_io.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8905/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8905/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
https://github.com/RustPython/RustPython/pull/8905/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8905/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.