René's URL Explorer Experiment


Title: fix: OrderedDict.get() crashes on wasi by jiwahn · Pull Request #8896 · RustPython/RustPython · GitHub

Open Graph Title: fix: OrderedDict.get() crashes on wasi by jiwahn · Pull Request #8896 · RustPython/RustPython

X Title: fix: OrderedDict.get() crashes on wasi by jiwahn · Pull Request #8896 · RustPython/RustPython

Description: Closes #xxxx One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary Problem: On wasi, OrderedDict.get() crashes with an out of bounds memory access Cause: OrderedDict uses by_hash: HashMap which requires 8 byte align Fix: Wrap by_hash in Box> to bring align back down to 4 bytes Assisted-by: Claude Code:claude-sonnet-5 Below is the reproducer of this issue ╰─$ cd ~/RustPython BIN=bin_path wasmer run --volume "$(pwd)" "$BIN" -- -c " from collections import OrderedDict o = OrderedDict() print(o.get('x', 0)) o['x'] = 1 print(o.get('x', 0)) " RuntimeError: out of bounds memory access at ([8872]:0x4f516a) at ([8870]:0x4f4ea5) at ([12320]:0x697621) at ([12321]:0x697727) at ([8362]:0x4c57c2) at ([8976]:0x4fd738) at ([9499]:0x56dd74) at ([9436]:0x529a49) at ([8975]:0x4fd506) at ([3174]:0x1e64f5) at ([3141]:0x1e29e7) at ([3121]:0x1deb15) at ([83]:0xea20) at ([34]:0xac6c) at ([33]:0xa0aa) at ([86]:0x113ec) at ([32]:0xa086) Summary by CodeRabbit Bug Fixes Reported memory sizes for ordered dictionaries now account more accurately for their allocated storage. This improves the accuracy of size information without changing how ordered dictionaries behave or how their contents are accessed.

Open Graph Description: Closes #xxxx One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary Problem: On wasi, OrderedDict.get() crashes with ...

X Description: Closes #xxxx One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary Problem: On wasi, OrderedDict.get() crashes with ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8896

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:75f47ea3-9c9d-6f75-a83a-6764faa1e995
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB54:3A8E64:17EA253:1FA5AB5:6B020D5E
html-safe-nonce9f3b86a0d26fb984043d37a148cea0fde090293a04fed8efe81bd95c25a12a90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjU0OjNBOEU2NDoxN0VBMjUzOjFGQTVBQjU6NkIwMjBENUUiLCJ2aXNpdG9yX2lkIjoiMzc2ODA5OTA5ODMzOTcwODI1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5cddab11f559bef6f68be20bcb2760dcf3d6a57b400f051b3c2b2a062c580dc0
hovercard-subject-tagpull_request:4671765470
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8896/files
twitter:imagehttps://avatars.githubusercontent.com/u/64245628?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/64245628?s=400&v=4
og:image:altCloses #xxxx One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary Problem: On wasi, OrderedDict.get() crashes with ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8896/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8896%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8896%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8896/files
Reloadhttps://github.com/RustPython/RustPython/pull/8896/files
Reloadhttps://github.com/RustPython/RustPython/pull/8896/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
jiwahnhttps://github.com/jiwahn
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jiwahn:wasi-ordereddict-alignhttps://github.com/jiwahn/RustPython/tree/wasi-ordereddict-align
Conversation 9 https://github.com/RustPython/RustPython/pull/8896
Commits 1 https://github.com/RustPython/RustPython/pull/8896/commits
Checks 19 https://github.com/RustPython/RustPython/pull/8896/checks
Files changed https://github.com/RustPython/RustPython/pull/8896/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
fix: OrderedDict.get() crashes on wasi https://github.com/RustPython/RustPython/pull/8896/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8896/files
03d090e fix: OrderedDict.get() crashes on wasi jiwahn Sep 29, 2026 https://github.com/RustPython/RustPython/pull/8896/commits/03d090eee6ecb9ced290ef2652d75ab5f9542327
Clear filters https://github.com/RustPython/RustPython/pull/8896/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
crates/vm/src/stdlib/_collections/ordered_dict.rshttps://github.com/RustPython/RustPython/pull/8896/files#diff-98b3ee5c127843018bf43e7c908e9174f2239f5c7f4c0eaab0f205db47a865da
View file https://github.com/jiwahn/RustPython/blob/03d090eee6ecb9ced290ef2652d75ab5f9542327/crates/vm/src/stdlib/_collections/ordered_dict.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8896/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8896/files#diff-98b3ee5c127843018bf43e7c908e9174f2239f5c7f4c0eaab0f205db47a865da
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
youknowonehttps://github.com/youknowone
Sep 29, 2026https://github.com/RustPython/RustPython/pull/8896/files#r4129146674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
jiwahnhttps://github.com/jiwahn
Sep 29, 2026https://github.com/RustPython/RustPython/pull/8896/files#r4129244607
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
youknowonehttps://github.com/youknowone
Sep 29, 2026https://github.com/RustPython/RustPython/pull/8896/files#r4133109775
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
1ndahous3https://github.com/1ndahous3
Sep 29, 2026https://github.com/RustPython/RustPython/pull/8896/files#r4135212615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8905https://github.com/RustPython/RustPython/pull/8905
#7663https://github.com/RustPython/RustPython/pull/7663
#7663https://github.com/RustPython/RustPython/pull/7663
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
jiwahnhttps://github.com/jiwahn
Sep 29, 2026https://github.com/RustPython/RustPython/pull/8896/files#r4135705205
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8905https://github.com/RustPython/RustPython/pull/8905
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
https://github.com/RustPython/RustPython/pull/8896/files#diff-98b3ee5c127843018bf43e7c908e9174f2239f5c7f4c0eaab0f205db47a865da
https://github.com/RustPython/RustPython/pull/8896/files#diff-98b3ee5c127843018bf43e7c908e9174f2239f5c7f4c0eaab0f205db47a865da
https://github.com/RustPython/RustPython/pull/8896/files#diff-98b3ee5c127843018bf43e7c908e9174f2239f5c7f4c0eaab0f205db47a865da
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8896/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.