René's URL Explorer Experiment


Title: Fix 32-bit member layout assertions and address member descriptor review by youknowone · Pull Request #8882 · RustPython/RustPython · GitHub

Open Graph Title: Fix 32-bit member layout assertions and address member descriptor review by youknowone · Pull Request #8882 · RustPython/RustPython

X Title: Fix 32-bit member layout assertions and address member descriptor review by youknowone · Pull Request #8882 · RustPython/RustPython

Description: Follow-up to #8857. This is the part of #8873 that does not depend on bitflagset; #8873 keeps only the bitflagset switch. Changes Fix i686 cargo check (it failed on #8857): The tp_flags layout assertion compared AtomicU64 alignment with u64 alignment, which differ on i686. __flags__ is read as an AtomicU64, so only that layout is asserted now. The select.kevent assertion required usize/isize/c_ulong/c_long to be 64-bit. It now only requires that pointer-sized values fit into the 64-bit cells. Review follow-ups on member descriptors Internal PY_ATOMIC flag on PyMemberDef: a member is loaded atomically only when its storage is atomic. C extension members never set it. _elementtree: new state, entity and target are published only after every handler lookup succeeds. genericalias: type names are computed only on the error path. unraisable hook: prints without a . when __module__ is missing or not a str. builtin_function_or_method.__reduce__ looks only at the bound object, like meth_reduce. Test fmt; clippy (default and CI feature set); wasm32-wasip1 check cargo check on i686-unknown-linux-gnu: vm, and the full feature set except sqlite (whose C build needs a sysroot locally) workspace tests, crates/capi tests test_types test_descr test_class test_builtin test_xml_etree test_genericalias test_sys test_pickle 🤖 Generated with Claude Code Summary by CodeRabbit Bug Fixes Corrected how native functions bound to non-module objects are represented when pickled. Parser initialization now preserves its existing configuration if new handler setup fails. Improved errors for invalid type-variable substitutions and made unraisable-exception output more robust when module information is unavailable. Corrected access to atomic and read-only member fields to use appropriate loading behavior. Improved compatibility with extension-defined member flags by preserving unrecognized flag values.

Open Graph Description: Follow-up to #8857. This is the part of #8873 that does not depend on bitflagset; #8873 keeps only the bitflagset switch. Changes Fix i686 cargo check (it failed on #8857): The tp_flags layout as...

X Description: Follow-up to #8857. This is the part of #8873 that does not depend on bitflagset; #8873 keeps only the bitflagset switch. Changes Fix i686 cargo check (it failed on #8857): The tp_flags layout as...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8882

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6f535c01-a5d0-df6f-9c97-00162f375676
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC9A:6365:3823076:4AD1A9E:6B021B90
html-safe-nonced493206b6be8025daa0e692f02e2095d217593f7efd88d4abd06df085566c8b0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzlBOjYzNjU6MzgyMzA3Njo0QUQxQTlFOjZCMDIxQjkwIiwidmlzaXRvcl9pZCI6IjkwMzgzNjQ4NDQ5MDYxMjYyMjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac18849b65c11654975c0dbbf1d69588b3bf9ecf27cea6a99da450de6364f56663
hovercard-subject-tagpull_request:4664355170
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8882/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altFollow-up to #8857. This is the part of #8873 that does not depend on bitflagset; #8873 keeps only the bitflagset switch. Changes Fix i686 cargo check (it failed on #8857): The tp_flags layout as...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8882/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8882%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8882%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8882/files
Reloadhttps://github.com/RustPython/RustPython/pull/8882/files
Reloadhttps://github.com/RustPython/RustPython/pull/8882/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests130 (130)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:member-review-fixeshttps://github.com/youknowone/RustPython/tree/member-review-fixes
Conversation 1 https://github.com/RustPython/RustPython/pull/8882
Commits 3 https://github.com/RustPython/RustPython/pull/8882/commits
Checks 28 https://github.com/RustPython/RustPython/pull/8882/checks
Files changed https://github.com/RustPython/RustPython/pull/8882/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8882/files
Fix 32-bit member layout assertions and address member descriptor review https://github.com/RustPython/RustPython/pull/8882/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/8882/files
5ab2fdb Address review findings on member descriptors youknowone Sep 27, 2026 https://github.com/RustPython/RustPython/pull/8882/commits/5ab2fdbc4ba7d0da625127e61e2eca69302493a4
7c41cb9 Fix member layout assertions on 32-bit targets youknowone Sep 27, 2026 https://github.com/RustPython/RustPython/pull/8882/commits/7c41cb935d256ae30560c808939c70071e461a29
7ace8d0 Use bitflags for member definition flags youknowone Sep 28, 2026 https://github.com/RustPython/RustPython/pull/8882/commits/7ace8d07879f50271ca0f8fa932e0aa84d5b88c7
Clear filters https://github.com/RustPython/RustPython/pull/8882/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8882/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8882/files
descrobject.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-d64e4721d804fd795059878868b6766be2d0be0b4e19f19247a963625690a4c1
pyclass.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
elementtree.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
select.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
builtin_func.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
descriptor.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-7c8850ad317bf0c33b339610ec3e80a4038cd37545ba20746f8e680d87931b8e
genericalias.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
mod.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-a79e3fb5ee732b7e8bcae30f1a73e6f4b0a87aa047edcbb5174aa9f1fb4872f8
type.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-fb88962f9343ca7b8d31bfe34f5063136575e05eadae6fccb3b64658e14b0d6c
sys.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-e7f7c10b81f88d7af77af76257284e18e72ed9da63ff63675a9e9cb31c8d262d
slot.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-1b5587c15bdfe9ff552fbc35e014eef20d6b7934fbb31b922cf35d87e8837b7b
context.rs https://github.com/RustPython/RustPython/pull/8882/files#diff-266ab6550d81a4d367e5ef4973281aecf61c7abb46760195fc4ad6064bca0791
crates/capi/src/descrobject.rshttps://github.com/RustPython/RustPython/pull/8882/files#diff-d64e4721d804fd795059878868b6766be2d0be0b4e19f19247a963625690a4c1
View file https://github.com/youknowone/RustPython/blob/7ace8d07879f50271ca0f8fa932e0aa84d5b88c7/crates/capi/src/descrobject.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8882/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8882/files#diff-d64e4721d804fd795059878868b6766be2d0be0b4e19f19247a963625690a4c1
https://github.com/RustPython/RustPython/pull/8882/files#diff-d64e4721d804fd795059878868b6766be2d0be0b4e19f19247a963625690a4c1
https://github.com/RustPython/RustPython/pull/8882/files#diff-d64e4721d804fd795059878868b6766be2d0be0b4e19f19247a963625690a4c1
https://github.com/RustPython/RustPython/pull/8882/files#diff-d64e4721d804fd795059878868b6766be2d0be0b4e19f19247a963625690a4c1
crates/derive-impl/src/pyclass.rshttps://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
View file https://github.com/youknowone/RustPython/blob/7ace8d07879f50271ca0f8fa932e0aa84d5b88c7/crates/derive-impl/src/pyclass.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8882/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/8882/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
crates/stdlib/src/elementtree.rshttps://github.com/RustPython/RustPython/pull/8882/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
View file https://github.com/youknowone/RustPython/blob/7ace8d07879f50271ca0f8fa932e0aa84d5b88c7/crates/stdlib/src/elementtree.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8882/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8882/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/8882/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/8882/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
crates/stdlib/src/select.rshttps://github.com/RustPython/RustPython/pull/8882/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
View file https://github.com/youknowone/RustPython/blob/7ace8d07879f50271ca0f8fa932e0aa84d5b88c7/crates/stdlib/src/select.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8882/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8882/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
https://github.com/RustPython/RustPython/pull/8882/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
crates/vm/src/builtins/builtin_func.rshttps://github.com/RustPython/RustPython/pull/8882/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
View file https://github.com/youknowone/RustPython/blob/7ace8d07879f50271ca0f8fa932e0aa84d5b88c7/crates/vm/src/builtins/builtin_func.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8882/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8882/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
https://github.com/RustPython/RustPython/pull/8882/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8882/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8882/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.