Title: Fix array search equality and reentrant callbacks by 1ndahous3 · Pull Request #8870 · RustPython/RustPython · GitHub
Open Graph Title: Fix array search equality and reentrant callbacks by 1ndahous3 · Pull Request #8870 · RustPython/RustPython
X Title: Fix array search equality and reentrant callbacks by 1ndahous3 · Pull Request #8870 · RustPython/RustPython
Description: This PR follows our AI policy. Summary Compare array search values using Python equality. Equal integers and floats now agree across count, index, remove, and membership; single-precision arrays no longer round the search value into a false match. Propagate comparison errors and keep searches valid when equality callbacks change the array. Preserve native scans for exact builtin numbers and strings, including invalid Unicode error ordering. Run append/insert value conversion and generic extend callbacks outside array locks. Recheck exported buffers after conversion and preserve completed extension progress if iteration fails. Related to #6549; follows up on the closed #6576. Performance Release build, Windows x64; medians of seven samples against the same main revision. Operation Before After Speedup Missing integer membership in a 4,096-element array 99.1 µs 1.29 µs 76.8× Finding the last integer in a 4,096-element array 2.40 µs 1.37 µs 1.75× AI assistance Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Bug Fixes Array searches now better match Python equality behavior, including for numbers and custom comparisons. Search and containment operations now report comparison and validation errors instead of silently ignoring them. index supports optional start and stop bounds, including negative indices. Array updates handle conversions and mutations during comparisons or iteration more consistently.
Open Graph Description: This PR follows our AI policy. Summary Compare array search values using Python equality. Equal integers and floats now agree across count, index, remove, and membership; single-precision arrays ...
X Description: This PR follows our AI policy. Summary Compare array search values using Python equality. Equal integers and floats now agree across count, index, remove, and membership; single-precision arrays ...
Opengraph URL: https://github.com/RustPython/RustPython/pull/8870
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e6ef578d-aba8-56d6-4670-7ea64c82c1e1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 82F6:A71F9:360DB3E:44671ED:6B021B9D |
| html-safe-nonce | 567df547a0b712804ed9cb20d16cd52a51ed575d003b129df11e46ace4585072 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkY2OkE3MUY5OjM2MERCM0U6NDQ2NzFFRDo2QjAyMUI5RCIsInZpc2l0b3JfaWQiOiI5ODczMDgzNDQ4NTc0Njc4MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8010aa6222f283df736fb723c6d9d86dc2f5fe041996103d9afad07b16c83e9d |
| hovercard-subject-tag | pull_request:4656425847 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8870/files |
| twitter:image | https://avatars.githubusercontent.com/u/9205230?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9205230?s=400&v=4 |
| og:image:alt | This PR follows our AI policy. Summary Compare array search values using Python equality. Equal integers and floats now agree across count, index, remove, and membership; single-precision arrays ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width