René's URL Explorer Experiment


Title: Fix array search equality and reentrant callbacks by 1ndahous3 · Pull Request #8870 · RustPython/RustPython · GitHub

Open Graph Title: Fix array search equality and reentrant callbacks by 1ndahous3 · Pull Request #8870 · RustPython/RustPython

X Title: Fix array search equality and reentrant callbacks by 1ndahous3 · Pull Request #8870 · RustPython/RustPython

Description: This PR follows our AI policy. Summary Compare array search values using Python equality. Equal integers and floats now agree across count, index, remove, and membership; single-precision arrays no longer round the search value into a false match. Propagate comparison errors and keep searches valid when equality callbacks change the array. Preserve native scans for exact builtin numbers and strings, including invalid Unicode error ordering. Run append/insert value conversion and generic extend callbacks outside array locks. Recheck exported buffers after conversion and preserve completed extension progress if iteration fails. Related to #6549; follows up on the closed #6576. Performance Release build, Windows x64; medians of seven samples against the same main revision. Operation Before After Speedup Missing integer membership in a 4,096-element array 99.1 µs 1.29 µs 76.8× Finding the last integer in a 4,096-element array 2.40 µs 1.37 µs 1.75× AI assistance Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Bug Fixes Array searches now better match Python equality behavior, including for numbers and custom comparisons. Search and containment operations now report comparison and validation errors instead of silently ignoring them. index supports optional start and stop bounds, including negative indices. Array updates handle conversions and mutations during comparisons or iteration more consistently.

Open Graph Description: This PR follows our AI policy. Summary Compare array search values using Python equality. Equal integers and floats now agree across count, index, remove, and membership; single-precision arrays ...

X Description: This PR follows our AI policy. Summary Compare array search values using Python equality. Equal integers and floats now agree across count, index, remove, and membership; single-precision arrays ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8870

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e6ef578d-aba8-56d6-4670-7ea64c82c1e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82F6:A71F9:360DB3E:44671ED:6B021B9D
html-safe-nonce567df547a0b712804ed9cb20d16cd52a51ed575d003b129df11e46ace4585072
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkY2OkE3MUY5OjM2MERCM0U6NDQ2NzFFRDo2QjAyMUI5RCIsInZpc2l0b3JfaWQiOiI5ODczMDgzNDQ4NTc0Njc4MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8010aa6222f283df736fb723c6d9d86dc2f5fe041996103d9afad07b16c83e9d
hovercard-subject-tagpull_request:4656425847
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8870/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altThis PR follows our AI policy. Summary Compare array search values using Python equality. Equal integers and floats now agree across count, index, remove, and membership; single-precision arrays ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8870/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8870%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8870%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8870/files
Reloadhttps://github.com/RustPython/RustPython/pull/8870/files
Reloadhttps://github.com/RustPython/RustPython/pull/8870/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests130 (130)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:array_search_reentryhttps://github.com/1ndahous3/RustPython/tree/array_search_reentry
Conversation 4 https://github.com/RustPython/RustPython/pull/8870
Commits 1 https://github.com/RustPython/RustPython/pull/8870/commits
Checks 29 https://github.com/RustPython/RustPython/pull/8870/checks
Files changed https://github.com/RustPython/RustPython/pull/8870/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8870/files
Fix array search equality and reentrant callbacks https://github.com/RustPython/RustPython/pull/8870/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8870/files
f4e74ad Fix array search equality and reentrant callbacks 1ndahous3 Sep 27, 2026 https://github.com/RustPython/RustPython/pull/8870/commits/f4e74ad18b36b616c0dae20c17592305a017cea2
Clear filters https://github.com/RustPython/RustPython/pull/8870/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8870/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8870/files
array.rs https://github.com/RustPython/RustPython/pull/8870/files#diff-4af79f42ea956565988f27a170bd30079de0e7f232a1d4e6371609567f421fc4
stdlib_array.py https://github.com/RustPython/RustPython/pull/8870/files#diff-17f45c6fd685b13d6a49df935a5dccc0a504519223d3784f7167fee4c5e69ee5
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8870/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8870/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.