René's URL Explorer Experiment


Title: Avoid redundant work in set difference operations by 1ndahous3 · Pull Request #8869 · RustPython/RustPython · GitHub

Open Graph Title: Avoid redundant work in set difference operations by 1ndahous3 · Pull Request #8869 · RustPython/RustPython

X Title: Avoid redundant work in set difference operations by 1ndahous3 · Pull Request #8869 · RustPython/RustPython

Description: This PR follows our AI policy. Summary Copy set and frozenset difference results once, including multi-argument differences. Reuse stored hashes after deduplicating generic symmetric-difference inputs, avoiding repeated __hash__ calls. Consume difference_update iterables incrementally, avoiding a temporary list of all elements and retaining completed removals when iteration raises. Continues the stored-hash work in #8852 and #8859 for generic symmetric-difference inputs. Performance Release build, Windows x64; medians of seven samples against the same main revision. Operation Before After Speedup Difference: 4,096 integers, one 100-item exclusion set 67.2 µs 33.6 µs 2.00× Difference: 4,096 integers, two 100-item exclusion sets 97.9 µs 35.1 µs 2.79× Symmetric difference: list of 512 keys with Python __hash__ 572.2 µs 382.3 µs 1.50× AI assistance Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Bug Fixes Set and frozenset difference operations now correctly handle multiple operands and reflected subtraction without changing the original operands. Symmetric difference operations now handle duplicate inputs consistently, including when updating a set in place. difference_update now applies removals as items are yielded, so changes made before an iterator raises an error are retained. Updating a set from itself also correctly empties it.

Open Graph Description: This PR follows our AI policy. Summary Copy set and frozenset difference results once, including multi-argument differences. Reuse stored hashes after deduplicating generic symmetric-difference i...

X Description: This PR follows our AI policy. Summary Copy set and frozenset difference results once, including multi-argument differences. Reuse stored hashes after deduplicating generic symmetric-difference i...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8869

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:44235daa-81c4-bab5-4ab8-6dfa27d7209b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFC8:76F02:3CC7849:4DAB7E6:6B020AE1
html-safe-nonce7c2ad0f68e33a24386464331e85e7585ff6eac9a8b697bdcab7c1c8b6597b751
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkM4Ojc2RjAyOjNDQzc4NDk6NERBQjdFNjo2QjAyMEFFMSIsInZpc2l0b3JfaWQiOiI4NzE2ODQ2ODU3MzAyNzA2OTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6ae605fbe6475871da18beae2d2baf2340268efd22b3144f92c917b0c8836175
hovercard-subject-tagpull_request:4656424228
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8869/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altThis PR follows our AI policy. Summary Copy set and frozenset difference results once, including multi-argument differences. Reuse stored hashes after deduplicating generic symmetric-difference i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8869/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8869%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8869%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8869/files
Reloadhttps://github.com/RustPython/RustPython/pull/8869/files
Reloadhttps://github.com/RustPython/RustPython/pull/8869/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:set_operation_pathshttps://github.com/1ndahous3/RustPython/tree/set_operation_paths
Conversation 2 https://github.com/RustPython/RustPython/pull/8869
Commits 1 https://github.com/RustPython/RustPython/pull/8869/commits
Checks 20 https://github.com/RustPython/RustPython/pull/8869/checks
Files changed https://github.com/RustPython/RustPython/pull/8869/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8869/files
Avoid redundant work in set difference operations https://github.com/RustPython/RustPython/pull/8869/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8869/files
1587647 Avoid redundant work in set difference operations 1ndahous3 Sep 27, 2026 https://github.com/RustPython/RustPython/pull/8869/commits/1587647b0e895cd1874c493b1699089870f47dee
Clear filters https://github.com/RustPython/RustPython/pull/8869/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8869/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8869/files
set.rs https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
dict_inner.rs https://github.com/RustPython/RustPython/pull/8869/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
builtin_set.py https://github.com/RustPython/RustPython/pull/8869/files#diff-49fd7f7d95c68ebdcf476b292e14e8698f1b0bf06c065fee93f13440128597b3
crates/vm/src/builtins/set.rshttps://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
View file https://github.com/1ndahous3/RustPython/blob/1587647b0e895cd1874c493b1699089870f47dee/crates/vm/src/builtins/set.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8869/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8869/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
crates/vm/src/dict_inner.rshttps://github.com/RustPython/RustPython/pull/8869/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
View file https://github.com/1ndahous3/RustPython/blob/1587647b0e895cd1874c493b1699089870f47dee/crates/vm/src/dict_inner.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8869/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8869/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8869/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
extra_tests/snippets/builtin_set.pyhttps://github.com/RustPython/RustPython/pull/8869/files#diff-49fd7f7d95c68ebdcf476b292e14e8698f1b0bf06c065fee93f13440128597b3
View file https://github.com/1ndahous3/RustPython/blob/1587647b0e895cd1874c493b1699089870f47dee/extra_tests/snippets/builtin_set.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8869/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8869/files#diff-49fd7f7d95c68ebdcf476b292e14e8698f1b0bf06c065fee93f13440128597b3
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8869/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.