René's URL Explorer Experiment


Title: Reuse stored hashes for frozenset hashing and in-place set union by 1ndahous3 · Pull Request #8859 · RustPython/RustPython · GitHub

Open Graph Title: Reuse stored hashes for frozenset hashing and in-place set union by 1ndahous3 · Pull Request #8859 · RustPython/RustPython

X Title: Reuse stored hashes for frozenset hashing and in-place set union by 1ndahous3 · Pull Request #8859 · RustPython/RustPython

Description: This PR follows our AI policy Summary Compute the first frozenset hash from stored element hashes without calling element __hash__ methods again. In-place set union uses the same native merge path as set.update, including for set and frozenset subclasses. Follow-up to #8491, which introduced stored-hash reuse in set construction. Performance Release build, 512 keys; median of three samples. Operation Keys Before After Speedup In-place union 4-item tuples 39.51 µs 16.24 µs 2.43× In-place union 16-item tuples 75.40 µs 16.30 µs 4.63× Build and hash frozenset 4-item tuples 32.68 µs 16.65 µs 1.96× Build and hash frozenset 16-item tuples 66.73 µs 16.80 µs 3.97× AI assistance Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Bug Fixes Set and frozen-set operations now reuse hashes already stored for their elements, avoiding unnecessary rehashing. In-place union now handles sets and frozen sets correctly, including subclasses with customized iteration, and avoids adding duplicate elements when a set is unioned with itself. Frozen-set hashes remain consistent regardless of the order in which elements were added.

Open Graph Description: This PR follows our AI policy Summary Compute the first frozenset hash from stored element hashes without calling element __hash__ methods again. In-place set union uses the same native merge path...

X Description: This PR follows our AI policy Summary Compute the first frozenset hash from stored element hashes without calling element __hash__ methods again. In-place set union uses the same native merge path...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8859

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a8c75f6c-0c99-5483-0f90-38ae22fc8e5b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA32:1F2B:10F428:16F385:6B020878
html-safe-noncef08373056daf942e2dedcdf9ee62f53b90e48b0242bc563c97d3491628b51158
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTMyOjFGMkI6MTBGNDI4OjE2RjM4NTo2QjAyMDg3OCIsInZpc2l0b3JfaWQiOiI3NDQzNDU1NTM1ODM3NDgxMDgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac45ac95e30d0fc76fec9f0b3841b5423bce0f64136f3d6ac3ab7ae1d4abcdf142
hovercard-subject-tagpull_request:4653818939
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8859/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altThis PR follows our AI policy Summary Compute the first frozenset hash from stored element hashes without calling element __hash__ methods again. In-place set union uses the same native merge path...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8859/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8859%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8859%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8859/files
Reloadhttps://github.com/RustPython/RustPython/pull/8859/files
Reloadhttps://github.com/RustPython/RustPython/pull/8859/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:set_remaining_hasheshttps://github.com/1ndahous3/RustPython/tree/set_remaining_hashes
Conversation 3 https://github.com/RustPython/RustPython/pull/8859
Commits 1 https://github.com/RustPython/RustPython/pull/8859/commits
Checks 21 https://github.com/RustPython/RustPython/pull/8859/checks
Files changed https://github.com/RustPython/RustPython/pull/8859/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8859/files
Reuse stored hashes for frozenset hashing and in-place set union https://github.com/RustPython/RustPython/pull/8859/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8859/files
ce427b2 Reuse stored hashes for frozenset hashing and in-place set union 1ndahous3 Sep 27, 2026 https://github.com/RustPython/RustPython/pull/8859/commits/ce427b2ba0c66d388e354eea5b0ed9da399f6c45
Clear filters https://github.com/RustPython/RustPython/pull/8859/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8859/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8859/files
set.rs https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
dict_inner.rs https://github.com/RustPython/RustPython/pull/8859/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
builtin_set.py https://github.com/RustPython/RustPython/pull/8859/files#diff-49fd7f7d95c68ebdcf476b292e14e8698f1b0bf06c065fee93f13440128597b3
crates/vm/src/builtins/set.rshttps://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
View file https://github.com/1ndahous3/RustPython/blob/ce427b2ba0c66d388e354eea5b0ed9da399f6c45/crates/vm/src/builtins/set.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8859/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8859/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
crates/vm/src/dict_inner.rshttps://github.com/RustPython/RustPython/pull/8859/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
View file https://github.com/1ndahous3/RustPython/blob/ce427b2ba0c66d388e354eea5b0ed9da399f6c45/crates/vm/src/dict_inner.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8859/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8859/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8859/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
extra_tests/snippets/builtin_set.pyhttps://github.com/RustPython/RustPython/pull/8859/files#diff-49fd7f7d95c68ebdcf476b292e14e8698f1b0bf06c065fee93f13440128597b3
View file https://github.com/1ndahous3/RustPython/blob/ce427b2ba0c66d388e354eea5b0ed9da399f6c45/extra_tests/snippets/builtin_set.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8859/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8859/files#diff-49fd7f7d95c68ebdcf476b292e14e8698f1b0bf06c065fee93f13440128597b3
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8859/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.