René's URL Explorer Experiment


Title: Reuse stored hashes in set operations and fix key comparison order by 1ndahous3 · Pull Request #8852 · RustPython/RustPython · GitHub

Open Graph Title: Reuse stored hashes in set operations and fix key comparison order by 1ndahous3 · Pull Request #8852 · RustPython/RustPython

X Title: Reuse stored hashes in set operations and fix key comparison order by 1ndahous3 · Pull Request #8852 · RustPython/RustPython

Description: This PR follows our AI policy Summary Reuse stored hashes in set/frozenset comparisons and predicates, avoiding temporary sets for native subset checks. Intersect native sets using the smaller operand without first copying the left operand; preserve the corresponding equal key and subclass iterator behavior. Hash each generic intersection element once and stop intersection/subset iteration after all source elements match. Dictionary arguments use generic iteration and hashing, matching CPython. Compare stored dictionary/set keys before lookup keys, preserving NotImplemented fallback and subclass comparison priority. Follow-up to #8491, which closed #8489. Performance Release on Windows, medians of three calibrated samples: Operation (operand sizes) Before After Native issubset (32/512) 27.632 µs 1.096 µs Native isdisjoint (32/512) 20.375 µs 0.534 µs Native intersection, larger left operand (512/32) 7.640 µs 2.350 µs Set equality, custom-hash keys (32/32) 6.371 µs 0.465 µs Intersection with a disjoint dict (8/128) 1.911 µs 3.790 µs AI assistance Written with Codex (GPT-6), reviewed by a human before submission. Summary by CodeRabbit Bug Fixes Set and frozenset intersections, including in-place intersections, now handle multiple operands and set-like inputs more consistently. Subset, superset, and disjoint checks now behave more reliably with sets, frozensets, and custom iterables. Dictionary lookups and assignments now follow the expected key comparison order, including when equal keys have different identities.

Open Graph Description: This PR follows our AI policy Summary Reuse stored hashes in set/frozenset comparisons and predicates, avoiding temporary sets for native subset checks. Intersect native sets using the smaller op...

X Description: This PR follows our AI policy Summary Reuse stored hashes in set/frozenset comparisons and predicates, avoiding temporary sets for native subset checks. Intersect native sets using the smaller op...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8852

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:38435c90-e4fe-f3ea-36cf-414c454dcd8b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD838:1F87:3666FC:443F2A:6B020870
html-safe-noncec3ddbd59d3663db07b2143603751ef6c495d562de79a6493f91280b9b5e33d1c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODM4OjFGODc6MzY2NkZDOjQ0M0YyQTo2QjAyMDg3MCIsInZpc2l0b3JfaWQiOiI4MzMzNTk3NDI1MDEyOTY3NTM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac315bb266c85caa74e4cfd38076010e4b454b151334525e3822adc80d9b6df702
hovercard-subject-tagpull_request:4652692538
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8852/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altThis PR follows our AI policy Summary Reuse stored hashes in set/frozenset comparisons and predicates, avoiding temporary sets for native subset checks. Intersect native sets using the smaller op...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8852/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8852%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8852%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8852/files
Reloadhttps://github.com/RustPython/RustPython/pull/8852/files
Reloadhttps://github.com/RustPython/RustPython/pull/8852/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:set_native_opshttps://github.com/1ndahous3/RustPython/tree/set_native_ops
Conversation 8 https://github.com/RustPython/RustPython/pull/8852
Commits 1 https://github.com/RustPython/RustPython/pull/8852/commits
Checks 21 https://github.com/RustPython/RustPython/pull/8852/checks
Files changed https://github.com/RustPython/RustPython/pull/8852/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8852/files
Reuse stored hashes in set operations and fix key comparison order https://github.com/RustPython/RustPython/pull/8852/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8852/files
d6f4938 Reuse set hashes and fix stored key comparison order 1ndahous3 Sep 27, 2026 https://github.com/RustPython/RustPython/pull/8852/commits/d6f493860fcf2f46ce270ac2bf546edd1a1eff29
Clear filters https://github.com/RustPython/RustPython/pull/8852/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8852/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8852/files
set.rs https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
dict_inner.rs https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
builtin_dict.py https://github.com/RustPython/RustPython/pull/8852/files#diff-53c8671e50d952919453053f69068a3747a238bfa87501fd0ce7b6608696d988
builtin_set.py https://github.com/RustPython/RustPython/pull/8852/files#diff-49fd7f7d95c68ebdcf476b292e14e8698f1b0bf06c065fee93f13440128597b3
crates/vm/src/builtins/set.rshttps://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
View file https://github.com/1ndahous3/RustPython/blob/d6f493860fcf2f46ce270ac2bf546edd1a1eff29/crates/vm/src/builtins/set.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8852/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8852/files
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8852/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
crates/vm/src/dict_inner.rshttps://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
View file https://github.com/1ndahous3/RustPython/blob/d6f493860fcf2f46ce270ac2bf546edd1a1eff29/crates/vm/src/dict_inner.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8852/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
https://github.com/RustPython/RustPython/pull/8852/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
extra_tests/snippets/builtin_dict.pyhttps://github.com/RustPython/RustPython/pull/8852/files#diff-53c8671e50d952919453053f69068a3747a238bfa87501fd0ce7b6608696d988
View file https://github.com/1ndahous3/RustPython/blob/d6f493860fcf2f46ce270ac2bf546edd1a1eff29/extra_tests/snippets/builtin_dict.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8852/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8852/files#diff-53c8671e50d952919453053f69068a3747a238bfa87501fd0ce7b6608696d988
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8852/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8852/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.