René's URL Explorer Experiment


Title: Remove unused PyLease; skip flaky httpservers test on macOS by youknowone · Pull Request #8821 · RustPython/RustPython · GitHub

Open Graph Title: Remove unused PyLease; skip flaky httpservers test on macOS by youknowone · Pull Request #8821 · RustPython/RustPython

X Title: Remove unused PyLease; skip flaky httpservers test on macOS by youknowone · Pull Request #8821 · RustPython/RustPython

Description: PyLease was introduced in f075cac to wrap a read guard over the object's type while typ was a PyRwLock, so class() could hand out the type without cloning the Arc. Its last users, class() and lease_class(), went away in #3828 when typ became a PyAtomicRef. It has carried #[allow(dead_code)] and a "check if we still need this" TODO since. Its only field is private and there is no constructor, so it cannot be built inside or outside the crate. This removes it and the now-unused PyRwLockReadGuard import. Also skips test_httpservers.CGIHTTPServerTestCase.test_large_content_length_truncated on macOS again. It failed macOS CI on this PR. The test sets the handler timeout to 1ms, and that timeout also bounds reading the request line: if the client has not sent the request within 1ms, the server logs "Request timed out" and closes the connection, and the client gets ConnectionResetError or BrokenPipeError. It reproduces locally on macOS about 5 runs in 6 with both RustPython and CPython 3.14.6. The skip was removed in #8759 after Linux-only repeats; Linux and Windows keep running it. 🤖 Generated with Claude Code Summary by CodeRabbit Refactor Made an internal implementation cleanup. No user-facing behavior changes are included in this update.

Open Graph Description: PyLease was introduced in f075cac to wrap a read guard over the object's type while typ was a PyRwLock<PyTypeRef>, so class() could hand out the type without cloning the Arc. Its last use...

X Description: PyLease was introduced in f075cac to wrap a read guard over the object&#39;s type while typ was a PyRwLock&lt;PyTypeRef&gt;, so class() could hand out the type without cloning the Arc. ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8821

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:16054040-b357-9518-1b0e-b230372ace9a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBFC:245A38:AEBA1A:EAE380:6B004BD9
html-safe-nonceeae6074b79031ef9629b3c41be8afe0f93373e8c090e38de316797eb26ff65fe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkZDOjI0NUEzODpBRUJBMUE6RUFFMzgwOjZCMDA0QkQ5IiwidmlzaXRvcl9pZCI6IjcxMDIxODkxMzgyODMwODg4NTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb954f223bb5f374cea51f7a21d73b8a9be6de27325e99839e38184364f95457f
hovercard-subject-tagpull_request:4641649418
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8821/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altPyLease was introduced in f075cac to wrap a read guard over the object's type while typ was a PyRwLock<PyTypeRef>, so class() could hand out the type without cloning the Arc. Its last use...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8821/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8821%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8821%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8821/files
Reloadhttps://github.com/RustPython/RustPython/pull/8821/files
Reloadhttps://github.com/RustPython/RustPython/pull/8821/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:remove-pyleasehttps://github.com/youknowone/RustPython/tree/remove-pylease
Conversation 4 https://github.com/RustPython/RustPython/pull/8821
Commits 2 https://github.com/RustPython/RustPython/pull/8821/commits
Checks 20 https://github.com/RustPython/RustPython/pull/8821/checks
Files changed https://github.com/RustPython/RustPython/pull/8821/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8821/files
Remove unused PyLease; skip flaky httpservers test on macOS https://github.com/RustPython/RustPython/pull/8821/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/8821/files
cf4a5f3 Remove unused PyLease youknowone Sep 25, 2026 https://github.com/RustPython/RustPython/pull/8821/commits/cf4a5f359abb98aa25e04610d800a72e88b17421
62300b1 Skip test_large_content_length_truncated on macOS youknowone Sep 26, 2026 https://github.com/RustPython/RustPython/pull/8821/commits/62300b181ddbeede39ae48985e22e2c9b9d7d1d9
Clear filters https://github.com/RustPython/RustPython/pull/8821/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8821/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8821/files
test_httpservers.py https://github.com/RustPython/RustPython/pull/8821/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
ext.rs https://github.com/RustPython/RustPython/pull/8821/files#diff-ccab52adc1059b887873204f5691f9782da457688e788cfa7b214961357e11fa
Lib/test/test_httpservers.pyhttps://github.com/RustPython/RustPython/pull/8821/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
View file https://github.com/youknowone/RustPython/blob/62300b181ddbeede39ae48985e22e2c9b9d7d1d9/Lib/test/test_httpservers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8821/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8821/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
https://github.com/RustPython/RustPython/pull/8821/files#diff-5c8de474c50a44ead423e2d9ce85c1932b9c87ba9f5a3215c0b8b996c65e62b9
crates/vm/src/object/ext.rshttps://github.com/RustPython/RustPython/pull/8821/files#diff-ccab52adc1059b887873204f5691f9782da457688e788cfa7b214961357e11fa
View file https://github.com/youknowone/RustPython/blob/62300b181ddbeede39ae48985e22e2c9b9d7d1d9/crates/vm/src/object/ext.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8821/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8821/files#diff-ccab52adc1059b887873204f5691f9782da457688e788cfa7b214961357e11fa
https://github.com/RustPython/RustPython/pull/8821/files#diff-ccab52adc1059b887873204f5691f9782da457688e788cfa7b214961357e11fa
https://github.com/RustPython/RustPython/pull/8821/files#diff-ccab52adc1059b887873204f5691f9782da457688e788cfa7b214961357e11fa
https://github.com/RustPython/RustPython/pull/8821/files#diff-ccab52adc1059b887873204f5691f9782da457688e788cfa7b214961357e11fa
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8821/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.