René's URL Explorer Experiment


Title: Stop embedding build-time environment variables in _sysconfigdata by youknowone · Pull Request #8813 · RustPython/RustPython · GitHub

Open Graph Title: Stop embedding build-time environment variables in _sysconfigdata by youknowone · Pull Request #8813 · RustPython/RustPython

X Title: Stop embedding build-time environment variables in _sysconfigdata by youknowone · Pull Request #8813 · RustPython/RustPython

Description: Fixes #8802 crates/vm/build.rs dumped every environment variable of the build process into OUT_DIR/env_vars.rs, and _sysconfigdata include!d that file into build_time_vars. This is worse than the issue describes: the variables were not only cached in target/, they were compiled into the binary as string literals and readable at runtime via sysconfig.get_config_vars(). Any secret present in the build environment (CI tokens, cloud credentials) shipped inside the resulting binary. Changes: Remove the environment dump from build.rs and the include! from _sysconfigdata.rs. build_time_vars now contains only the explicit entries. Drop the now unused itertools build-dependency. None of the keys the stdlib reads through sysconfig.get_config_var were sourced from build-time environment variables, so no allowlist was needed. Verified: cargo clippy -p rustpython-vm --all-targets clean Built with LEAKCHECK_SECRET set: sysconfig.get_config_vars() no longer contains HOME/PATH/the secret, and strings on the binary finds no trace of it test_sysconfig, test_site, test_venv pass Note for maintainers: previously published release binaries still contain the environment of the machine that built them. It is worth checking whether any CI secrets were exposed in past release builds. 🤖 Generated with Claude Code Summary by CodeRabbit Behavior Changes The _sysconfigdata output no longer includes values captured from the build environment. It now reports the statically defined configuration values and runtime-dependent paths, including the installation prefix and binary directory. This may change which configuration variables are available to applications that inspect system configuration.

Open Graph Description: Fixes #8802 crates/vm/build.rs dumped every environment variable of the build process into OUT_DIR/env_vars.rs, and _sysconfigdata include!d that file into build_time_vars. This is worse than the i...

X Description: Fixes #8802 crates/vm/build.rs dumped every environment variable of the build process into OUT_DIR/env_vars.rs, and _sysconfigdata include!d that file into build_time_vars. This is worse than the i...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8813

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:291760b0-7e1f-44e7-ae50-77583fb8d26d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id994C:2AAD2E:2E8E3CB:3E2D395:6B01DEAD
html-safe-nonce509551bd85ef4cfc759e6b8408ca10c0f2665e6592b326a6278875951588cfce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTRDOjJBQUQyRToyRThFM0NCOjNFMkQzOTU6NkIwMURFQUQiLCJ2aXNpdG9yX2lkIjoiNDc0ODA2NzgzNjIxNDIzODg5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbacb1a5f2b46c2422374075fb0019f6ec1e6b16a2d7e5bc162345911c695c408
hovercard-subject-tagpull_request:4629333616
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8813/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altFixes #8802 crates/vm/build.rs dumped every environment variable of the build process into OUT_DIR/env_vars.rs, and _sysconfigdata include!d that file into build_time_vars. This is worse than the i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8813/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8813%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8813%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8813/files
Reloadhttps://github.com/RustPython/RustPython/pull/8813/files
Reloadhttps://github.com/RustPython/RustPython/pull/8813/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:fix-build-env-leakhttps://github.com/youknowone/RustPython/tree/fix-build-env-leak
Conversation 4 https://github.com/RustPython/RustPython/pull/8813
Commits 1 https://github.com/RustPython/RustPython/pull/8813/commits
Checks 29 https://github.com/RustPython/RustPython/pull/8813/checks
Files changed https://github.com/RustPython/RustPython/pull/8813/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8813/files
Stop embedding build-time environment variables in _sysconfigdata https://github.com/RustPython/RustPython/pull/8813/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8813/files
9c0675c Stop embedding build-time environment variables in _sysconfigdata youknowone Sep 24, 2026 https://github.com/RustPython/RustPython/pull/8813/commits/9c0675c39c144f8323052f7e273af1646df158da
Clear filters https://github.com/RustPython/RustPython/pull/8813/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8813/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8813/files
Cargo.toml https://github.com/RustPython/RustPython/pull/8813/files#diff-ccc3290f8eb6dbc476c8aad5c1586bf96837946b852e683ee8f21e4df91dc140
build.rs https://github.com/RustPython/RustPython/pull/8813/files#diff-67ac5eaa5a403f9a86e3a45dc326069e361803d98a9816af58ca4263778f03cb
_sysconfigdata.rs https://github.com/RustPython/RustPython/pull/8813/files#diff-f046c2696dec46d7f1cebe4c85481f5efa3bffd5c70d1abd65ed939886c50193
crates/vm/Cargo.tomlhttps://github.com/RustPython/RustPython/pull/8813/files#diff-ccc3290f8eb6dbc476c8aad5c1586bf96837946b852e683ee8f21e4df91dc140
View file https://github.com/youknowone/RustPython/blob/9c0675c39c144f8323052f7e273af1646df158da/crates/vm/Cargo.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8813/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8813/files#diff-ccc3290f8eb6dbc476c8aad5c1586bf96837946b852e683ee8f21e4df91dc140
https://github.com/RustPython/RustPython/pull/8813/files#diff-ccc3290f8eb6dbc476c8aad5c1586bf96837946b852e683ee8f21e4df91dc140
crates/vm/build.rshttps://github.com/RustPython/RustPython/pull/8813/files#diff-67ac5eaa5a403f9a86e3a45dc326069e361803d98a9816af58ca4263778f03cb
View file https://github.com/youknowone/RustPython/blob/9c0675c39c144f8323052f7e273af1646df158da/crates/vm/build.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8813/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8813/files#diff-67ac5eaa5a403f9a86e3a45dc326069e361803d98a9816af58ca4263778f03cb
https://github.com/RustPython/RustPython/pull/8813/files#diff-67ac5eaa5a403f9a86e3a45dc326069e361803d98a9816af58ca4263778f03cb
https://github.com/RustPython/RustPython/pull/8813/files#diff-67ac5eaa5a403f9a86e3a45dc326069e361803d98a9816af58ca4263778f03cb
https://github.com/RustPython/RustPython/pull/8813/files#diff-67ac5eaa5a403f9a86e3a45dc326069e361803d98a9816af58ca4263778f03cb
crates/vm/src/stdlib/_sysconfigdata.rshttps://github.com/RustPython/RustPython/pull/8813/files#diff-f046c2696dec46d7f1cebe4c85481f5efa3bffd5c70d1abd65ed939886c50193
View file https://github.com/youknowone/RustPython/blob/9c0675c39c144f8323052f7e273af1646df158da/crates/vm/src/stdlib/_sysconfigdata.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8813/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8813/files#diff-f046c2696dec46d7f1cebe4c85481f5efa3bffd5c70d1abd65ed939886c50193
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8813/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.