René's URL Explorer Experiment


Title: Keep sendall deadline; isolate STW eval-breaker test by youknowone · Pull Request #8786 · RustPython/RustPython · GitHub

Open Graph Title: Keep sendall deadline; isolate STW eval-breaker test by youknowone · Pull Request #8786 · RustPython/RustPython

X Title: Keep sendall deadline; isolate STW eval-breaker test by youknowone · Pull Request #8786 · RustPython/RustPython

Description: Follow-up to #8778 CodeRabbit review. sendall previously rebuilt a timeout from Deadline::time_until() on every chunk. After a wait, that leftover duration became a new deadline, so a slow sendall could run past the original timeout. sock_op_timeout_err now takes the absolute Deadline from sendall and keeps it for the whole write. The STW eval-breaker change in #8778 is covered by a second unit test that sets the current thread's stop_requested with the process-wide STOP_BIT clear, then asserts eval_breaker_tripped() is true while eval_breaker_pending() is false. Verified locally: cargo test -p rustpython-vm --lib --features threading eval_breaker_tripped_when_stop_requested cargo test -p rustpython-vm --lib --features threading stop_the_world_parks Assisted-by: Grok:4.6 Summary by CodeRabbit Bug Fixes Improved socket timeout handling for send and receive operations, providing more consistent behavior when deadlines are reached. Prevented unnecessary socket waits and retries after a timeout has already expired. Improved responsiveness when stopping execution from an individual thread. Tests Added coverage for thread-level stop requests when the global stop signal is not set.

Open Graph Description: Follow-up to #8778 CodeRabbit review. sendall previously rebuilt a timeout from Deadline::time_until() on every chunk. After a wait, that leftover duration became a new deadline, so a slow sendall ...

X Description: Follow-up to #8778 CodeRabbit review. sendall previously rebuilt a timeout from Deadline::time_until() on every chunk. After a wait, that leftover duration became a new deadline, so a slow sendall ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8786

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:34716ada-0ca1-686e-fe03-1b17720e306f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD256:184B81:308CEFC:405080B:6B00319A
html-safe-nonceb1466bfe2ebe1de7f7a1d55dfcd46e2506279ecd76005875ce98629207b65ac5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjU2OjE4NEI4MTozMDhDRUZDOjQwNTA4MEI6NkIwMDMxOUEiLCJ2aXNpdG9yX2lkIjoiODM3OTYxNjE2NTYzODQ1MTYxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5d523bb990cecdca345bb3045fc0cb18e580807677f4908211214dca09d219f5
hovercard-subject-tagpull_request:4602239830
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8786/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altFollow-up to #8778 CodeRabbit review. sendall previously rebuilt a timeout from Deadline::time_until() on every chunk. After a wait, that leftover duration became a new deadline, so a slow sendall ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8786/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8786%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8786%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8786/files
Reloadhttps://github.com/RustPython/RustPython/pull/8786/files
Reloadhttps://github.com/RustPython/RustPython/pull/8786/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:fix/sendall-deadline-stw-testhttps://github.com/youknowone/RustPython/tree/fix/sendall-deadline-stw-test
Conversation 5 https://github.com/RustPython/RustPython/pull/8786
Commits 1 https://github.com/RustPython/RustPython/pull/8786/commits
Checks 30 https://github.com/RustPython/RustPython/pull/8786/checks
Files changed https://github.com/RustPython/RustPython/pull/8786/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8786/files
Keep sendall deadline; isolate STW eval-breaker test https://github.com/RustPython/RustPython/pull/8786/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8786/files
bcdf58e address review: keep sendall deadline; isolate STW test youknowone Sep 22, 2026 https://github.com/RustPython/RustPython/pull/8786/commits/bcdf58ec4cc2d33c543a3175196bd1e18bfdd879
Clear filters https://github.com/RustPython/RustPython/pull/8786/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8786/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8786/files
socket.rs https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
interpreter.rs https://github.com/RustPython/RustPython/pull/8786/files#diff-2361f366cc46771907dbd3b09eb8b9c839e7f059710345f2265c1753862a1b20
thread.rs https://github.com/RustPython/RustPython/pull/8786/files#diff-0bfe10fdb30f1f6c60e31b36e738b86cd68863aeb8113c4c1eadec33e90caf8d
crates/stdlib/src/socket.rshttps://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
View file https://github.com/youknowone/RustPython/blob/bcdf58ec4cc2d33c543a3175196bd1e18bfdd879/crates/stdlib/src/socket.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8786/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/8786/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
crates/vm/src/vm/interpreter.rshttps://github.com/RustPython/RustPython/pull/8786/files#diff-2361f366cc46771907dbd3b09eb8b9c839e7f059710345f2265c1753862a1b20
View file https://github.com/youknowone/RustPython/blob/bcdf58ec4cc2d33c543a3175196bd1e18bfdd879/crates/vm/src/vm/interpreter.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8786/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8786/files#diff-2361f366cc46771907dbd3b09eb8b9c839e7f059710345f2265c1753862a1b20
coderabbitaihttps://github.com/apps/coderabbitai
Sep 22, 2026https://github.com/RustPython/RustPython/pull/8786/files#r4071800810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8786/files
https://github.com/RustPython/RustPython/pull/8786/files#diff-2361f366cc46771907dbd3b09eb8b9c839e7f059710345f2265c1753862a1b20
crates/vm/src/vm/thread.rshttps://github.com/RustPython/RustPython/pull/8786/files#diff-0bfe10fdb30f1f6c60e31b36e738b86cd68863aeb8113c4c1eadec33e90caf8d
View file https://github.com/youknowone/RustPython/blob/bcdf58ec4cc2d33c543a3175196bd1e18bfdd879/crates/vm/src/vm/thread.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8786/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8786/files#diff-0bfe10fdb30f1f6c60e31b36e738b86cd68863aeb8113c4c1eadec33e90caf8d
https://github.com/RustPython/RustPython/pull/8786/files#diff-0bfe10fdb30f1f6c60e31b36e738b86cd68863aeb8113c4c1eadec33e90caf8d
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8786/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.