René's URL Explorer Experiment


Title: address review: kqueue lock and host_env select by youknowone · Pull Request #8724 · RustPython/RustPython · GitHub

Open Graph Title: address review: kqueue lock and host_env select by youknowone · Pull Request #8724 · RustPython/RustPython

X Title: address review: kqueue lock and host_env select by youknowone · Pull Request #8724 · RustPython/RustPython

Description: Leftover from #8721 review comments after the squash merge. Hold the kqueue fd lock through kevent() and drop it before changelist parsing and check_signals(). Raise OverflowError when poll/kqueue timeouts overflow Instant or Duration. Round poll millisecond timeouts upward. Cast kevent default filter/flags for NetBSD field widths. Provide os.login_tty on Solaris/illumos via setsid, TIOCSCTTY, and dup2. Move select timeout conversion, socket wait, and rusage timeval handling into host_env. Deny libc poll/select/kqueue/epoll syscalls in vm/stdlib clippy. Assisted-by: Grok:grok-4.6 Summary by CodeRabbit New Features Added consistent file-descriptor readiness and timeout handling across supported platforms. Added Solaris and illumos support for terminal login functionality. Added public helpers for reporting user, system, and total CPU time. Bug Fixes Prevented timeout and CPU-time conversions from overflowing or panicking. Improved socket readiness handling for interruptions, timeouts, and I/O errors. Improved deadline accuracy by rounding short waits upward and handling large timeouts safely.

Open Graph Description: Leftover from #8721 review comments after the squash merge. Hold the kqueue fd lock through kevent() and drop it before changelist parsing and check_signals(). Raise OverflowError when poll/kqueue...

X Description: Leftover from #8721 review comments after the squash merge. Hold the kqueue fd lock through kevent() and drop it before changelist parsing and check_signals(). Raise OverflowError when poll/kqueue...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8724

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5133be1b-463b-3d51-049c-80f1bbd909e3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A2C:36D598:6E0D91:933C74:6B00370D
html-safe-noncef5ba636c84ddc454e0e3366743937ecdeaf18e13eff39694b2d884ee9164a302
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTJDOjM2RDU5ODo2RTBEOTE6OTMzQzc0OjZCMDAzNzBEIiwidmlzaXRvcl9pZCI6IjE1Njk3MTEyNzAzMTQxMjkxNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8d22a5bad90707992e77c4b9b4ffd090dbfc4f89ff15f7a987b290afc4543250
hovercard-subject-tagpull_request:4550051757
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8724/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altLeftover from #8721 review comments after the squash merge. Hold the kqueue fd lock through kevent() and drop it before changelist parsing and check_signals(). Raise OverflowError when poll/kqueue...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8724/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8724%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8724%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8724/files
Reloadhttps://github.com/RustPython/RustPython/pull/8724/files
Reloadhttps://github.com/RustPython/RustPython/pull/8724/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:host-env-win-ffihttps://github.com/youknowone/RustPython/tree/host-env-win-ffi
Conversation 20 https://github.com/RustPython/RustPython/pull/8724
Commits 5 https://github.com/RustPython/RustPython/pull/8724/commits
Checks 28 https://github.com/RustPython/RustPython/pull/8724/checks
Files changed https://github.com/RustPython/RustPython/pull/8724/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8724/files
address review: kqueue lock and host_env select https://github.com/RustPython/RustPython/pull/8724/files#top
Show all changes 5 commits https://github.com/RustPython/RustPython/pull/8724/files
b2f0379 address review: kqueue lock and timeout overflow youknowone Sep 16, 2026 https://github.com/RustPython/RustPython/pull/8724/commits/b2f0379f51054282afa91d6e47591d7f664e107e
332e520 Move select timeout conversion into host_env youknowone Sep 16, 2026 https://github.com/RustPython/RustPython/pull/8724/commits/332e5200735a3ff9c425a027164c12796dc055a8
20443f5 Move socket wait and rusage timeval into host_env youknowone Sep 16, 2026 https://github.com/RustPython/RustPython/pull/8724/commits/20443f5ebbe1338a8d80f6860e4dfd57f1af4c01
64994f0 Deny libc select syscalls in vm and stdlib clippy youknowone Sep 16, 2026 https://github.com/RustPython/RustPython/pull/8724/commits/64994f0574b098eebad7357234b41f23d418524a
0939989 address review: portable timeval and wait_fd youknowone Sep 17, 2026 https://github.com/RustPython/RustPython/pull/8724/commits/0939989f7fb98a99555a627ad1b1fc4661921e0a
Clear filters https://github.com/RustPython/RustPython/pull/8724/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8724/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8724/files
clippy.toml https://github.com/RustPython/RustPython/pull/8724/files#diff-cda2d58b87983610f47177036e953aca2ed611a47a71a0d59a94c1c074826b1b
posix.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-c4d8d17cd194261af90a2541465d39d6a285b66572131399a8690bd4c7bd599a
resource.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-8a1363cd0259a610215fa46d9ceff362c59df6a7673272405484db0b80a5f138
select.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
clippy.toml https://github.com/RustPython/RustPython/pull/8724/files#diff-379219e7520a16965f2a6570bdac48651ca0ed0423531c6cba7a0ae41071cad0
lib.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-6fa56f9fbde7b1990897c70681fff48d9644f6343b011083698dbdf4279f1916
resource.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-548354aa9b7168d64727700c282e25f17e6e216c3b8e1cb7fcecc741123ac56f
select.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
socket.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
clippy.toml https://github.com/RustPython/RustPython/pull/8724/files#diff-7a22495ab2f9208a61afee5668e7fdd36d1359d89acb53e96b2b5d028def1a39
lib.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-e4f24be92577844798ac7a19d67f9196de2e7877a3891e7a0d6fff9e5e3a9781
posix.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-8a094b07fd40ee7a3b9e440782ded748539a5214c242b6b3438421fe0d616c6e
time.rs https://github.com/RustPython/RustPython/pull/8724/files#diff-1b1beeed0db11c1262967da108e5e037aed82af263bb55882f24b1556bf8f9a5
crates/host_env/clippy.tomlhttps://github.com/RustPython/RustPython/pull/8724/files#diff-cda2d58b87983610f47177036e953aca2ed611a47a71a0d59a94c1c074826b1b
View file https://github.com/youknowone/RustPython/blob/0939989f7fb98a99555a627ad1b1fc4661921e0a/crates/host_env/clippy.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8724/{{ revealButtonHref }}
crates/host_env/src/posix.rshttps://github.com/RustPython/RustPython/pull/8724/files#diff-c4d8d17cd194261af90a2541465d39d6a285b66572131399a8690bd4c7bd599a
View file https://github.com/youknowone/RustPython/blob/0939989f7fb98a99555a627ad1b1fc4661921e0a/crates/host_env/src/posix.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8724/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8724/files#diff-c4d8d17cd194261af90a2541465d39d6a285b66572131399a8690bd4c7bd599a
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8724/files
https://github.com/RustPython/RustPython/pull/8724/files#diff-c4d8d17cd194261af90a2541465d39d6a285b66572131399a8690bd4c7bd599a
crates/host_env/src/resource.rshttps://github.com/RustPython/RustPython/pull/8724/files#diff-8a1363cd0259a610215fa46d9ceff362c59df6a7673272405484db0b80a5f138
View file https://github.com/youknowone/RustPython/blob/0939989f7fb98a99555a627ad1b1fc4661921e0a/crates/host_env/src/resource.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8724/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8724/files#diff-8a1363cd0259a610215fa46d9ceff362c59df6a7673272405484db0b80a5f138
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8724/files
https://github.com/RustPython/RustPython/pull/8724/files#diff-8a1363cd0259a610215fa46d9ceff362c59df6a7673272405484db0b80a5f138
crates/host_env/src/select.rshttps://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
View file https://github.com/youknowone/RustPython/blob/0939989f7fb98a99555a627ad1b1fc4661921e0a/crates/host_env/src/select.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8724/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8724/files
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
https://github.com/RustPython/RustPython/pull/8724/files#diff-993db34b172322281745543278a8c9e6ed4af2ee8bbf3b05ab795019ed349852
crates/stdlib/clippy.tomlhttps://github.com/RustPython/RustPython/pull/8724/files#diff-379219e7520a16965f2a6570bdac48651ca0ed0423531c6cba7a0ae41071cad0
View file https://github.com/youknowone/RustPython/blob/0939989f7fb98a99555a627ad1b1fc4661921e0a/crates/stdlib/clippy.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8724/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8724/files#diff-379219e7520a16965f2a6570bdac48651ca0ed0423531c6cba7a0ae41071cad0
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8724/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8724/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.