René's URL Explorer Experiment


Title: address review: assignment scan and wasm TLS by youknowone · Pull Request #8716 · RustPython/RustPython · GitHub

Open Graph Title: address review: assignment scan and wasm TLS by youknowone · Pull Request #8716 · RustPython/RustPython

X Title: address review: assignment scan and wasm TLS by youknowone · Pull Request #8716 · RustPython/RustPython

Description: Follow-up to #8701 review comments that landed after the squash merge. Skip # comments and lambda defaults in condition_plain_assignment Restrict the suite-header colon fallback to yield targets Capture __del__ before calling it so the unraisable names the destructor that ran Store browser _socket timeouts as f64 bits and accept integers via ArgIntoFloat Fail closed when wasm verify_mode != CERT_NONE; export getpeercert; feed MemoryBIO EOF into TLS Assisted-by: Grok:grok-4.6 Summary by CodeRabbit Bug Fixes Improved parsing of assignment targets and conditions involving suite headers, comments, and lambda expressions. Corrected object cleanup behavior so finalizers are resolved consistently. Fixed TLS connection handling, including EOF propagation and certificate verification when no trusted CA store is available. API Changes Socket timeouts now preserve fractional-second values and reject NaN or non-finite values. SSL peer certificate retrieval now uses getpeercert, returning DER data or an empty result after handshake completion.

Open Graph Description: Follow-up to #8701 review comments that landed after the squash merge. Skip # comments and lambda defaults in condition_plain_assignment Restrict the suite-header colon fallback to yield targets C...

X Description: Follow-up to #8701 review comments that landed after the squash merge. Skip # comments and lambda defaults in condition_plain_assignment Restrict the suite-header colon fallback to yield targets C...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8716

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8a958566-db44-5884-9b01-61463205d4be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6D6:3430F7:56A346:7487C2:6B00313B
html-safe-nonce77b55f4f393ab844abbed0d3f7920aa92a95f5dd88f9e142c3b97f9a5a884a15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkQ2OjM0MzBGNzo1NkEzNDY6NzQ4N0MyOjZCMDAzMTNCIiwidmlzaXRvcl9pZCI6IjkxMTI3NjExMDc3NDI4NDYwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac601f0672e0772b1f1db0cc9ce9b33c71ef1e6c7d4d802f448c7fe869a0b767ec
hovercard-subject-tagpull_request:4527699925
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8716/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altFollow-up to #8701 review comments that landed after the squash merge. Skip # comments and lambda defaults in condition_plain_assignment Restrict the suite-header colon fallback to yield targets C...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8716/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8716%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8716%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8716/files
Reloadhttps://github.com/RustPython/RustPython/pull/8716/files
Reloadhttps://github.com/RustPython/RustPython/pull/8716/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:host-env-win-ffihttps://github.com/youknowone/RustPython/tree/host-env-win-ffi
Conversation 8 https://github.com/RustPython/RustPython/pull/8716
Commits 2 https://github.com/RustPython/RustPython/pull/8716/commits
Checks 28 https://github.com/RustPython/RustPython/pull/8716/checks
Files changed https://github.com/RustPython/RustPython/pull/8716/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8716/files
address review: assignment scan and wasm TLS https://github.com/RustPython/RustPython/pull/8716/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/8716/files
73144c4 address review: assignment scan and wasm TLS youknowone Sep 14, 2026 https://github.com/RustPython/RustPython/pull/8716/commits/73144c4a75ed0934601a662eefb3aa1580d0ca64
f7e2a34 address review: parenthesized yield suite header youknowone Sep 14, 2026 https://github.com/RustPython/RustPython/pull/8716/commits/f7e2a3429a10a045503db87f74f29cb155b2e54c
Clear filters https://github.com/RustPython/RustPython/pull/8716/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8716/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8716/files
lib.rs https://github.com/RustPython/RustPython/pull/8716/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
core.rs https://github.com/RustPython/RustPython/pull/8716/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
socket.rs https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
ssl.rs https://github.com/RustPython/RustPython/pull/8716/files#diff-11379f3f27694d3a27e12111859b1a5840fd3cdf0c2e0a965a5751b633e17941
crates/compiler/src/lib.rshttps://github.com/RustPython/RustPython/pull/8716/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
View file https://github.com/youknowone/RustPython/blob/f7e2a3429a10a045503db87f74f29cb155b2e54c/crates/compiler/src/lib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8716/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8716/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
https://github.com/RustPython/RustPython/pull/8716/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
https://github.com/RustPython/RustPython/pull/8716/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
https://github.com/RustPython/RustPython/pull/8716/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
https://github.com/RustPython/RustPython/pull/8716/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
crates/vm/src/object/core.rshttps://github.com/RustPython/RustPython/pull/8716/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
View file https://github.com/youknowone/RustPython/blob/f7e2a3429a10a045503db87f74f29cb155b2e54c/crates/vm/src/object/core.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8716/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8716/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
https://github.com/RustPython/RustPython/pull/8716/files#diff-29e5bc70b379859cc90757773e821848e53dff65ce99167408b6f547bc317196
crates/wasm/src/socket.rshttps://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
View file https://github.com/youknowone/RustPython/blob/f7e2a3429a10a045503db87f74f29cb155b2e54c/crates/wasm/src/socket.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8716/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
https://github.com/RustPython/RustPython/pull/8716/files#diff-872ff4d8d22dfadefdf98aa07f116a736afeb15824a4cf5c57f30ed89e48ffc6
crates/wasm/src/ssl.rshttps://github.com/RustPython/RustPython/pull/8716/files#diff-11379f3f27694d3a27e12111859b1a5840fd3cdf0c2e0a965a5751b633e17941
View file https://github.com/youknowone/RustPython/blob/f7e2a3429a10a045503db87f74f29cb155b2e54c/crates/wasm/src/ssl.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8716/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8716/files#diff-11379f3f27694d3a27e12111859b1a5840fd3cdf0c2e0a965a5751b633e17941
https://github.com/RustPython/RustPython/pull/8716/files#diff-11379f3f27694d3a27e12111859b1a5840fd3cdf0c2e0a965a5751b633e17941
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Sep 14, 2026https://github.com/RustPython/RustPython/pull/8716/files#r4007409784
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8716/files
youknowonehttps://github.com/youknowone
Sep 14, 2026https://github.com/RustPython/RustPython/pull/8716/files#r4010151390
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8716/files
https://github.com/RustPython/RustPython/pull/8716/files#diff-11379f3f27694d3a27e12111859b1a5840fd3cdf0c2e0a965a5751b633e17941
https://github.com/RustPython/RustPython/pull/8716/files#diff-11379f3f27694d3a27e12111859b1a5840fd3cdf0c2e0a965a5751b633e17941
https://github.com/RustPython/RustPython/pull/8716/files#diff-11379f3f27694d3a27e12111859b1a5840fd3cdf0c2e0a965a5751b633e17941
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8716/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.