René's URL Explorer Experiment


Title: Stop generating a `__text_signature__` that `inspect` cannot parse by leehanjeong · Pull Request #8681 · RustPython/RustPython · GitHub

Open Graph Title: Stop generating a `__text_signature__` that `inspect` cannot parse by leehanjeong · Pull Request #8681 · RustPython/RustPython

X Title: Stop generating a `__text_signature__` that `inspect` cannot parse by leehanjeong · Pull Request #8681 · RustPython/RustPython

Description: Related #8383 This PR follows our AI policy Summary inspect.signature() raises ValueError: builtin has invalid signature for 99 method descriptors, because it parses __text_signature__ as Python source and two generated strings are not valid Python. Two unrelated causes, one commit each. Callee was reported as a parameter. The interpreter supplies it the way it supplies vm, but only vm was filtered: >>> object.__getstate__.__text_signature__ '(*args, **kwargs, callee)' # a parameter cannot follow **kwargs object.__getstate__ is the only #[pymethod] taking one today, and 95 types inherit it. infer_native_call_flags counted it as a fixed positional argument too, which FuncArgs happens to short-circuit today, so the call flags were right by accident. maketrans named its first parameter from, a Python keyword. Argument Clinic spells it frm for the same reason, so bytes.maketrans and bytearray.maketrans now report (frm, to, /), which is what CPython reports. Both parameters are positional-only, so the name is documentation only. Notes The first is a regression from #8630, which added the Callee argument. Of the 1409 methods and classmethods on the builtin types, only these 97 descriptors report a different signature. The builtin, module-function and __doc__ counts are unchanged. Summary by CodeRabbit Bug Fixes Corrected native call signature and flag handling for functions that receive interpreter-supplied callee arguments. Refactor Updated internal parameter naming for byte and bytearray translation methods without changing their behavior.

Open Graph Description: Related #8383 This PR follows our AI policy Summary inspect.signature() raises ValueError: builtin has invalid signature for 99 method descriptors, because it parses __text_signature__ as Python ...

X Description: Related #8383 This PR follows our AI policy Summary inspect.signature() raises ValueError: builtin has invalid signature for 99 method descriptors, because it parses __text_signature__ as Python ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8681

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f56ae933-5dca-62b3-a102-18d13f1abcfb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD34C:21DFED:A34179:CE9520:6B02201A
html-safe-nonce94450c52ef449ee7e33e026117f00626a60fd9ad6b82be0073c0b7f1472b86a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzRDOjIxREZFRDpBMzQxNzk6Q0U5NTIwOjZCMDIyMDFBIiwidmlzaXRvcl9pZCI6IjIzODAzMDcxNDM5NDIzNDg4MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac525fde4546bf56aaf225bc1dfe8b6029152043cb935f89fa4e68206574122ea4
hovercard-subject-tagpull_request:4486193860
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8681/files
twitter:imagehttps://avatars.githubusercontent.com/u/54920378?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/54920378?s=400&v=4
og:image:altRelated #8383 This PR follows our AI policy Summary inspect.signature() raises ValueError: builtin has invalid signature for 99 method descriptors, because it parses __text_signature__ as Python ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8681/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8681%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8681%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8681/files
Reloadhttps://github.com/RustPython/RustPython/pull/8681/files
Reloadhttps://github.com/RustPython/RustPython/pull/8681/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests130 (130)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
leehanjeong:8383-invalid-signaturehttps://github.com/leehanjeong/RustPython/tree/8383-invalid-signature
Conversation 3 https://github.com/RustPython/RustPython/pull/8681
Commits 2 https://github.com/RustPython/RustPython/pull/8681/commits
Checks 28 https://github.com/RustPython/RustPython/pull/8681/checks
Files changed https://github.com/RustPython/RustPython/pull/8681/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8681/files
Stop generating a __text_signature__ that inspect cannot parse https://github.com/RustPython/RustPython/pull/8681/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/8681/files
0bae5c0 Leave Callee out of a generated __text_signature__ leehanjeong Sep 9, 2026 https://github.com/RustPython/RustPython/pull/8681/commits/0bae5c09c9e6fb9cd472e375313085221bb96a83
f462f64 Rename maketrans's first parameter to frm leehanjeong Sep 9, 2026 https://github.com/RustPython/RustPython/pull/8681/commits/f462f642dcc579945956e37d32e0022ae29746ee
Clear filters https://github.com/RustPython/RustPython/pull/8681/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8681/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8681/files
util.rs https://github.com/RustPython/RustPython/pull/8681/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
bytearray.rs https://github.com/RustPython/RustPython/pull/8681/files#diff-bd8962db12555ddc9945c543b57069611c9b3f24f133fbf3a76c7c60fe1cfddd
bytes.rs https://github.com/RustPython/RustPython/pull/8681/files#diff-6b402f3feb41119eef6e230cb7efe615c9804a4ed5ce25dc9121ed85ed495343
crates/derive-impl/src/util.rshttps://github.com/RustPython/RustPython/pull/8681/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
View file https://github.com/leehanjeong/RustPython/blob/f462f642dcc579945956e37d32e0022ae29746ee/crates/derive-impl/src/util.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8681/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8681/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
https://github.com/RustPython/RustPython/pull/8681/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
https://github.com/RustPython/RustPython/pull/8681/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
https://github.com/RustPython/RustPython/pull/8681/files#diff-bc2426df61f173d5880449913c159a85524e8969df4743433c59436e77c3321d
crates/vm/src/builtins/bytearray.rshttps://github.com/RustPython/RustPython/pull/8681/files#diff-bd8962db12555ddc9945c543b57069611c9b3f24f133fbf3a76c7c60fe1cfddd
View file https://github.com/leehanjeong/RustPython/blob/f462f642dcc579945956e37d32e0022ae29746ee/crates/vm/src/builtins/bytearray.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8681/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8681/files#diff-bd8962db12555ddc9945c543b57069611c9b3f24f133fbf3a76c7c60fe1cfddd
https://github.com/RustPython/RustPython/pull/8681/files#diff-bd8962db12555ddc9945c543b57069611c9b3f24f133fbf3a76c7c60fe1cfddd
crates/vm/src/builtins/bytes.rshttps://github.com/RustPython/RustPython/pull/8681/files#diff-6b402f3feb41119eef6e230cb7efe615c9804a4ed5ce25dc9121ed85ed495343
View file https://github.com/leehanjeong/RustPython/blob/f462f642dcc579945956e37d32e0022ae29746ee/crates/vm/src/builtins/bytes.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8681/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8681/files#diff-6b402f3feb41119eef6e230cb7efe615c9804a4ed5ce25dc9121ed85ed495343
https://github.com/RustPython/RustPython/pull/8681/files#diff-6b402f3feb41119eef6e230cb7efe615c9804a4ed5ce25dc9121ed85ed495343
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8681/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.