René's URL Explorer Experiment


Title: common: share the bzip2 stream engine by youknowone · Pull Request #8638 · RustPython/RustPython · GitHub

Open Graph Title: common: share the bzip2 stream engine by youknowone · Pull Request #8638 · RustPython/RustPython

X Title: common: share the bzip2 stream engine by youknowone · Pull Request #8638 · RustPython/RustPython

Description: Closes #xxxx One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary Follow-up to #8631. Move the VM-independent bzip2 stream owner into a bz2-gated rustpython-common::compression::bz2 module, beside the zlib and lzma engines, and keep rustpython-stdlib as the Python object and exception adapter. The adapter no longer names the bzip2 crate — the bz2 feature carries it. _bz2 was the last user of the generic DecompressState / DecompressStatus / Decompressor machinery in crates/stdlib/src/compression.rs, so that goes with it. DecompressArgs stays, since zlib and lzma still use it. The common layer owns byte buffers, stream state, and a plain Bz2Error whose four variants map to the exceptions Modules/_bz2module.c raises. The decompressor feeds input through the existing Chunker rather than joining buffered and freshly supplied bytes into a new allocation on every call, which is what the zlib engine already does. test_decompress_after_data_error passes on the ported engine, so its expectedFailure marker goes. Validation Run on macOS aarch64: cargo test -p rustpython-common --features bz2 — 78 passed, 0 failed cargo check -p rustpython-stdlib cargo clippy --all-targets -- -D warnings cargo build --release ./target/release/rustpython -m test test_bz2 — run=102, skipped=1, SUCCESS AI disclosure The engine port was written by Grok (grok-4.6) from a written specification, and reviewed against Modules/_bz2module.c — in particular the eof / needs_input / unused_data transitions, which follow the same eof → avail_in == 0 → otherwise order as decompress() there — and against the checks listed above. Summary by CodeRabbit New Features Added bzip2 compression and decompression support to the shared compression engine. Added streaming compression and decompression with output limits, EOF tracking, trailing-data handling, and error reporting. Bug Fixes Improved handling of invalid decompression input and negative output-length limits. Standardized bzip2 behavior across supported compression interfaces. Refactor Updated the standard-library bzip2 module to use the shared compression implementation.

Open Graph Description: Closes #xxxx One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary Follow-up to #8631. Move the VM-independent bzip2 st...

X Description: Closes #xxxx One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary Follow-up to #8631. Move the VM-independent bzip2 st...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8638

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c104c53-7802-3034-8ae8-082d0fbf961a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EA8:14EB6E:19BCA4F:21CE766:6B020F72
html-safe-noncebdb17c0b4a72f3115d1ad7aed84f48a4312f777e86182fc278d5a7a7c3b9ae35
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUE4OjE0RUI2RToxOUJDQTRGOjIxQ0U3NjY6NkIwMjBGNzIiLCJ2aXNpdG9yX2lkIjoiODMzMTc2ODk3OTEwMzQ1NTg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1ec2bce31900569a88fb589af4ce650f13797f3b64274128568f99617a60f896
hovercard-subject-tagpull_request:4421157255
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8638/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altCloses #xxxx One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary Follow-up to #8631. Move the VM-independent bzip2 st...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8638/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8638%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8638%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8638/files
Reloadhttps://github.com/RustPython/RustPython/pull/8638/files
Reloadhttps://github.com/RustPython/RustPython/pull/8638/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:common-bz2-enginehttps://github.com/youknowone/RustPython/tree/common-bz2-engine
Conversation 5 https://github.com/RustPython/RustPython/pull/8638
Commits 1 https://github.com/RustPython/RustPython/pull/8638/commits
Checks 30 https://github.com/RustPython/RustPython/pull/8638/checks
Files changed https://github.com/RustPython/RustPython/pull/8638/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8638/files
common: share the bzip2 stream engine https://github.com/RustPython/RustPython/pull/8638/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8638/files
b991bcc common: share the bzip2 stream engine youknowone Sep 1, 2026 https://github.com/RustPython/RustPython/pull/8638/commits/b991bccce4a5a2074f0daf4a828681f58b817799
Clear filters https://github.com/RustPython/RustPython/pull/8638/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8638/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8638/files
Cargo.lock https://github.com/RustPython/RustPython/pull/8638/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
test_bz2.py https://github.com/RustPython/RustPython/pull/8638/files#diff-25018b1e1b3efce8819bad84e95a0f090c29dabfd095639626b5dcfd04ed3d20
Cargo.toml https://github.com/RustPython/RustPython/pull/8638/files#diff-67449309128bb90a86efa4567e238536ea0f347ae18098f8dbcd747de5b7b4ca
bz2.rs https://github.com/RustPython/RustPython/pull/8638/files#diff-8699d1221d7a94ddae08efb1c911808fe1b3678e75ccf66888d89d4e97babfa9
mod.rs https://github.com/RustPython/RustPython/pull/8638/files#diff-f2d3c2ab43fccf4482a1f36427b611c4f7df39bc55f8cbaeaa1cc63e6f3e4fd8
lib.rs https://github.com/RustPython/RustPython/pull/8638/files#diff-84e11d13acaf28044921bb5a427cfbf511c70a0b3881949137ba4093df58e266
Cargo.toml https://github.com/RustPython/RustPython/pull/8638/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
bz2.rs https://github.com/RustPython/RustPython/pull/8638/files#diff-b67f7ab6fc871703cff823273963dbf0d74349400705ca6c4da549cb9e7510cc
compression.rs https://github.com/RustPython/RustPython/pull/8638/files#diff-fb0ac6165d435493262f9815232030893481fcfdd2830c7efca99301d5c53acb
Cargo.lockhttps://github.com/RustPython/RustPython/pull/8638/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
View file https://github.com/youknowone/RustPython/blob/b991bccce4a5a2074f0daf4a828681f58b817799/Cargo.lock
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8638/files
Lib/test/test_bz2.pyhttps://github.com/RustPython/RustPython/pull/8638/files#diff-25018b1e1b3efce8819bad84e95a0f090c29dabfd095639626b5dcfd04ed3d20
View file https://github.com/youknowone/RustPython/blob/b991bccce4a5a2074f0daf4a828681f58b817799/Lib/test/test_bz2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8638/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8638/files#diff-25018b1e1b3efce8819bad84e95a0f090c29dabfd095639626b5dcfd04ed3d20
https://github.com/RustPython/RustPython/pull/8638/files#diff-25018b1e1b3efce8819bad84e95a0f090c29dabfd095639626b5dcfd04ed3d20
crates/common/Cargo.tomlhttps://github.com/RustPython/RustPython/pull/8638/files#diff-67449309128bb90a86efa4567e238536ea0f347ae18098f8dbcd747de5b7b4ca
View file https://github.com/youknowone/RustPython/blob/b991bccce4a5a2074f0daf4a828681f58b817799/crates/common/Cargo.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8638/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8638/files#diff-67449309128bb90a86efa4567e238536ea0f347ae18098f8dbcd747de5b7b4ca
https://github.com/RustPython/RustPython/pull/8638/files#diff-67449309128bb90a86efa4567e238536ea0f347ae18098f8dbcd747de5b7b4ca
https://github.com/RustPython/RustPython/pull/8638/files#diff-67449309128bb90a86efa4567e238536ea0f347ae18098f8dbcd747de5b7b4ca
crates/common/src/compression/bz2.rshttps://github.com/RustPython/RustPython/pull/8638/files#diff-8699d1221d7a94ddae08efb1c911808fe1b3678e75ccf66888d89d4e97babfa9
View file https://github.com/youknowone/RustPython/blob/b991bccce4a5a2074f0daf4a828681f58b817799/crates/common/src/compression/bz2.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8638/{{ revealButtonHref }}
coderabbitaihttps://github.com/apps/coderabbitai
Sep 2, 2026https://github.com/RustPython/RustPython/pull/8638/files#r3913168456
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ftp.gwdg.de/pub/linux/sources.redhat.com/bzip2/docs/manual_3.htmlhttps://ftp.gwdg.de/pub/linux/sources.redhat.com/bzip2/docs/manual_3.html
https://docs.rs/bzip2/latest/bzip2/https://docs.rs/bzip2/latest/bzip2/
http://labmaster.mi.infn.it/wwwasdoc.web.cern.ch/wwwasdoc/TL8/texmf/doc/html/bzip2/manual_3.htmlhttp://labmaster.mi.infn.it/wwwasdoc.web.cern.ch/wwwasdoc/TL8/texmf/doc/html/bzip2/manual_3.html
https://pipeline.lbl.gov/code/3rd_party/licenses.win/bzip2-1.0.5/manual.pdfhttps://pipeline.lbl.gov/code/3rd_party/licenses.win/bzip2-1.0.5/manual.pdf
https://docs.rs/bzip2/latest/bzip2/struct.Decompress.htmlhttps://docs.rs/bzip2/latest/bzip2/struct.Decompress.html
https://crates.io/crates/bzip2-rshttps://crates.io/crates/bzip2-rs
https://docs.rs/bzip2-rs/latest/bzip2_rs/decoder/struct.DecoderReader.htmlhttps://docs.rs/bzip2-rs/latest/bzip2_rs/decoder/struct.DecoderReader.html
https://docs.rs/bzip2-rs/latest/src/bzip2_rs/decoder/mod.rs.htmlhttps://docs.rs/bzip2-rs/latest/src/bzip2_rs/decoder/mod.rs.html
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8638/files
crates/common/src/compression/mod.rshttps://github.com/RustPython/RustPython/pull/8638/files#diff-f2d3c2ab43fccf4482a1f36427b611c4f7df39bc55f8cbaeaa1cc63e6f3e4fd8
View file https://github.com/youknowone/RustPython/blob/b991bccce4a5a2074f0daf4a828681f58b817799/crates/common/src/compression/mod.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8638/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8638/files#diff-f2d3c2ab43fccf4482a1f36427b611c4f7df39bc55f8cbaeaa1cc63e6f3e4fd8
https://github.com/RustPython/RustPython/pull/8638/files#diff-f2d3c2ab43fccf4482a1f36427b611c4f7df39bc55f8cbaeaa1cc63e6f3e4fd8
crates/common/src/lib.rshttps://github.com/RustPython/RustPython/pull/8638/files#diff-84e11d13acaf28044921bb5a427cfbf511c70a0b3881949137ba4093df58e266
View file https://github.com/youknowone/RustPython/blob/b991bccce4a5a2074f0daf4a828681f58b817799/crates/common/src/lib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8638/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8638/files#diff-84e11d13acaf28044921bb5a427cfbf511c70a0b3881949137ba4093df58e266
https://github.com/RustPython/RustPython/pull/8638/files#diff-84e11d13acaf28044921bb5a427cfbf511c70a0b3881949137ba4093df58e266
crates/stdlib/Cargo.tomlhttps://github.com/RustPython/RustPython/pull/8638/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
View file https://github.com/youknowone/RustPython/blob/b991bccce4a5a2074f0daf4a828681f58b817799/crates/stdlib/Cargo.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8638/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8638/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
https://github.com/RustPython/RustPython/pull/8638/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
https://github.com/RustPython/RustPython/pull/8638/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
https://github.com/RustPython/RustPython/actions/runs/33619134950/job/100211949992?pr=8638
https://github.com/RustPython/RustPython/pull/8638/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
https://github.com/RustPython/RustPython/actions/runs/33619134950/job/100211949992?pr=8638
https://github.com/RustPython/RustPython/actions/runs/33619134950/job/100211949992?pr=8638
https://github.com/RustPython/RustPython/pull/8638/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8638/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8638/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.