| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e42e089e-24bc-3fb9-65ef-3c0a99c35714 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A88E:16AB79:3596F56:44274C5:6B01E641 |
| html-safe-nonce | ab7ef3db135b7de226b5cf30d286e7301e5ec4d50a00f4ed533dd3d39909afc5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODhFOjE2QUI3OTozNTk2RjU2OjQ0Mjc0QzU6NkIwMUU2NDEiLCJ2aXNpdG9yX2lkIjoiNTM4MzQ1OTM0OTQ1NDc3NTg3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 47b2125f84dbc4ae71dc5029edbd4e5b9fdc6faf09d0b1339cdec107333aac07 |
| hovercard-subject-tag | pull_request:4308969944 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/8554/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/41b4cd0a5e1ac1ac71debe0e89ade617e10076971842dd196bec6a68deeb0a97/RustPython/RustPython/pull/8554 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/41b4cd0a5e1ac1ac71debe0e89ade617e10076971842dd196bec6a68deeb0a97/RustPython/RustPython/pull/8554 |
| og:image:alt | winsound.rs kept three imports it stopped using in #8245:
WideCString::from_vec rejects interior NULs itself, so the explicit
exceptions::nul_char_error check and the to_wide_with_nul call feeding ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youknowone |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/RustPython/RustPython/pull/8554#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8554 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8554 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/8554 |
| Reload | https://github.com/RustPython/RustPython/pull/8554 |
| Reload | https://github.com/RustPython/RustPython/pull/8554 |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests133 (133) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| https://github.com/RustPython/RustPython |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowone:lock-detach-on-contention | https://github.com/youknowone/RustPython/tree/lock-detach-on-contention |
| Conversation | https://github.com/RustPython/RustPython/pull/8554 |
| Commits1 (1) | https://github.com/RustPython/RustPython/pull/8554/commits |
| Checks | https://github.com/RustPython/RustPython/pull/8554/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/8554/files |
| winsound: drop the imports the NUL-safe PlaySound left behind | https://github.com/RustPython/RustPython/pull/8554#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowone:lock-detach-on-contention | https://github.com/youknowone/RustPython/tree/lock-detach-on-contention |
|
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Aug 18, 2026 | https://github.com/RustPython/RustPython/pull/8554#issue-5186951410 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
| #8245 | https://github.com/RustPython/RustPython/pull/8245 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Aug 18, 2026 | https://github.com/RustPython/RustPython/pull/8554#issuecomment-5334927004 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
| https://app.coderabbit.ai/change-stack/RustPython/RustPython/pull/8554?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack |
| RustPython/RustPython#7416 | https://github.com/RustPython/RustPython/pull/7416 |
| RustPython/RustPython#8517 | https://github.com/RustPython/RustPython/pull/8517 |
| RustPython/RustPython#8524 | https://github.com/RustPython/RustPython/pull/8524 |
| CodeRabbit | https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=RustPython/RustPython&utm_content=8554 |
| X | https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai |
| Mastodon | https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai |
| Reddit | https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai |
| LinkedIn | https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Aug 18, 2026
| https://github.com/RustPython/RustPython/pull/8554#pullrequestreview-4966586439 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/8554/files |
| coderabbitai | https://github.com/apps/coderabbitai |
| https://github.com/RustPython/RustPython/pull/8554#pullrequestreview-4966586439 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 419a0b2 | https://github.com/RustPython/RustPython/commit/419a0b228d23d9c26def43128d4a5f98d0104302 |
| f46be1c | https://github.com/RustPython/RustPython/commit/f46be1c99da3e349f166fa49639e59d3eb64c112 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
| crates/vm/src/vm/mod.rs | https://github.com/RustPython/RustPython/pull/8554/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74 |
| coderabbitai | https://github.com/apps/coderabbitai |
| Aug 18, 2026 | https://github.com/RustPython/RustPython/pull/8554#discussion_r3808597775 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/f46be1c99da3e349f166fa49639e59d3eb64c112..c31a19e0ca7d831deab0f06e704459b2aabd4c55 |
| f46be1c | https://github.com/RustPython/RustPython/commit/f46be1c99da3e349f166fa49639e59d3eb64c112 |
| c31a19e | https://github.com/RustPython/RustPython/commit/c31a19e0ca7d831deab0f06e704459b2aabd4c55 |
|
Compare
| https://github.com/RustPython/RustPython/compare/f46be1c99da3e349f166fa49639e59d3eb64c112..c31a19e0ca7d831deab0f06e704459b2aabd4c55 |
| August 18, 2026 23:10 | https://github.com/RustPython/RustPython/pull/8554#event-29650940528 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Aug 18, 2026
| https://github.com/RustPython/RustPython/pull/8554#pullrequestreview-4966891918 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/8554/files |
| coderabbitai | https://github.com/apps/coderabbitai |
| https://github.com/RustPython/RustPython/pull/8554#pullrequestreview-4966891918 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| f46be1c | https://github.com/RustPython/RustPython/commit/f46be1c99da3e349f166fa49639e59d3eb64c112 |
| c31a19e | https://github.com/RustPython/RustPython/commit/c31a19e0ca7d831deab0f06e704459b2aabd4c55 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
|
| https://github.com/youknowone |
| winsound: drop the imports the NUL-safe PlaySound left behind | https://github.com/RustPython/RustPython/pull/8554/commits/3368d3a5744d137128f31116c2896f450252a74d |
| 3368d3a | https://github.com/RustPython/RustPython/pull/8554/commits/3368d3a5744d137128f31116c2896f450252a74d |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/c31a19e0ca7d831deab0f06e704459b2aabd4c55..3368d3a5744d137128f31116c2896f450252a74d |
| c31a19e | https://github.com/RustPython/RustPython/commit/c31a19e0ca7d831deab0f06e704459b2aabd4c55 |
| 3368d3a | https://github.com/RustPython/RustPython/commit/3368d3a5744d137128f31116c2896f450252a74d |
|
Compare
| https://github.com/RustPython/RustPython/compare/c31a19e0ca7d831deab0f06e704459b2aabd4c55..3368d3a5744d137128f31116c2896f450252a74d |
| August 19, 2026 00:49 | https://github.com/RustPython/RustPython/pull/8554#event-29654101957 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Aug 19, 2026 | https://github.com/RustPython/RustPython/pull/8554#event-29654108352 |
| https://github.com/joshuamegnauth54 |
| joshuamegnauth54 | https://github.com/joshuamegnauth54 |
|
Aug 19, 2026
| https://github.com/RustPython/RustPython/pull/8554#ref-pullrequest-5188186810 |
|
host_env: Reject interior NULs for CreateProcessW
#8555
| https://github.com/RustPython/RustPython/pull/8555 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| ee0bb64 | https://github.com/RustPython/RustPython/commit/ee0bb649bcade0cffef9ccc7c6ed5e75c7ff8cb7 |
| Aug 19, 2026 | https://github.com/RustPython/RustPython/pull/8554#event-29659868489 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| August 19, 2026 04:12 | https://github.com/RustPython/RustPython/pull/8554#event-29659869572 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Aug 19, 2026
| https://github.com/RustPython/RustPython/pull/8554#ref-pullrequest-5188970330 |
|
lock: add an opt-in rwlock that detaches before it blocks
#8556
| https://github.com/RustPython/RustPython/pull/8556 |
| youknowone | https://github.com/youknowone |
|
Sep 16, 2026
| https://github.com/RustPython/RustPython/pull/8554#ref-commit-a0eec84 |
|
| https://github.com/youknowone |
| winsound: drop the imports the NUL-safe PlaySound left behind ( | https://github.com/RustPython/RustPython/commit/a0eec84cb01cd2509520107f1e77ed3d5bd64caf |
| #8554 | https://github.com/RustPython/RustPython/pull/8554 |
| ) | https://github.com/RustPython/RustPython/commit/a0eec84cb01cd2509520107f1e77ed3d5bd64caf |
| a0eec84 | https://github.com/RustPython/RustPython/commit/a0eec84cb01cd2509520107f1e77ed3d5bd64caf |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8554 |
|
| https://github.com/apps/coderabbitai |
|
coderabbitai[bot]
| https://github.com/apps/coderabbitai |
|
| https://github.com/RustPython/RustPython/pull/8554/files/c31a19e0ca7d831deab0f06e704459b2aabd4c55 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8554 |
|
| https://github.com/youknowone |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |