René's URL Explorer Experiment


Title: Per-interpreter runtime state and a process-wide GC stop-the-world by youknowone · Pull Request #8517 · RustPython/RustPython · GitHub

Open Graph Title: Per-interpreter runtime state and a process-wide GC stop-the-world by youknowone · Pull Request #8517 · RustPython/RustPython

X Title: Per-interpreter runtime state and a process-wide GC stop-the-world by youknowone · Pull Request #8517 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: Groundwork for multiple interpreters (PEP 734 / PEP 684), plus a GC data race that having more than one interpreter exposes. No Python-facing API is added yet: sys.implementation.supports_isolated_...

X Description: Groundwork for multiple interpreters (PEP 734 / PEP 684), plus a GC data race that having more than one interpreter exposes. No Python-facing API is added yet: sys.implementation.supports_isolated_...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8517

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:fd9925b6-c4cc-4281-e1a9-589822560bab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE15C:E0ADF:C6563D:FB1DEC:6B01E6E7
html-safe-nonce0f98a0dc6447a63cbc0657d9813c0d61eb5cdc3e2b774ce68b77699b2f93cff1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTVDOkUwQURGOkM2NTYzRDpGQjFERUM6NkIwMUU2RTciLCJ2aXNpdG9yX2lkIjoiNjU3NzE2NzkyNTA4ODc0MTA5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace16e08ea595971e53e7de9f080b8baefe8a4d209d054366feed8fe91f8fdad7e
hovercard-subject-tagpull_request:4273814965
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8517/commits
twitter:imagehttps://opengraph.githubassets.com/410a8cb566bb78f0361569b6c96f3efc79df1f3f42b27b2549e7bb6e77b7ea61/RustPython/RustPython/pull/8517
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/410a8cb566bb78f0361569b6c96f3efc79df1f3f42b27b2549e7bb6e77b7ea61/RustPython/RustPython/pull/8517
og:image:altGroundwork for multiple interpreters (PEP 734 / PEP 684), plus a GC data race that having more than one interpreter exposes. No Python-facing API is added yet: sys.implementation.supports_isolated_...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyouknowone
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8517/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8517%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8517%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8517/commits
Reloadhttps://github.com/RustPython/RustPython/pull/8517/commits
Reloadhttps://github.com/RustPython/RustPython/pull/8517/commits
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:subinterpreter-foundationhttps://github.com/youknowone/RustPython/tree/subinterpreter-foundation
Conversationhttps://github.com/RustPython/RustPython/pull/8517
Commits27 (27)https://github.com/RustPython/RustPython/pull/8517/commits
Checkshttps://github.com/RustPython/RustPython/pull/8517/checks
Files changedhttps://github.com/RustPython/RustPython/pull/8517/files
Per-interpreter runtime state and a process-wide GC stop-the-worldhttps://github.com/RustPython/RustPython/pull/8517/commits#top
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:subinterpreter-foundationhttps://github.com/youknowone/RustPython/tree/subinterpreter-foundation
vm: add per-interpreter runtime state and interpreter registryhttps://github.com/RustPython/RustPython/pull/8517/commits/5c341d263e9b14263fa2b77046c2d46a2bd44f2c
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
5c341d2https://github.com/RustPython/RustPython/pull/8517/commits/5c341d263e9b14263fa2b77046c2d46a2bd44f2c
https://github.com/RustPython/RustPython/tree/5c341d263e9b14263fa2b77046c2d46a2bd44f2c
gc: stop every interpreter while collectinghttps://github.com/RustPython/RustPython/pull/8517/commits/43f4b23314e703ace272352f26326f2db97414c0
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
43f4b23https://github.com/RustPython/RustPython/pull/8517/commits/43f4b23314e703ace272352f26326f2db97414c0
https://github.com/RustPython/RustPython/tree/43f4b23314e703ace272352f26326f2db97414c0
vm: scope the interpreter registry per thread without threadinghttps://github.com/RustPython/RustPython/pull/8517/commits/ffd3d1e4255ba91704188198e603eadce25708b4
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
ffd3d1ehttps://github.com/RustPython/RustPython/pull/8517/commits/ffd3d1e4255ba91704188198e603eadce25708b4
https://github.com/RustPython/RustPython/tree/ffd3d1e4255ba91704188198e603eadce25708b4
vm: keep the interpreter registry usable across bootstrap, drop and forkhttps://github.com/RustPython/RustPython/pull/8517/commits/007999421df736597e834a757d617ddb1bcb00be
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
0079994https://github.com/RustPython/RustPython/pull/8517/commits/007999421df736597e834a757d617ddb1bcb00be
https://github.com/RustPython/RustPython/tree/007999421df736597e834a757d617ddb1bcb00be
vm: attach and detach thread slots when switching interpretershttps://github.com/RustPython/RustPython/pull/8517/commits/8f108ff1931c3b01a335d03c682845e28a882926
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
8f108ffhttps://github.com/RustPython/RustPython/pull/8517/commits/8f108ff1931c3b01a335d03c682845e28a882926
https://github.com/RustPython/RustPython/tree/8f108ff1931c3b01a335d03c682845e28a882926
vm: list only the current interpreter's subclasseshttps://github.com/RustPython/RustPython/pull/8517/commits/696a8c1011eec373ef6bb926d0f0a4b53635e45f
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
696a8c1https://github.com/RustPython/RustPython/pull/8517/commits/696a8c1011eec373ef6bb926d0f0a4b53635e45f
https://github.com/RustPython/RustPython/tree/696a8c1011eec373ef6bb926d0f0a4b53635e45f
gc: give each interpreter its own collector statehttps://github.com/RustPython/RustPython/pull/8517/commits/562b6579912c33cbf19fdf9dc43063a1a865d76f
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
562b657https://github.com/RustPython/RustPython/pull/8517/commits/562b6579912c33cbf19fdf9dc43063a1a865d76f
https://github.com/RustPython/RustPython/tree/562b6579912c33cbf19fdf9dc43063a1a865d76f
_queue, _thread: detach before taking locks held across waitshttps://github.com/RustPython/RustPython/pull/8517/commits/30e202019e2ba90e33ccffdbdded9c8fece154c2
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
30e2020https://github.com/RustPython/RustPython/pull/8517/commits/30e202019e2ba90e33ccffdbdded9c8fece154c2
https://github.com/RustPython/RustPython/tree/30e202019e2ba90e33ccffdbdded9c8fece154c2
_io, _winapi: detach on the remaining stopped-holdable lock takeshttps://github.com/RustPython/RustPython/pull/8517/commits/5ce062e18758fa9c3afe165ccb60cb88c1379d11
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
5ce062ehttps://github.com/RustPython/RustPython/pull/8517/commits/5ce062e18758fa9c3afe165ccb60cb88c1379d11
https://github.com/RustPython/RustPython/tree/5ce062e18758fa9c3afe165ccb60cb88c1379d11
gc: size the interpreter owner tag to the header paddinghttps://github.com/RustPython/RustPython/pull/8517/commits/87b6c6852f0419e958fff8707c3da4d04d6d7f15
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
87b6c68https://github.com/RustPython/RustPython/pull/8517/commits/87b6c6852f0419e958fff8707c3da4d04d6d7f15
https://github.com/RustPython/RustPython/tree/87b6c6852f0419e958fff8707c3da4d04d6d7f15
vm: reuse cleared frame blocks and shorten interpreter hot pathshttps://github.com/RustPython/RustPython/pull/8517/commits/fd279028934778d48372d1e4f015b869ba2cf550
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
fd27902https://github.com/RustPython/RustPython/pull/8517/commits/fd279028934778d48372d1e4f015b869ba2cf550
https://github.com/RustPython/RustPython/tree/fd279028934778d48372d1e4f015b869ba2cf550
gc, vm: address review notes on owner tags and interpreter docshttps://github.com/RustPython/RustPython/pull/8517/commits/c3fcc702e09d474abfdc10b56711114a41066a7d
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
c3fcc70https://github.com/RustPython/RustPython/pull/8517/commits/c3fcc702e09d474abfdc10b56711114a41066a7d
https://github.com/RustPython/RustPython/tree/c3fcc702e09d474abfdc10b56711114a41066a7d
vm: gate interpreter registration on stop-the-world admissionhttps://github.com/RustPython/RustPython/pull/8517/commits/57428cd92e4eca2df9d2818ae78847423ce86199
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
57428cdhttps://github.com/RustPython/RustPython/pull/8517/commits/57428cd92e4eca2df9d2818ae78847423ce86199
https://github.com/RustPython/RustPython/tree/57428cd92e4eca2df9d2818ae78847423ce86199
gc: keep the tracking counters off the barrier pathhttps://github.com/RustPython/RustPython/pull/8517/commits/8d07831d8828ac6a84b2ee61242da5d99fbed7f4
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
8d07831https://github.com/RustPython/RustPython/pull/8517/commits/8d07831d8828ac6a84b2ee61242da5d99fbed7f4
https://github.com/RustPython/RustPython/tree/8d07831d8828ac6a84b2ee61242da5d99fbed7f4
dict: settle lookups and iteration steps under one read guardhttps://github.com/RustPython/RustPython/pull/8517/commits/4e518d362e4c23819f09db7c33b24fd2036ede32
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
4e518d3https://github.com/RustPython/RustPython/pull/8517/commits/4e518d362e4c23819f09db7c33b24fd2036ede32
https://github.com/RustPython/RustPython/tree/4e518d362e4c23819f09db7c33b24fd2036ede32
vm: build a call's argument vector oncehttps://github.com/RustPython/RustPython/pull/8517/commits/eb94dafe3fb87a1c15f05a1570af30fb2429867a
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
eb94dafhttps://github.com/RustPython/RustPython/pull/8517/commits/eb94dafe3fb87a1c15f05a1570af30fb2429867a
https://github.com/RustPython/RustPython/tree/eb94dafe3fb87a1c15f05a1570af30fb2429867a
vm: reach an instance dict without cloning ithttps://github.com/RustPython/RustPython/pull/8517/commits/f70db351e2b009044024f24ed9b45df9b401f5c1
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
f70db35https://github.com/RustPython/RustPython/pull/8517/commits/f70db351e2b009044024f24ed9b45df9b401f5c1
https://github.com/RustPython/RustPython/tree/f70db351e2b009044024f24ed9b45df9b401f5c1
vm: shorten the per-instruction safepoint and the call preamblehttps://github.com/RustPython/RustPython/pull/8517/commits/4a76424812ea9fe088c141fdaae262a3dc2a4c7b
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
4a76424https://github.com/RustPython/RustPython/pull/8517/commits/4a76424812ea9fe088c141fdaae262a3dc2a4c7b
https://github.com/RustPython/RustPython/tree/4a76424812ea9fe088c141fdaae262a3dc2a4c7b
vm: give KwArgs a zero-sized hasherhttps://github.com/RustPython/RustPython/pull/8517/commits/b0f0dcc5b7a20b38a96f3e84009a6bff7d996f58
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
b0f0dcchttps://github.com/RustPython/RustPython/pull/8517/commits/b0f0dcc5b7a20b38a96f3e84009a6bff7d996f58
https://github.com/RustPython/RustPython/tree/b0f0dcc5b7a20b38a96f3e84009a6bff7d996f58
vm: promote borrowed stack refs before a yieldhttps://github.com/RustPython/RustPython/pull/8517/commits/f9bbc6d5a17aad3e74c97b52fba48ef7a638ad24
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
f9bbc6dhttps://github.com/RustPython/RustPython/pull/8517/commits/f9bbc6d5a17aad3e74c97b52fba48ef7a638ad24
https://github.com/RustPython/RustPython/tree/f9bbc6d5a17aad3e74c97b52fba48ef7a638ad24
vm: run the exact-args vectorcall on a heap frame againhttps://github.com/RustPython/RustPython/pull/8517/commits/b4bb43c91c123a4c054d174784adc5bdc2bab978
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
b4bb43chttps://github.com/RustPython/RustPython/pull/8517/commits/b4bb43c91c123a4c054d174784adc5bdc2bab978
https://github.com/RustPython/RustPython/tree/b4bb43c91c123a4c054d174784adc5bdc2bab978
vm: release a tail call's function at the callee's returnhttps://github.com/RustPython/RustPython/pull/8517/commits/98d24105f51f643961dc074196c0994a0b45502e
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
98d2410https://github.com/RustPython/RustPython/pull/8517/commits/98d24105f51f643961dc074196c0994a0b45502e
https://github.com/RustPython/RustPython/tree/98d24105f51f643961dc074196c0994a0b45502e
vm: stop copying a running frame's locals when it materializeshttps://github.com/RustPython/RustPython/pull/8517/commits/08bd522adf579a349ffca71ae8a7c780a672587b
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
08bd522https://github.com/RustPython/RustPython/pull/8517/commits/08bd522adf579a349ffca71ae8a7c780a672587b
https://github.com/RustPython/RustPython/tree/08bd522adf579a349ffca71ae8a7c780a672587b
vm: key data stack frame reuse on the exact frame sizehttps://github.com/RustPython/RustPython/pull/8517/commits/c7c1452a4f83d2e8528d6953ef392c07a456708c
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
c7c1452https://github.com/RustPython/RustPython/pull/8517/commits/c7c1452a4f83d2e8528d6953ef392c07a456708c
https://github.com/RustPython/RustPython/tree/c7c1452a4f83d2e8528d6953ef392c07a456708c
vm: store the frame object payload address in the cross-thread slothttps://github.com/RustPython/RustPython/pull/8517/commits/2d58fc82e7b7c7f27fa8cd7eb86235135d48fef7
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
2d58fc8https://github.com/RustPython/RustPython/pull/8517/commits/2d58fc82e7b7c7f27fa8cd7eb86235135d48fef7
https://github.com/RustPython/RustPython/tree/2d58fc82e7b7c7f27fa8cd7eb86235135d48fef7
vm: copy a foreign thread's frames instead of linking themhttps://github.com/RustPython/RustPython/pull/8517/commits/e24d8319f72160fe637653f98d7eee906527c643
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
e24d831https://github.com/RustPython/RustPython/pull/8517/commits/e24d8319f72160fe637653f98d7eee906527c643
https://github.com/RustPython/RustPython/tree/e24d8319f72160fe637653f98d7eee906527c643
vm: resolve the two rustdoc links this branch addedhttps://github.com/RustPython/RustPython/pull/8517/commits/5d0d9beddc931caa1f5e2ccb31f8c253c4508228
https://github.com/youknowone
youknowonehttps://github.com/RustPython/RustPython/commits?author=youknowone
5d0d9behttps://github.com/RustPython/RustPython/pull/8517/commits/5d0d9beddc931caa1f5e2ccb31f8c253c4508228
https://github.com/RustPython/RustPython/tree/5d0d9beddc931caa1f5e2ccb31f8c253c4508228
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.