René's URL Explorer Experiment


Title: codegen: preserve symbol tables across copied finally bodies by youknowone · Pull Request #8507 · RustPython/RustPython · GitHub

Open Graph Title: codegen: preserve symbol tables across copied finally bodies by youknowone · Pull Request #8507 · RustPython/RustPython

X Title: codegen: preserve symbol tables across copied finally bodies by youknowone · Pull Request #8507 · RustPython/RustPython

Description: Summary preserve the current symbol-table cursors while codegen emits the extra copy of a finally body used by an early return, break, or continue add coverage for lambdas, comprehensions, nested functions, and nested classes in copied finally bodies Root cause Leaving a try block early compiles its finally body once for the early-exit path and again for the statement's normal cleanup paths. The first copy consumed the nested-scope symbol-table cursors. When the later copy reached a comprehension or another nested scope, codegen reported SyntaxError: no symbol table available. Saving and restoring all three cursor components around the early-exit copy makes that speculative emission cursor-neutral, matching the existing treatment of duplicated codegen paths. This surfaced while importing pytest: _pytest/pytester.py has a generator hook that returns from a try and uses comprehensions in finally. Validation cargo fmt --all -- --check cargo clippy --workspace --exclude rustpython_wasm --exclude rustpython-venvlauncher --exclude rustpython-capi --all-targets cargo test --workspace --exclude rustpython_wasm --exclude rustpython-venvlauncher --exclude rustpython-capi (cd crates/capi && cargo test) — 102 passed CI-equivalent release build with threading,jit and the explicit stdlib/sqlite/rustls feature set extra_tests: 410 passed byte-compiled pytest 9.1.1's _pytest/pytester.py Summary by CodeRabbit Bug Fixes Fixed try/finally handling to preserve correct behavior after returns, breaks, and continues. Ensured finally blocks execute exactly once during returns. Corrected generator behavior when returning from try blocks, including proper StopIteration values. Preserved nested comprehension and scope behavior in duplicated finally code. Tests Added regression coverage for control flow, generators, nested scopes, and try/finally execution.

Open Graph Description: Summary preserve the current symbol-table cursors while codegen emits the extra copy of a finally body used by an early return, break, or continue add coverage for lambdas, comprehensions, nested ...

X Description: Summary preserve the current symbol-table cursors while codegen emits the extra copy of a finally body used by an early return, break, or continue add coverage for lambdas, comprehensions, nested ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8507

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d667d006-0a4e-e968-5d1a-b42a03d5578a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5D4:9E1B2:2FE60C6:3F61191:6B0029BC
html-safe-noncebb136d8f1f4cf8d90207cd72c9ac0ce22094cb7e4c2b2583d45c5caf6ca52182
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUQ0OjlFMUIyOjJGRTYwQzY6M0Y2MTE5MTo2QjAwMjlCQyIsInZpc2l0b3JfaWQiOiI2MzkzOTI2ODQzMzcxNjI4OTg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac64c63021039264df8c4650eaa9af652eeeea3e2b9ae0695419ac884301d40b42
hovercard-subject-tagpull_request:4267248629
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8507/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altSummary preserve the current symbol-table cursors while codegen emits the extra copy of a finally body used by an early return, break, or continue add coverage for lambdas, comprehensions, nested ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8507/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8507%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8507%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8507/files
Reloadhttps://github.com/RustPython/RustPython/pull/8507/files
Reloadhttps://github.com/RustPython/RustPython/pull/8507/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:agent/finally-symbol-table-cursorshttps://github.com/youknowone/RustPython/tree/agent/finally-symbol-table-cursors
Conversation 1 https://github.com/RustPython/RustPython/pull/8507
Commits 1 https://github.com/RustPython/RustPython/pull/8507/commits
Checks 27 https://github.com/RustPython/RustPython/pull/8507/checks
Files changed https://github.com/RustPython/RustPython/pull/8507/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8507/files
codegen: preserve symbol tables across copied finally bodies https://github.com/RustPython/RustPython/pull/8507/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8507/files
71cd9bd codegen: preserve symbol tables across copied finally bodies youknowone Aug 13, 2026 https://github.com/RustPython/RustPython/pull/8507/commits/71cd9bdaf80358e834da8f4d3c55291c88370eed
Clear filters https://github.com/RustPython/RustPython/pull/8507/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8507/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8507/files
compile.rs https://github.com/RustPython/RustPython/pull/8507/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
syntax_try.py https://github.com/RustPython/RustPython/pull/8507/files#diff-fa2a957e96b543fe9371c158d5e50fe76e2381702b8600bef492edfe8987d0d0
crates/codegen/src/compile.rshttps://github.com/RustPython/RustPython/pull/8507/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
View file https://github.com/youknowone/RustPython/blob/71cd9bdaf80358e834da8f4d3c55291c88370eed/crates/codegen/src/compile.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8507/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8507/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/8507/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
extra_tests/snippets/syntax_try.pyhttps://github.com/RustPython/RustPython/pull/8507/files#diff-fa2a957e96b543fe9371c158d5e50fe76e2381702b8600bef492edfe8987d0d0
View file https://github.com/youknowone/RustPython/blob/71cd9bdaf80358e834da8f4d3c55291c88370eed/extra_tests/snippets/syntax_try.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8507/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8507/files#diff-fa2a957e96b543fe9371c158d5e50fe76e2381702b8600bef492edfe8987d0d0
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8507/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.