René's URL Explorer Experiment


Title: Reuse stored hashes in dict.fromkeys() by fregataa · Pull Request #8503 · RustPython/RustPython · GitHub

Open Graph Title: Reuse stored hashes in dict.fromkeys() by fregataa · Pull Request #8503 · RustPython/RustPython

X Title: Reuse stored hashes in dict.fromkeys() by fregataa · Pull Request #8503 · RustPython/RustPython

Description: Closes #8490 This PR follows our AI policy Summary dict.fromkeys() recomputed hash for every key even when the source already stored a hash per entry. CPython's _PyDict_FromKeys branches on PyDict_CheckExact / PyAnySet_CheckExact and feeds the hash read from the source table straight into insertdict; RustPython always iterated generically through setitem. The checks are the exact ones CPython uses: a set or dict subclass may override iter, so reading its table directly would change what the call observes. exact_set_keys_with_hashes() is therefore separate from extract_set(), which stays subclass-inclusive for the set operations. Summary by CodeRabbit Performance Improved the efficiency of dict.fromkeys when creating dictionaries from existing dictionaries, sets, or frozensets. Existing key hash information is reused where available, reducing unnecessary computation. Compatibility Behavior remains unchanged for other iterable inputs, which continue to be processed normally.

Open Graph Description: Closes #8490 This PR follows our AI policy Summary dict.fromkeys() recomputed hash for every key even when the source already stored a hash per entry. CPython's _PyDict_FromKeys branches on P...

X Description: Closes #8490 This PR follows our AI policy Summary dict.fromkeys() recomputed hash for every key even when the source already stored a hash per entry. CPython's _PyDict_FromKeys branches ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8503

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d4075e5d-ef44-c748-05cb-96a5b5544f73
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB034:2AF0D8:8F709F:B39EA2:6B0215F7
html-safe-nonce4648824c081aad632ca00695c831b36d27c82c0d7868d11555fd993e8b121040
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDM0OjJBRjBEODo4RjcwOUY6QjM5RUEyOjZCMDIxNUY3IiwidmlzaXRvcl9pZCI6IjQ2NjMzNzk2MzY3MTE5ODY2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8153068aa10dec571fe8d602d6e1a4be7911d9b97e32396a55fa9e15b83613ba
hovercard-subject-tagpull_request:4262616402
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8503/files
twitter:imagehttps://avatars.githubusercontent.com/u/44239739?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/44239739?s=400&v=4
og:image:altCloses #8490 This PR follows our AI policy Summary dict.fromkeys() recomputed hash for every key even when the source already stored a hash per entry. CPython's _PyDict_FromKeys branches on P...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8503/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8503%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8503%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8503/files
Reloadhttps://github.com/RustPython/RustPython/pull/8503/files
Reloadhttps://github.com/RustPython/RustPython/pull/8503/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests131 (131)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
fregataa:fromkeys-known-hashhttps://github.com/fregataa/RustPython/tree/fromkeys-known-hash
Conversation 3 https://github.com/RustPython/RustPython/pull/8503
Commits 2 https://github.com/RustPython/RustPython/pull/8503/commits
Checks 27 https://github.com/RustPython/RustPython/pull/8503/checks
Files changed https://github.com/RustPython/RustPython/pull/8503/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8503/files
Reuse stored hashes in dict.fromkeys() https://github.com/RustPython/RustPython/pull/8503/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/8503/files
324ecaa Reuse stored hashes in dict.fromkeys() fregataa Aug 12, 2026 https://github.com/RustPython/RustPython/pull/8503/commits/324ecaa59b399e90be903f2cb04af9606837e3a5
b13fd86 Make fromkeys_known_hashes a PyDict associated fn fregataa Aug 12, 2026 https://github.com/RustPython/RustPython/pull/8503/commits/b13fd86a4c31d37b249cced5d161bb133053d278
Clear filters https://github.com/RustPython/RustPython/pull/8503/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8503/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8503/files
test_set.py https://github.com/RustPython/RustPython/pull/8503/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
dict.rs https://github.com/RustPython/RustPython/pull/8503/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
set.rs https://github.com/RustPython/RustPython/pull/8503/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
Lib/test/test_set.pyhttps://github.com/RustPython/RustPython/pull/8503/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
View file https://github.com/fregataa/RustPython/blob/b13fd86a4c31d37b249cced5d161bb133053d278/Lib/test/test_set.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8503/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8503/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
https://github.com/RustPython/RustPython/pull/8503/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
crates/vm/src/builtins/dict.rshttps://github.com/RustPython/RustPython/pull/8503/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
View file https://github.com/fregataa/RustPython/blob/b13fd86a4c31d37b249cced5d161bb133053d278/crates/vm/src/builtins/dict.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8503/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8503/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/8503/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/8503/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/8503/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/8503/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/8503/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
crates/vm/src/builtins/set.rshttps://github.com/RustPython/RustPython/pull/8503/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
View file https://github.com/fregataa/RustPython/blob/b13fd86a4c31d37b249cced5d161bb133053d278/crates/vm/src/builtins/set.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8503/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8503/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/8503/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8503/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.